Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev-libs/json-c: add patch for static-libs support, live ebuild and add new maintainers #15586

Closed
wants to merge 3 commits into from
Closed

dev-libs/json-c: add patch for static-libs support, live ebuild and add new maintainers #15586

wants to merge 3 commits into from

Conversation

jsmolic
Copy link
Member

@jsmolic jsmolic commented Apr 30, 2020

Package-Manager: Portage-2.3.89, Repoman-2.3.20
Signed-off-by: Jakov Smolic jakov.smolic@sartura.hr
Signed-off-by: Luka Perkov luka.perkov@sartura.hr

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @jsmolic
Areas affected: ebuilds
Packages affected: dev-libs/json-c

dev-libs/json-c: @gentoo/proxy-maint (maintainer needed)

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added maintainer-needed There is at least one affected package with no maintainer. Review it if you can. assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Apr 30, 2020
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-05-01 02:02 UTC
Newest commit scanned: 45edc19
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/c4bb4a9/output.html

@jsmolic jsmolic changed the title dev-libs/json-c: update to 0.14 and add new maintainers dev-libs/json-c: add new maintainers May 1, 2020
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-05-01 19:42 UTC
Newest commit scanned: 6a622f7
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/faa0bc6/output.html

@jsmolic
Copy link
Member Author

jsmolic commented May 1, 2020

Hi @juippis, could you quickly review this pull request if it is not too much to ask :)
Initially I did a version bump as a part of this PR, but today another Gentoo developer updated json-c package before this request was reviewed and merged.
We would still like to maintain this package. I am aware that it is not a practice to grant package maintenance without any contributions so if needed we are open to contributing to this package
in some way before we can be added as maintainers.

Thank you :)

@juippis
Copy link
Member

juippis commented May 4, 2020

Yeah, if there's "nothing to do" for the package, we'd much prefer to wait until a dev with commit access picks it. However now it was bumped without taking up maintainership.

I checked this morning and this package had two bugs open, you could start by attempting to fix those.

@jsmolic
Copy link
Member Author

jsmolic commented May 4, 2020

@juippis Yes, I saw some new reported bugs for this package, at the time of my first comment they were not opened yet.
I fixed one bug, and I'll be working on fixing others as well.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-05-04 18:29 UTC
Newest commit scanned: 3724e09
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/b441e77/output.html

@jsmolic
Copy link
Member Author

jsmolic commented May 5, 2020

@juippis I fixed static-libs USE flag problem. Right now this enables building either shared or static library, the goal would be to install both shared and static if static-libs support is selected. I've looked into it, and currently CMake system used in json-c source code doesn't support building both shared and static library. That would require patching source.
Is this okay to merge for now, to provide the users the option to select static library support, as they can't do that currently, and I can try to deal with this issue later?

Jakov Smolic and others added 2 commits May 8, 2020 20:41
dev-libs/json-c: add new maintainers
9ec5be3 
Package-Manager: Portage-2.3.89, Repoman-2.3.20
Signed-off-by: Jakov Smolic <jakov.smolic@sartura.hr>
Signed-off-by: Luka Perkov <luka.perkov@sartura.hr>
@hofnarrr
dev-libs/json-c: add patch for static-libs support
493d681 
Enable building both static and shared libraries.
Closes: https://bugs.gentoo.org/720742

Signed-off-by: Anssi Jaatinen <hofnarr@hofnarr.fi>
Signed-off-by: Jakov Smolic <jakov.smolic@sartura.hr>
Signed-off-by: Luka Perkov <luka.perkov@sartura.hr>
@jsmolic jsmolic changed the title dev-libs/json-c: add new maintainers dev-libs/json-c: add patch for static-libs support and add new maintainers May 8, 2020
@hofnarrr
dev-libs/json-c: add live ebuild
0bfdcc2 
Signed-off-by: Anssi Jaatinen <hofnarr@hofnarr.fi>
Signed-off-by: Jakov Smolic <jakov.smolic@sartura.hr>
Signed-off-by: Luka Perkov <luka.perkov@sartura.hr>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-05-08 19:26 UTC
Newest commit scanned: 493d681
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/48d4238da3/output.html

@jsmolic jsmolic changed the title dev-libs/json-c: add patch for static-libs support and add new maintainers dev-libs/json-c: add patch for static-libs support, live ebuild and add new maintainers May 8, 2020
@jsmolic
Copy link
Member Author

jsmolic commented May 8, 2020

@juippis Just a quick update, with @hofnarrr's help new patch for 0.14 ebuild and a 9999 ebuild are added. This solves all problems with static library support.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-05-08 20:06 UTC
Newest commit scanned: 0bfdcc2
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/0d5e5e1c6f/output.html

@jsmolic jsmolic deleted the mainline/json-c-update branch May 12, 2020 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juippis juippis juippis approved these changes

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). maintainer-needed There is at least one affected package with no maintainer. Review it if you can. no bug found No Bug/Closes found in the commits.
Projects
None yet
Milestone
No milestone
5 participants
@jsmolic @gentoo-bot @gentoo-repo-qa-bot @juippis @hofnarrr