dev-python/ipython: bump to 7.14.0; bug #691294 #15674

blinkingtwelve · 2020-05-07T08:19:27Z

Diff with ipython-7.5.0.ebuild:

--- ipython-7.5.0.ebuild	2020-05-07 09:32:45.302702253 +0200
+++ ipython-7.14.0.ebuild	2020-05-07 10:11:55.144347786 +0200
@@ -24,8 +24,8 @@
 	dev-python/jedi[${PYTHON_USEDEP}]
 	dev-python/pexpect[${PYTHON_USEDEP}]
 	dev-python/pickleshare[${PYTHON_USEDEP}]
-	>=dev-python/prompt_toolkit-2[${PYTHON_USEDEP}]
-	<dev-python/prompt_toolkit-2.1[${PYTHON_USEDEP}]
+	>=dev-python/prompt_toolkit-3.0.2[${PYTHON_USEDEP}]
+	<dev-python/prompt_toolkit-3.1[${PYTHON_USEDEP}]
 	dev-python/pygments[${PYTHON_USEDEP}]
 	dev-python/traitlets[${PYTHON_USEDEP}]
 	matplotlib? ( dev-python/matplotlib[${PYTHON_USEDEP}] )

This was based on changed requirements per https://github.com/ipython/ipython/blob/7.14.0/setup.py#L193 . I've lightly tested with prompt_toolkit v3, and not with v2, hence I didn't include v2 in the deps even though it seems (per requirements) that ipython-7.14.0 should work with v2 as well with v3. Moving forward etc 🌤️ .

Closes: https://bugs.gentoo.org/691294
Signed-off-by: blinkingtwelve blinkingtwelve@gavagai.eu

gentoo-bot · 2020-05-07T08:20:11Z

Pull Request assignment

Submitter: @blinkingtwelve
Areas affected: ebuilds
Packages affected: dev-python/ipython

dev-python/ipython: @gentoo/python

Linked bugs

Bugs linked: 691294

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

gentoo-repo-qa-bot · 2020-05-07T08:35:15Z

Pull request CI report

Report generated at: 2020-05-07 08:35 UTC
Newest commit scanned: 146ad54
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/c14f2c9189/output.html

mgorny · 2020-05-07T09:03:42Z

I'll give it a spin. I see the package would use some more fixes but nothing urgent or worth your time.

mgorny

Tests fail for me: dev-python:ipython-7.14.0:20200507-095542.log

I suppose it's a matter of commenting out the right tests. See https://dev.gentoo.org/~mgorny/python-guide/test.html

blinkingtwelve · 2020-05-07T12:55:21Z

Thanks, ran the tests, found the culprit (network-accessing test), and disabled it perusing your guide.

mgorny

Your sign-off needs to contain your real legal name.

mgorny · 2020-05-07T13:03:15Z

dev-python/ipython/ipython-7.14.0.ebuild

@@ -91,6 +91,7 @@ src_test() {

 python_test() {
 	distutils_install_for_testing
+	sed -i 's/^def \(test_embed_svg_url():$\)/def _\1/g' build/test/lib/IPython/core/tests/test_display.py || die


Just edit the source file in prepare_all, also please wrap lines.

gentoo-repo-qa-bot · 2020-05-07T13:10:30Z

Pull request CI report

Report generated at: 2020-05-07 13:10 UTC
Newest commit scanned: 8ba681d
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/b41c0be7b6/output.html

charIes17 · 2020-05-07T15:22:20Z

dev-python/ipython/ipython-7.14.0.ebuild

+inherit distutils-r1 eutils virtualx
+
+DESCRIPTION="Advanced interactive shell for Python"
+HOMEPAGE="http://ipython.org/"


https://ipython.org/

Closes: https://bugs.gentoo.org/691294 Signed-off-by: Rechiw Nymmaard <nymmaard@gavagai.nl>

boerwastaken · 2020-05-08T10:01:11Z

Your sign-off needs to contain your real legal name.

Fixed

gentoo-repo-qa-bot · 2020-05-08T10:15:37Z

Pull request CI report

Report generated at: 2020-05-08 10:15 UTC
Newest commit scanned: ec391fc
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/7d2761db2c/output.html

mgorny · 2020-05-31T06:46:22Z

dev-python/ipython/ipython-7.14.0.ebuild

+
+LICENSE="BSD"
+SLOT="0"
+KEYWORDS="amd64 ~arm ~arm64 ~ppc ppc64 x86 ~amd64-linux ~x86-linux"


You don't bump straight to stable.

mgorny · 2020-05-31T06:46:37Z

dev-python/ipython/ipython-7.14.0.ebuild

+	nbconvert? ( dev-python/nbconvert[${PYTHON_USEDEP}] )"
+
+DEPEND="${CDEPEND}
+	dev-python/setuptools[${PYTHON_USEDEP}]


This is redundant now.

mgorny · 2020-05-31T06:47:16Z

dev-python/ipython/ipython-7.14.0.ebuild

+RDEPEND="${CDEPEND}
+	nbconvert? ( dev-python/nbconvert[${PYTHON_USEDEP}] )"
+
+DEPEND="${CDEPEND}


These go to BDEPEND in EAPI 7. Also, I honestly doubt you need this 'CDEPEND' outside test?

mgorny · 2020-05-31T06:47:42Z

dev-python/ipython/ipython-7.14.0.ebuild

+
+PATCHES=( "${FILESDIR}"/2.1.0-substitute-files.patch )
+
+DISTUTILS_IN_SOURCE_BUILD=1


Is this still necessary?

juippis · 2020-06-25T11:39:52Z

fc844c7

gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels May 7, 2020

mgorny requested changes May 7, 2020

View reviewed changes

mgorny added the no signoff One or more commits do not indicate GCO sign-off. label May 7, 2020

mgorny requested changes May 7, 2020

View reviewed changes

charIes17 reviewed May 7, 2020

View reviewed changes

dev-python/ipython: bump to 7.14.0; bug #691294

ec391fc

Closes: https://bugs.gentoo.org/691294 Signed-off-by: Rechiw Nymmaard <nymmaard@gavagai.nl>

blinkingtwelve force-pushed the bump_dev-python/ipython-7.14.0 branch from 8ba681d to ec391fc Compare May 8, 2020 09:59

mgorny reviewed May 31, 2020

View reviewed changes

juippis closed this Jun 25, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

dev-python/ipython: bump to 7.14.0; bug #691294 #15674

dev-python/ipython: bump to 7.14.0; bug #691294 #15674

blinkingtwelve commented May 7, 2020

gentoo-bot commented May 7, 2020

gentoo-repo-qa-bot commented May 7, 2020

mgorny commented May 7, 2020

mgorny left a comment

blinkingtwelve commented May 7, 2020

mgorny left a comment

mgorny May 7, 2020

boerwastaken May 8, 2020

gentoo-repo-qa-bot commented May 7, 2020

charIes17 May 7, 2020

boerwastaken May 8, 2020

boerwastaken commented May 8, 2020

gentoo-repo-qa-bot commented May 8, 2020

mgorny May 31, 2020

mgorny May 31, 2020

mgorny May 31, 2020

mgorny May 31, 2020

juippis commented Jun 25, 2020


		PATCHES=( "${FILESDIR}"/2.1.0-substitute-files.patch )

		DISTUTILS_IN_SOURCE_BUILD=1

dev-python/ipython: bump to 7.14.0; bug #691294 #15674

dev-python/ipython: bump to 7.14.0; bug #691294 #15674

Conversation

blinkingtwelve commented May 7, 2020

gentoo-bot commented May 7, 2020

Pull Request assignment

Linked bugs

gentoo-repo-qa-bot commented May 7, 2020

Pull request CI report

mgorny commented May 7, 2020

mgorny left a comment

Choose a reason for hiding this comment

blinkingtwelve commented May 7, 2020

mgorny left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gentoo-repo-qa-bot commented May 7, 2020

Pull request CI report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

boerwastaken commented May 8, 2020

gentoo-repo-qa-bot commented May 8, 2020

Pull request CI report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

juippis commented Jun 25, 2020