Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev-python/rarfile: EAPI=7, more Python compat #15794

Closed
wants to merge 1 commit into from
Closed

dev-python/rarfile: EAPI=7, more Python compat #15794

wants to merge 1 commit into from

Conversation

thesamesam
Copy link
Member

@thesamesam thesamesam commented May 14, 2020 •
edited

  • Bumps to EAPI=7
  • Enables tests
  • Adds Python 3.7, 3.8 compatibility

Needed for subliminal bump: #15755

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @thesamesam
Areas affected: ebuilds
Packages affected: dev-python/rarfile

dev-python/rarfile: @whyman

Linked bugs

Bugs linked: 719520

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels May 14, 2020
@thesamesam thesamesam mentioned this pull request May 14, 2020
Closed
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-05-14 19:00 UTC
Newest commit scanned: f83183e
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/35db1dc048/output.html

@whyman
Copy link
Contributor

whyman commented May 15, 2020

Lets just drop the non-r1, it has no value as we would need a revbump for the dep changes anyway.

@thesamesam
dev-python/rarfile: Bump to EAPI=7
d2cb8e5 
* EAPI 7
* Adds Python 3.7, 3.8, PyPy 3
* Enables tests

Package-Manager: Portage-2.3.99, Repoman-2.3.22
Signed-off-by: Sam James (sam_c) <sam@cmpct.info>
@thesamesam
Copy link
Member Author

Done, thank you!

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-05-16 19:05 UTC
Newest commit scanned: d2cb8e5
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/b2e35e3dff/output.html

juippis
juippis reviewed May 23, 2020
View reviewed changes
dev-python/rarfile/rarfile-3.0-r1.ebuild
Comment on lines +16 to +18
IUSE="+compressed"

RDEPEND="compressed? ( || ( app-arch/unrar app-arch/rar ) )"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be done via optfeature.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, although IMO it's not a huge problem for things like Python. I'll do a PR for this when I get time, thank you.

@thesamesam
Copy link
Member Author

@whyman Thank you!

@thesamesam thesamesam deleted the rarfile branch May 29, 2021 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juippis juippis juippis left review comments

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
Milestone
No milestone
5 participants
@thesamesam @gentoo-bot @gentoo-repo-qa-bot @whyman @juippis