Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-qt/qtdeclarative: QQuickItemView: Fix max(X/Y)Extent() #15839

Merged
merged 1 commit into from May 17, 2020

Conversation

a17r
Copy link
Member

@a17r a17r commented May 16, 2020

Works as advertised, gets rid of superfluous scrollbars.

KDE-Bug: https://bugs.kde.org/show_bug.cgi?id=419514
QTBUG: https://bugreports.qt.io/browse/QTBUG-83890
Bug: https://bugs.gentoo.org/716992

@a17r a17r requested a review from Pesa May 16, 2020 23:59
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @a17r
Areas affected: ebuilds
Packages affected: dev-qt/qtdeclarative

dev-qt/qtdeclarative: @gentoo/qt

Linked bugs

Bugs linked: 716992


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels May 17, 2020
Copy link
Contributor

@Pesa Pesa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo in the patch name? (not that it matters)

!<dev-qt/qtquickcontrols-5.7:5
"

PATCHES=("${FILESDIR}/${P}-QQuickItemView-fix-maxXY-event.patch" ) # QTBUG-83890
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

event?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's getting late ;)

KDE-Bug: https://bugs.kde.org/show_bug.cgi?id=419514
QTBUG: https://bugreports.qt.io/browse/QTBUG-83890
Bug: https://bugs.gentoo.org/716992
Package-Manager: Portage-2.3.99, Repoman-2.3.22
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
@a17r a17r added the noci Skip CI for this pull request label May 17, 2020
@gentoo-bot gentoo-bot merged commit f499bde into gentoo:master May 17, 2020
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-05-17 00:31 UTC
Newest commit scanned: 42ef7e4
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/560d6a5a51/output.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. noci Skip CI for this pull request
Projects
None yet
4 participants