Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnome-extra/gnome-commander: remove old, version bump, add ebuild maintainer again #15873

Closed
wants to merge 2 commits into from
Closed

gnome-extra/gnome-commander: remove old, version bump, add ebuild maintainer again #15873

wants to merge 2 commits into from

Conversation

turboscholz
Copy link
Contributor

No description provided.

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @turboscholz
Areas affected: ebuilds
Packages affected: gnome-extra/gnome-commander

gnome-extra/gnome-commander: @gentoo/proxy-maint (maintainer needed)

Linked bugs

Bugs linked: 696474

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added maintainer-needed There is at least one affected package with no maintainer. Review it if you can. assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels May 18, 2020
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-05-18 22:30 UTC
Newest commit scanned: 34a0ad6
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/f52be8005e/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-05-19 05:21 UTC
Newest commit scanned: 0ece9d8
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/dc7bc2fdbf/output.html

a17r
a17r suggested changes Jun 2, 2020
View reviewed changes
Copy link
Member

@a17r a17r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If getting rid of the exiv2 patch is the only delta over 1.10.1, we could safely start stabilisation after the bump.

gnome-extra/gnome-commander/metadata.xml Outdated
Comment on lines 4 to 11
<maintainer type="person">
<email>u.scholz83@gmx.de</email>
<name>Uwe Scholz</name>
</maintainer>
<maintainer type="project">
<email>proxy-maint@gentoo.org</email>
<name>Proxy Maintainers</name>
</maintainer>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please just add yourself+proxy-maint to metadata.xml, in line with existing indentation. It should not lead to all these unrelated line changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I don't know how this happened. I was just doing a "git revert a4ca3f3", which was actually done by @juippis ...

gnome-extra/gnome-commander/Manifest Outdated
DIST gnome-commander-1.10.1.tar.xz 7424500 BLAKE2B 6abddf8dae4bc0a1d740ffee49ccc7d816d783bdb5c2b90c9d0681c1db5fa3f42700e65a780881400c1af038d7dfe7f458a98cf2f8f1c1b0fc6f93a3d58dc069 SHA512 b5bc548444149e00f29e6e3b7f785c99a08d27a0a2642cf78c203411a8d2937341a76685b09172047162afe3e0fc92ff13c82bdbd8105281d360c1df44b4702d
DIST gnome-commander-1.10.0.tar.xz 7421328 BLAKE2B 4cfb6a5d445217de10007d4371cd5cce95319dd68a6e7f071def2258cd965cfbeab671c6016e624ef474501608214f309c56360216cc53c83a1660b38dbe77d9 SHA512 76e2cca3af7e11ae7f327fa25bb175ad28d36d8b71c4908ce8b91533ed53a444a30d861a24cf94ee34dd7954d1f9dd0a14d26c2214854424b80f8e7c107db60d

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please drop that superfluous empty line (looks like manual editing rather than using repoman or ebuild for generating the manifest?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I normaly use repoman, but here I actually added the line manually and accidentally. ;)

@turboscholz
gnome-extra/gnome-commander: version bump to 1.10.2
28d1755 
Closes: https://bugs.gentoo.org/696474

Reported-by: Michał Górny <mgorny@gentoo.org>
Signed-off-by: Uwe Scholz <u.scholz83@gmx.de>
@turboscholz
gnome-extra/gnome-commander: Revert "drop to m-n"
7eb8d7d 
This reverts commit a4ca3f3.

Signed-off-by: Uwe Scholz <u.scholz83@gmx.de>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-06-07 15:08 UTC
Newest commit scanned: 7eb8d7d
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/27723162ab/output.html

@gentoo-bot gentoo-bot closed this in 028cfa9 Jun 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a17r a17r a17r requested changes

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. maintainer-needed There is at least one affected package with no maintainer. Review it if you can.
Projects
None yet
Milestone
No milestone
4 participants
@turboscholz @gentoo-bot @gentoo-repo-qa-bot @a17r