Add udpated ebuild so that the package supports current gcc #15903
Conversation
Pull Request assignmentSubmitter: @dr-diem games-action/dxx-rebirth: @gentoo/games, Linked bugsNo bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment. If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers. Missing GCO sign-offPlease read the terms of Gentoo Certificate of Origin and acknowledge them by adding a sign-off to all your commits. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
assigned
…nt packages from the upstream project Signed-off-by: Ian Silvester iansilvester@fastmail.fm Closes: https://bugs.gentoo.org/669212 Closes: https://bugs.gentoo.org/703090
Though this older ebuild only compiles with gcc 6.5.0 and is therefore outdated, it is not for me to delete it outright Signed-off-by: Ian Silvester iansilvester@fastmail.fm
…pyright statement to ebuild Signed-off-by: Ian Silvester iansilvester@fastmail.fm
Signed-off-by: Ian Silvester iansilvester@fastmail.fm
Signed-off-by: Ian Silvester iansilvester@fastmail.fm
…metadata.xml Signed-off-by: Ian Silvester iansilvester@fastmail.fm
…zip for source code Signed-off-by: Ian Silvester iansilvester@fastmail.fm
Pull request CI reportReport generated at: 2020-05-22 15:26 UTC New issues caused by PR: There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
dr-diem
changed the title
|
Closes: https://bugs.gentoo.org/724882 |
There was a problem hiding this comment.
I'm aware you're still working on this but your first two commits are missing sign-off headers so I can't merge this as is. You'll need to rebase this anyway. When you do, please squash those commits into the earlier ones to reduce the noise.
Although I have requested changes, I am pleased to report that the games do build and work!
| <email>totktonada.ru@gmail.com</email> | ||
| <name>Alexander Turenko</name> | ||
| <email>iansilvester@fastmail.fm</email> | ||
| <name>Ian Silvester</name> |
There was a problem hiding this comment.
You will need to rebase your changes on the latest master as the existing maintainer has already been dropped.
There was a problem hiding this comment.
Currently testing locally. When that's done I'll tackle the rebase and combining the commits to just one, that has the correct headers including sign-off.
There was a problem hiding this comment.
Okay, the changes are all in and the commit history cleaned up. I did rebase to latest master, so I don't know why there remains a conflict on metadata.xml. Feel free to remove me as moderator; I am not listed in the file in my repo.
The only other CI warnings are for the copyright message (which we've discussed) and now from the 0.59 ebuild that doesn't recognize the USE flags that the new ebuild introduces.
Looking forward to your feedback @chewi !
|
I'm withdrawing this PR on the basis that I have combined changes relating to three, albeit inter-related, packages in one commit. I will raise a new one containing three separate 'clean' commits. |
|
As discussed, remember you can always |
Also fixes bugs 669212 & 703090.