dev-qt/qtwebengine: add ~ppc64 keyword and patchset #15982
Conversation
Pull Request assignmentSubmitter: @gyakovlev dev-qt/qtwebengine: @gentoo/qt Linked bugsNo bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment. If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
assigned
Pull request CI reportReport generated at: 2020-05-27 02:26 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
|
actually, patchset is a bit dirty, need to get rid of .orig files, so don't merge, let's just discuss =) |
gyakovlev
force-pushed
the
qtwebengine-ppc64
branch
from
f09f175
to
e49d119
Compare
Pull request CI reportReport generated at: 2020-05-27 10:52 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
There was a problem hiding this comment.
I'm ok with accepting this patchset in principle, given that you can be considered the "upstream" for ppc64 support in chromium. But see the ebuild comments.
Do you maintain a branch or fork where you develop/rebase these patches? Might be useful to mention it somewhere.
patches are from here https://github.com/chromium-ppc64le/ and that's the upstream for ppc64 support, it's also used by ungoogled-chromium, electron port and others. I maintain local patches for myself and some users. No git right now, but there will be a repo soon, it's work in progress. Since I could not get ppc64 patches and keywords get to gentoo (chromium moves way to fast, patches lag a bit), current gentoo chromium ebuild only supports ppc64 glue, it has some logic in it, but does not have keywords. Users run a script that downloads correct patches to build on gentoo and place them to |
gyakovlev
force-pushed
the
qtwebengine-ppc64
branch
2 times, most recently
from
6fa8463
to
023d2c2
Compare
| @@ -85,6 +88,9 @@ PATCHES=( | |||
| ) | |||
|
|
|||
| src_prepare() { | |||
| if use ppc64; then | |||
| eapply "${WORKDIR}/${PN}-ppc64" | |||
| fi | |||
There was a problem hiding this comment.
(nit) add an empty line after this
Package-Manager: Portage-2.3.100, Repoman-2.3.22 Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>
Package-Manager: Portage-2.3.100, Repoman-2.3.22 Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>
gyakovlev
force-pushed
the
qtwebengine-ppc64
branch
from
023d2c2
to
7a0437c
Compare
Pull request CI reportReport generated at: 2020-05-27 23:12 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Sync metadata with Gentoo ebuild repo. Package-Manager: Portage-3.0.6, Repoman-3.0.1 Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org> Closes: gentoo/gentoo#15982 Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>
Sync metadata with Gentoo ebuild repo. Package-Manager: Portage-3.0.6, Repoman-3.0.1 Closes: gentoo/gentoo#15982 Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org> Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
Hi =)
It's me as promised.
Here's how I think it can be handled more or less safely. I'll maintain patchset, it's very unlikely to change. I used it for entire lifetime of qt-5.13 and 5.14 and not a single change was needed.
No extra keywords planned this time to give it some time to rest in the tree, and see how things go.
maybe just Falkon and unmask webengine useflag for kdecore-meta only, so people can get a working browser.
the only browser that works without patching on ppc64 currently is firefox, but it lacks JS Jit, so JS heavy sites can be laggy. Having falkon as an options is a nice bonus.
I also maintain chromium patchset for ppc64le, which is on version 83 so far, so I have some time discover issues with patches, since qtwebengine is always behind.
Package-Manager: Portage-2.3.100, Repoman-2.3.22
Signed-off-by: Georgy Yakovlev gyakovlev@gentoo.org