Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

media-libs/vulkan-loader: add missing flag-o-matic inherit #16016

Closed
wants to merge 1 commit into from

Conversation

mm1ke
Copy link
Contributor

@mm1ke mm1ke commented May 30, 2020

Package-Manager: Portage-2.3.100, Repoman-2.3.22
Signed-off-by: Michael Mair-Keimberger m.mairkeimberger@gmail.com

Hi

All ebuilds are calling append-cflags from the flag-o-matic eclass but they don't inherit the eclass. I've fixed the ebuilds and added the flag-o-matic eclass. (it still worked because it got indirectly inherited)

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @mm1ke
Areas affected: ebuilds
Packages affected: media-libs/vulkan-loader

media-libs/vulkan-loader: @gentoo/x11

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels May 30, 2020
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-05-30 17:12 UTC
Newest commit scanned: 5e109d7
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/be2aa07af5/output.html

@sarnex sarnex self-assigned this May 30, 2020
@sarnex
Copy link
Member

sarnex commented May 30, 2020

Looks good, thanks. Only thing, can you please revert the change to vulkan-loader-1.1.125.ebuild?
It's stable on x86 and amd64 so we can't modify the ebuild at all without dropping to testing. We can just use the vulkan-loader-1.1.125-r1.ebuild for the change in the 1.1.125 branch.

Thanks,
Sarnex

@@ -21,7 +21,7 @@ else
S="${WORKDIR}"/${MY_P}
fi

inherit toolchain-funcs python-any-r1 cmake-multilib
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the change to this file

Package-Manager: Portage-2.3.100, Repoman-2.3.22
Signed-off-by: Michael Mair-Keimberger <m.mairkeimberger@gmail.com>
@mm1ke
Copy link
Contributor Author

mm1ke commented May 30, 2020

@sarnex Done, i've reverted the change for the 1.1.125 ebuild.

@sarnex
Copy link
Member

sarnex commented May 30, 2020

Thanks, will pull soon

@mm1ke mm1ke deleted the vulk-muhn2Ibc branch October 28, 2020 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits.
Projects
None yet
4 participants