-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
media-libs/vulkan-loader: add missing flag-o-matic inherit #16016
Conversation
Pull Request assignmentSubmitter: @mm1ke media-libs/vulkan-loader: @gentoo/x11 Linked bugsNo bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment. If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
Pull request CI reportReport generated at: 2020-05-30 17:12 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Looks good, thanks. Only thing, can you please revert the change to vulkan-loader-1.1.125.ebuild? Thanks, |
@@ -21,7 +21,7 @@ else | |||
S="${WORKDIR}"/${MY_P} | |||
fi | |||
|
|||
inherit toolchain-funcs python-any-r1 cmake-multilib |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert the change to this file
Package-Manager: Portage-2.3.100, Repoman-2.3.22 Signed-off-by: Michael Mair-Keimberger <m.mairkeimberger@gmail.com>
@sarnex Done, i've reverted the change for the 1.1.125 ebuild. |
Thanks, will pull soon |
Package-Manager: Portage-2.3.100, Repoman-2.3.22
Signed-off-by: Michael Mair-Keimberger m.mairkeimberger@gmail.com
Hi
All ebuilds are calling
append-cflags
from theflag-o-matic
eclass but they don't inherit the eclass. I've fixed the ebuilds and added theflag-o-matic
eclass. (it still worked because it got indirectly inherited)