media-libs/opencollada: Version bump to 1.6.18 and update to EAPI 6: Bug 584670 #1614
Conversation
dracwyrm
changed the title
Amynka
added
version bump
assigned
|
|
||
| SLOT="0" | ||
|
|
||
| if [[ ${PV} != *9999* ]]; then |
There was a problem hiding this comment.
You could keep these lines and update 9999 with the fixed SRC_URI so that future releases can be easily created from live ebuild.
There was a problem hiding this comment.
I thought those made the ebuilds a bit messy and thought the non-live ebuilds were used to bump. I'll add that back into the live ebuild.
There was a problem hiding this comment.
It depends on how the package is maintained, though when I see a live ebuild in tree I always expect it to be at least on par with latest release and potentially already ahead with deps etc. E.g. libreoffice-9999 is updated several times before a new major release is created out of it.
|
@a17r: I added that information back in and pushed the changes. I put it in both so they look the same. The old ebuild can hopefully be removed soon as repoman really didn't like it. |
|
Sorry, no time. I'm all happy if someone takes over. |
|
@gentoo/proxy-maint |
|
Squashed the four commits into one and pushed the changes to the PR. Now there is only one commit since the other commits were tidy ups of the ebuilds. |
| DEPEND="${RDEPEND} | ||
| sys-apps/findutils | ||
| sys-apps/sed" | ||
| DEPEND="${RDEPEND}" | ||
|
|
||
| BUILD_DIR="${S}"/build |
|
Squashing those makes sense, thx. In the past I was asked to split removing files and bumping ebuild into different commits, as they are not related in this case, but it might be merged either way. ;) |
|
New ebuild works fine for me, but I have yet to rebuild libreoffice to confirm. |
|
@a17r: Should I split the patch into two to have the removal of old patches separate? I've rebuild LibreOffice, and it's a works for me sort of thing at the moment until there are other testers. |
|
It's fine for me but I don't have the powers of the devs, just a lot of reviewed-by ;) @gentoo/openoffice |
|
@a17r : I pushed through some changes you suggested about the checks for live code at the top. I changed the comments a bit as well. BUILD_DIR="${S}"/build is needed or you get an install error, at least on my system. It was in the original ebuild, and I too wondered why. After you mentioned it can be removed, I reinstalled and it failed where having it in does not. I suspect a broken makefile on the install part, because the compile part works perfectly. Unfortunately, MY_SOVERSION is needed to have the version number on the end of .so files. |
dracwyrm
changed the title
-Version bump to v1.6.18: Upstream releasing proper versions now -Using full EAPI compliance for new and live ebuild -Delete old patches not in use anymore -Closes Gentoo Bug: 584670 -Fixes based on help from gentoo-proxy-maint -Changed comments to explain that certain things are needed
-Version bump to v1.6.18: Upstream releasing proper versions now
-Using full EAPI compliance for new and live ebuild
-Delete old patches not in use anymore
-Closes Gentoo Bug: 584670
-Too much going on for me to submit a patch mentioned in that report
Yeah, I spelled OpenCollada wrong in the title of the bug report.