Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yasm: Respect portage host cc variable #16180

Closed
wants to merge 1 commit into from
Closed

yasm: Respect portage host cc variable #16180

wants to merge 1 commit into from

Conversation

m-gupta
Copy link
Contributor

@m-gupta m-gupta commented Jun 11, 2020

Pass CC_FOR_BUILD and CCLD_FOR_BUILD to econf.
Otherwise it invokes cc instead of portage specified HOST/BUILD CC.

Signed-off-by: Manoj Gupta manojgupta@google.com

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @m-gupta
Areas affected: ebuilds
Packages affected: dev-lang/yasm

dev-lang/yasm: @gentoo/base-system

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Jun 11, 2020
floppym
floppym suggested changes Jun 11, 2020
View reviewed changes
Copy link
Contributor

@floppym floppym left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix your commit messages.

https://www.gentoo.org/glep/glep-0066.html#id9

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-06-11 01:52 UTC
Newest commit scanned: 5321d0f
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/ff0ba6acb8/output.html

@m-gupta
dev-lang/yasm: Respect portage host cc variable
1b79428 
Pass CC_FOR_BUILD and CCLD_FOR_BUILD to econf.
Otherwise it invokes cc instead of portage specified HOST/BUILD CC.

Signed-off-by: Manoj Gupta <manojgupta@google.com>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-06-12 00:32 UTC
Newest commit scanned: 1b79428
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/813df452b1/output.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floppym floppym floppym requested changes

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits.
Projects
None yet
Milestone
No milestone
4 participants
@m-gupta @gentoo-bot @gentoo-repo-qa-bot @floppym