Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dev-ruby/travis deps #1620

Merged
merged 1 commit into from Jun 11, 2016
Merged

Conversation

junghans
Copy link
Contributor

@junghans junghans commented Jun 7, 2016

Travis needs =typhoeus-0.6:

 travis
/usr/lib64/ruby/site_ruby/2.1.0/rubygems/dependency.rb:298:in `to_specs': Could not find 'typhoeus' (>= 0.6.8, ~> 0.6) - did find: [typhoeus-1.0.2] (Gem::LoadError)

@gentoo/ruby: works for, but please review!

@graaff
Copy link
Member

graaff commented Jun 8, 2016

Note our policy on versioning in ruby: https://wiki.gentoo.org/wiki/Project:Ruby/Packaging_RubyGems#Version_numbers_and_slots

The error also says that it needs ~> 0.6 which translates to "=0* >=0.6" in terms of Gentoo dependencies. So you can bring back the latest 0.x version of typhoeus instead of an older version.

Typhoeus does not have a changelog so it's not clear if the API actually changed. They say the adhere to semver, but going from 0.x to 1.x doesn't indicate an API change perse. Looking at travis-ci/travis.rb@b900205 they just seem overcautious, so just fixing the version in travis may work as well without the need to bring back an old slot.

@graaff
Copy link
Member

graaff commented Jun 8, 2016

@junghans
Copy link
Contributor Author

Good point!

Fix gentoo#1648 gh
Gentoo-bug: 578458

Package-Manager: portage-2.2.28
@gentoo-bot gentoo-bot merged commit effd69d into gentoo:master Jun 11, 2016
@junghans junghans deleted the dev-ruby/typhoeus branch June 11, 2016 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants