Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

media-sound/supercollider-3.11.0: fix tests #16382

Closed
wants to merge 1 commit into from
Closed

media-sound/supercollider-3.11.0: fix tests #16382

wants to merge 1 commit into from

Conversation

marcan
Copy link
Contributor

@marcan marcan commented Jun 23, 2020

Qt wants X11 by default, so tell it to run offscreen instead.

Closes: https://bugs.gentoo.org/656436
Package-Manager: Portage-2.3.101, Repoman-2.3.22
Signed-off-by: Hector Martin marcan@marcan.st

@marcan
media-sound/supercollider-3.11.0: fix tests
d969bcb 
Qt wants X11 by default, so tell it to run offscreen instead.

Closes: https://bugs.gentoo.org/656436
Package-Manager: Portage-2.3.101, Repoman-2.3.22
Signed-off-by: Hector Martin <marcan@marcan.st>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @marcan
Areas affected: ebuilds
Packages affected: media-sound/supercollider

media-sound/supercollider: @marcan, @gentoo/proxy-maint

Linked bugs

Bugs linked: 656436

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Jun 23, 2020
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-06-23 07:17 UTC
Newest commit scanned: d969bcb
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/4be6d68162/output.html

@marcan
Copy link
Contributor Author

marcan commented Jun 29, 2020

(note: tests are still flaky due to an upstream issue, but this is still necessary so it should go in for now)

juippis
juippis approved these changes Jul 19, 2020
View reviewed changes
Copy link
Member

@juippis juippis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this might work, maybe using virtx.eclass is better suited for this?

@marcan
Copy link
Contributor Author

marcan commented Jul 19, 2020

I don't think we actually need X/graphics (virtual or not) for this, it's just that when built with X support it refuses to run the tests without DISPLAY set up when using that Qt backend.

expeditioneer pushed a commit to expeditioneer/gentoo-portage that referenced this pull request Jul 21, 2020
@marcan @expeditioneer
media-sound/supercollider: fix tests on 3.11.0
d40805e 
Qt wants X11 by default, so tell it to run offscreen instead.

Closes: https://bugs.gentoo.org/656436
Package-Manager: Portage-2.3.101, Repoman-2.3.22
Signed-off-by: Hector Martin <marcan@marcan.st>
Closes: gentoo#16382
Signed-off-by: Joonas Niilola <juippis@gentoo.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juippis juippis juippis approved these changes

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
Milestone
No milestone
4 participants
@marcan @gentoo-bot @gentoo-repo-qa-bot @juippis