Add linguist-tools to dependencies #16569
Conversation
Pull Request assignmentSubmitter: @pavel-the-best media-gfx/flameshot: @pavel-the-best, @gentoo/proxy-maint Linked bugsBugs linked: 730428 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
self-maintained
Pull request CI reportReport generated at: 2020-07-03 13:26 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
| @@ -22,6 +22,7 @@ DEPEND=" | |||
| dev-qt/qtsvg:5 | |||
| dev-qt/qtnetwork:5 | |||
| dev-qt/qtdbus:5 | |||
| dev-qt/linguist-tools:5 | |||
There was a problem hiding this comment.
With EAPI-7 this is a BDEPEND. Can you update your commit summary to match our requirements?
https://www.gentoo.org/glep/glep-0066.html#commit-messages
There was a problem hiding this comment.
It seems, that commit summary already matches the requirements
There was a problem hiding this comment.
It seems, that commit summary already matches the requirements
not at all. just read the link provided to you. and had you used repoman commit, the part that is missing would have been prepared for you.
There was a problem hiding this comment.
Oh, I see. Thanks, I didn't know about repoman commit.
Pull request CI reportReport generated at: 2020-07-14 18:58 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
| BDEPEND=" | ||
| ${DEPEND} | ||
| dev-qt/linguist-tools:5 | ||
| " |
There was a problem hiding this comment.
BDEPEND is a split from DEPEND, so BDEPEND="${DEPEND}" is wrong by design :)
Simple BDEPEND="dev-qt/linguist-tools:5" works here. Rest looks good.
Closes: https://bugs.gentoo.org/730428 Signed-off-by: Pavel Kalugin <paul.kalug@gmail.com>
Pull request CI reportReport generated at: 2020-07-16 06:22 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Closes: https://bugs.gentoo.org/730428 Signed-off-by: Pavel Kalugin <paul.kalug@gmail.com> Closes: gentoo#16569 Signed-off-by: Joonas Niilola <juippis@gentoo.org>
Closes: https://bugs.gentoo.org/730428
Signed-off-by: Pavel Kalugin paul.kalug@gmail.com