Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Net news/newsboat #16601

Closed
wants to merge 1 commit into from
Closed

Net news/newsboat #16601

wants to merge 1 commit into from

Conversation

janko-j1
Copy link
Contributor

@janko-j1 janko-j1 commented Jul 5, 2020

No description provided.

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @janko-j1
Areas affected: ebuilds
Packages affected: net-news/newsboat

net-news/newsboat: @cedk

Linked bugs

Bugs linked: 730420

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Jul 5, 2020
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-07-05 16:11 UTC
Newest commit scanned: e3f5ea9
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/18ad00e288/output.html

@thesamesam
Copy link
Member

It looks like you can remove the dependency commit, right?

thesamesam
thesamesam reviewed Jul 16, 2020
View reviewed changes
net-news/newsboat/files/newsboat-2.13-json-c-0.14.0.patch Outdated
@@ -0,0 +1,34 @@
From db70049f436a965767e8a1273389e1be92e946fa Mon Sep 17 00:00:00 2001
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link to where this is from?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line references the commit in newsboat where the patch was merged (date is screwed up though): I'm not sure I understood what you wanted but modified the header with the github url of the merged pull request which applied the patch.

I removed the dependency commit, thanks for catching that up!

net-news/newsboat: Apply json-c-0.14 fix
9e67422 
Closes: https://bugs.gentoo.org/730420
Package-Manager: Portage-2.3.99, Repoman-2.3.22
Signed-off-by: David Denoncin <ddenoncin@gmail.com>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-07-16 07:01 UTC
Newest commit scanned: 9e67422
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/abe0094360/output.html

@gentoo-bot gentoo-bot closed this in 8ca9025 Aug 1, 2020
@janko-j1 janko-j1 deleted the net-news/newsboat branch August 2, 2020 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thesamesam thesamesam thesamesam left review comments

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
Milestone
No milestone
4 participants
@janko-j1 @gentoo-bot @gentoo-repo-qa-bot @thesamesam