dev-python/flask-paginate: bumped to 0.5.5 #16800
Conversation
Signed-off-by: Florian Förster <foerster.florianjr@gmail.com> Closes: https://bugs.gentoo.org/717526 Package-Manager: Portage-3.0.0, Repoman-2.3.23
Pull Request assignmentSubmitter: @florianjr dev-python/flask-paginate: @gentoo/proxy-maint, @stkw0, @gentoo/python Linked bugsBugs linked: 717526 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
assigned
Pull request CI reportReport generated at: 2020-07-24 16:06 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
|
Could I help maintaining this package furthermore? |
I will be glad if you maintain this, maybe you can add yourself to the maintainers list. :) |
|
How can I do this? :) |
|
There is a file called metadata.xml with a list of maintainers. But I think before that a Gentoo developer should register you as a maintainer. |
|
Who should I contact? Then I can push it again with the right metadata. |
|
You mean as a proxy-maintainer? |
Yes. There is an IRC channel where you can ask. |
Package-Manager: Portage-3.0.0, Repoman-2.3.23
|
Here i added myself to the maintainers list, i think this should be enough. |
Pull request CI reportReport generated at: 2020-07-26 07:31 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
|
@stkw0 is this now enough to be merged? |
Version 0.7.0 is available, maybe we should bump to that version instead of 0.5.5. Also seems you forgot to update MY_COMMIT variable? It seems to be the same commit than in the older version. |
|
I’m kinda newbie, could you explain me the difference between $MY_COMMIT and $PV? I’ll do the bump later. Thanks for your attention :) |
Package-Manager: Portage-3.0.0, Repoman-2.3.23
|
I’ve now bumped it again to newest version (0.6.0) |
| DESCRIPTION="Pagination support for flask" | ||
| HOMEPAGE="https://flask-paginate.readthedocs.io" | ||
| # https://github.com/lixxu/flask-paginate/issues/68 | ||
| SRC_URI="https://github.com/lixxu/flask-paginate/archive/${MY_COMMIT}.tar.gz -> ${P}.tar.gz" |
There was a problem hiding this comment.
0.7.0 is the latest version, and this is not correct, you should use SRC_URI="https://github.com/lixxu/flask-paginate/archive/${PV}.tar.gz"
There was a problem hiding this comment.
Please also remove that comment line in new ebuilds. Now that the issue have been fixed it only disturbs :)
Thank you for your effort.
|
|
||
| inherit distutils-r1 | ||
|
|
||
| MY_COMMIT="510ad833106134711868653fb597bf75ea8ac34f" |
There was a problem hiding this comment.
This commit is from 0.5.3 version (lixxu/flask-paginate@510ad83)
|
Ohhhh sorry. I’ll open a new and “clean” PR later, thanks for your help :) |
You don't need to do that. git rebase can do magic to fixup commits, remove commits and so ;) |
Pull request CI reportReport generated at: 2020-07-28 20:51 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Signed-off-by: Florian Förster foerster.florianjr@gmail.com
Closes: https://bugs.gentoo.org/717526
Package-Manager: Portage-3.0.0, Repoman-2.3.23