games-action/minetest: Add prometheus client support #16840

vilhelmgray · 2020-07-26T18:50:26Z

No description provided.

gentoo-bot · 2020-07-26T18:52:20Z

Pull Request assignment

Submitter: @vilhelmgray
Areas affected: ebuilds
Packages affected: dev-cpp/benchmark, dev-cpp/prometheus-cpp, games-action/minetest, www-servers/civetweb

dev-cpp/benchmark: @gentoo/proxy-maint (new package)
dev-cpp/prometheus-cpp: @gentoo/proxy-maint (new package)
games-action/minetest: @vilhelmgray, @gentoo/proxy-maint, @gentoo/games
www-servers/civetweb: @zmedico

Linked bugs

Bugs linked: 733984, 733980

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

gentoo-repo-qa-bot · 2020-07-26T20:56:16Z

Pull request CI report

Report generated at: 2020-07-26 20:56 UTC
Newest commit scanned: defc959
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/d6ee112d9d/output.html

zmedico · 2020-07-27T01:13:12Z

Pull Request assignment

www-servers/civetweb: @zmedico

Merged in fc7e00f.

juippis

Could you also rebase and drop the civetweb commit?

dev-cpp/benchmark/benchmark-1.5.1.ebuild

dev-cpp/benchmark/metadata.xml

dev-cpp/prometheus-cpp/metadata.xml

juippis · 2020-08-08T07:12:02Z

dev-cpp/prometheus-cpp/prometheus-cpp-0.9.0.ebuild

+LICENSE="MIT"
+SLOT="0"
+KEYWORDS="~amd64 ~x86"
+IUSE="+pull +push test zlib"


These aren't very descriptive... What do they actually do? Should they be enabled unconditionally instead?

pull will build the libprometheus-cpp-pull.so.0.9.0 library, while push will build the libprometheus-cpp-push.so.0.9.0 library; these respectively enable clients to pull and push data from/to a prometheus server. These two libraries seem to be relatively small (36K and 76K respectively) so I don't think it'll be that bad to just build them unconditionally. I'll remove these flags then.

dev-cpp/prometheus-cpp/prometheus-cpp-0.9.0.ebuild

gentoo-repo-qa-bot · 2020-08-08T15:47:17Z

Pull request CI report

Report generated at: 2020-08-08 15:47 UTC
Newest commit scanned: ab86d6c
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/9da3393373/output.html

juippis

46/61 Test #60: run_state_assembly_test_CHECK ..............***Failed    0.01 sec

98% tests passed, 1 tests failed out of 61

Total Test time (real) =   3.04 sec

The following tests FAILED:
	 60 - run_state_assembly_test_CHECK (Failed)
Errors while running CTest
 * ERROR: dev-cpp/benchmark-1.5.1::testworld failed (test phase):
 *   Tests failed. When you file a bug, please attach the following file: 
 * 	/var/tmp/portage/dev-cpp/benchmark-1.5.1/work/benchmark-1.5.1_build/Testing/Temporary/LastTest.log

You will most likely receive a bug report about it soon.

>>> Test phase: dev-cpp/prometheus-cpp-0.9.0
 * Working in BUILD_DIR: "/var/tmp/portage/dev-cpp/prometheus-cpp-0.9.0/work/prometheus-cpp-0.9.0_build"
ctest -j 16 --test-load 16
Test project /var/tmp/portage/dev-cpp/prometheus-cpp-0.9.0/work/prometheus-cpp-0.9.0_build
    Start 1: prometheus_test
    Start 2: benchmarks
1/2 Test #1: prometheus_test ..................***Failed    1.79 sec
2/2 Test #2: benchmarks .......................   Passed  129.71 sec

50% tests passed, 1 tests failed out of 2

Label Time Summary:
Benchmark    = 129.71 sec*proc (1 test)

Total Test time (real) = 129.71 sec

The following tests FAILED:
	  1 - prometheus_test (Failed)
Errors while running CTest
 * ERROR: dev-cpp/prometheus-cpp-0.9.0::testworld failed (test phase):
 *   Tests failed. When you file a bug, please attach the following file: 
 * 	/var/tmp/portage/dev-cpp/prometheus-cpp-0.9.0/work/prometheus-cpp-0.9.0_build/Testing/Temporary/LastTest.log

 * Messages for package dev-cpp/prometheus-cpp-0.9.0:

 * One or more CMake variables were not used by the project:
 *   THIRDPARTY_CIVETWEB_WITH_SSL

I can't test minetest due to a bug in dependency,
https://bugs.gentoo.org/736342 but please do check the cmake variable being correct (is there a typo?) while we wait for this to be fixed.

vilhelmgray · 2020-08-16T13:42:19Z

46/61 Test #60: run_state_assembly_test_CHECK ..............***Failed    0.01 sec

98% tests passed, 1 tests failed out of 61

Total Test time (real) =   3.04 sec

The following tests FAILED:
	 60 - run_state_assembly_test_CHECK (Failed)
Errors while running CTest
 * ERROR: dev-cpp/benchmark-1.5.1::testworld failed (test phase):
 *   Tests failed. When you file a bug, please attach the following file: 
 * 	/var/tmp/portage/dev-cpp/benchmark-1.5.1/work/benchmark-1.5.1_build/Testing/Temporary/LastTest.log

You will most likely receive a bug report about it soon.

Looks like this is testing the assembly code produced by the compiler. This might be an upstream problem so I'll open a issue page about this with them.

>>> Test phase: dev-cpp/prometheus-cpp-0.9.0
 * Working in BUILD_DIR: "/var/tmp/portage/dev-cpp/prometheus-cpp-0.9.0/work/prometheus-cpp-0.9.0_build"
ctest -j 16 --test-load 16
Test project /var/tmp/portage/dev-cpp/prometheus-cpp-0.9.0/work/prometheus-cpp-0.9.0_build
    Start 1: prometheus_test
    Start 2: benchmarks
1/2 Test #1: prometheus_test ..................***Failed    1.79 sec
2/2 Test #2: benchmarks .......................   Passed  129.71 sec

50% tests passed, 1 tests failed out of 2

Label Time Summary:
Benchmark    = 129.71 sec*proc (1 test)

Total Test time (real) = 129.71 sec

The following tests FAILED:
	  1 - prometheus_test (Failed)
Errors while running CTest
 * ERROR: dev-cpp/prometheus-cpp-0.9.0::testworld failed (test phase):
 *   Tests failed. When you file a bug, please attach the following file: 
 * 	/var/tmp/portage/dev-cpp/prometheus-cpp-0.9.0/work/prometheus-cpp-0.9.0_build/Testing/Temporary/LastTest.log

I'm unable to reproduce this failure. I get the following:

>>> Test phase: dev-cpp/prometheus-cpp-0.9.0
 * Working in BUILD_DIR: "/var/tmp/portage/dev-cpp/prometheus-cpp-0.9.0/work/prometheus-cpp-0.9.0_build"
ctest -j 5 --test-load 999
Test project /var/tmp/portage/dev-cpp/prometheus-cpp-0.9.0/work/prometheus-cpp-0.9.0_build
    Start 1: prometheus_test
    Start 2: benchmarks
1/2 Test #1: prometheus_test ..................   Passed    2.21 sec
2/2 Test #2: benchmarks .......................   Passed  136.15 sec

100% tests passed, 0 tests failed out of 2

Label Time Summary:
Benchmark    = 136.15 sec*proc (1 test)

Total Test time (real) = 136.15 sec
 * Tests succeeded.
>>> Completed testing dev-cpp/prometheus-cpp-0.9.0

How are you executing this test? Maybe we have some difference in USE flags?

 * Messages for package dev-cpp/prometheus-cpp-0.9.0:

 * One or more CMake variables were not used by the project:
 *   THIRDPARTY_CIVETWEB_WITH_SSL
I can't test minetest due to a bug in dependency,
https://bugs.gentoo.org/736342 but please do check the cmake variable being correct (is there a typo?) while we wait for this to be fixed.

This CMake variable is only used if we are compiling with thirdparty libraries (we're not) so I've removed it in my latest force-push.

gentoo-repo-qa-bot · 2020-08-16T13:56:20Z

Pull request CI report

Report generated at: 2020-08-16 13:56 UTC
Newest commit scanned: af5fbb0
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/488f81245e/output.html

vilhelmgray · 2020-08-16T13:57:11Z

Upstream benchmark Github issue for reference: google/benchmark#1020

juippis · 2020-09-05T08:00:01Z

Can we fix irrlicht dependency / irrlicht package here to get this moving forward? You probably have a patch for either case?

vilhelmgray · 2020-09-05T13:35:24Z

Here's a PR to resolve the Irrlicht issue: #17426

Regarding the benchmark issues, upstream believes those assembly tests are not valid and suggests disabling them for now with -DBENCHMARK_ENABLE_ASSEMBLY_TESTS=no, so I'll make that change.

Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>

Bug: https://bugs.gentoo.org/733984 Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>

Closes: https://bugs.gentoo.org/733984 Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>

gentoo-repo-qa-bot · 2020-09-05T14:55:49Z

Pull request CI report

Report generated at: 2020-09-05 14:55 UTC
Newest commit scanned: 6a5a1c3
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/ff3134aaf1/output.html

gentoo-bot added new package The PR is adding a new package. assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Jul 26, 2020

vilhelmgray force-pushed the minetest_prometheus branch from b9e7e95 to defc959 Compare July 26, 2020 19:21

juippis reviewed Aug 8, 2020

View reviewed changes

vilhelmgray force-pushed the minetest_prometheus branch from defc959 to ab86d6c Compare August 8, 2020 15:28

juippis reviewed Aug 16, 2020

View reviewed changes

vilhelmgray force-pushed the minetest_prometheus branch from ab86d6c to af5fbb0 Compare August 16, 2020 13:36

vilhelmgray added 3 commits September 5, 2020 09:37

dev-cpp/benchmark: New package

6a7aada

Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>

dev-cpp/prometheus-cpp: New package

ae53901

Bug: https://bugs.gentoo.org/733984 Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>

games-action/minetest: Add prometheus client support

6a5a1c3

Closes: https://bugs.gentoo.org/733984 Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>

vilhelmgray force-pushed the minetest_prometheus branch from af5fbb0 to 6a5a1c3 Compare September 5, 2020 13:37

juippis approved these changes Sep 6, 2020

View reviewed changes

gentoo-bot closed this in 4ab99fc Sep 6, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

games-action/minetest: Add prometheus client support #16840

games-action/minetest: Add prometheus client support #16840

vilhelmgray commented Jul 26, 2020

gentoo-bot commented Jul 26, 2020

gentoo-repo-qa-bot commented Jul 26, 2020

zmedico commented Jul 27, 2020

Pull Request assignment

juippis left a comment

juippis Aug 8, 2020

vilhelmgray Aug 8, 2020

gentoo-repo-qa-bot commented Aug 8, 2020

juippis left a comment

vilhelmgray commented Aug 16, 2020 •

edited

gentoo-repo-qa-bot commented Aug 16, 2020

vilhelmgray commented Aug 16, 2020

juippis commented Sep 5, 2020

vilhelmgray commented Sep 5, 2020

gentoo-repo-qa-bot commented Sep 5, 2020

games-action/minetest: Add prometheus client support #16840

games-action/minetest: Add prometheus client support #16840

Conversation

vilhelmgray commented Jul 26, 2020

gentoo-bot commented Jul 26, 2020

Pull Request assignment

Linked bugs

gentoo-repo-qa-bot commented Jul 26, 2020

Pull request CI report

zmedico commented Jul 27, 2020

Pull Request assignment

juippis left a comment

Choose a reason for hiding this comment

juippis Aug 8, 2020

Choose a reason for hiding this comment

vilhelmgray Aug 8, 2020

Choose a reason for hiding this comment

gentoo-repo-qa-bot commented Aug 8, 2020

Pull request CI report

juippis left a comment

Choose a reason for hiding this comment

vilhelmgray commented Aug 16, 2020 • edited

gentoo-repo-qa-bot commented Aug 16, 2020

Pull request CI report

vilhelmgray commented Aug 16, 2020

juippis commented Sep 5, 2020

vilhelmgray commented Sep 5, 2020

gentoo-repo-qa-bot commented Sep 5, 2020

Pull request CI report

vilhelmgray commented Aug 16, 2020 •

edited