dev-python/flask-paginate: bumped to 0.7.0 #16915
Conversation
Pull Request assignmentSubmitter: @florianjr dev-python/flask-paginate: @gentoo/proxy-maint, @stkw0, @gentoo/python Linked bugsBugs linked: 717526 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
assigned
Pull request CI reportReport generated at: 2020-07-31 08:09 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Signed-off-by: Florian Förster <foerster.florianjr@gmail.com> Closes: https://bugs.gentoo.org/717526 Package-Manager: Portage-3.0.1, Repoman-2.3.23
Pull request CI reportReport generated at: 2020-07-31 12:55 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Signed-off-by: Florian Förster <foerster.florianjr@gmail.com> Package-Manager: Portage-3.0.1, Repoman-2.3.23
Pull request CI reportReport generated at: 2020-07-31 15:39 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Pull request CI reportReport generated at: 2020-07-31 15:54 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
…$PV) Signed-off-by: Florian Förster <foerster.florianjr@gmail.com> Package-Manager: Portage-3.0.1, Repoman-2.3.23
Signed-off-by: Florian Förster <foerster.florianjr@gmail.com> Package-Manager: Portage-3.0.1, Repoman-2.3.23
|
|
||
| DESCRIPTION="Pagination support for flask" | ||
| HOMEPAGE="https://flask-paginate.readthedocs.io" | ||
| SRC_URI="https://github.com/lixxu/flask-paginate/archive/${PV}.tar.gz -> ${P}-${PV}.tar.gz" |
There was a problem hiding this comment.
${P} variable in this case is the same as ${PN}-${PV}. Please leave it as ${P}.tar.gz
There was a problem hiding this comment.
I know and understand this, but could you please explain to me, why i'm then getting: "The source directory ${S} doesn't exist" ?
There was a problem hiding this comment.
Should we define a $S ?
There was a problem hiding this comment.
I'm not getting those errors. Check which source directory is defined and the directory name on PORTAGE_TMPDIR
There was a problem hiding this comment.
Tarball name has nothing to do with S structure. You can inspect the tarball by simply opening/extracting it, and/or browse to PORTAGE_TMPDIR as suggested when emerge fails.
Signed-off-by: Florian Förster <foerster.florianjr@gmail.com> Package-Manager: Portage-3.0.1, Repoman-2.3.23
| BDEPEND=" | ||
| dev-python/setuptools[${PYTHON_USEDEP}] | ||
| test? ( dev-python/pytest[${PYTHON_USEDEP}] ) | ||
| " | ||
|
|
||
| python_test() { | ||
| pytest -vv tests/tests.py || die "tests failed with ${EPYTHON}" | ||
| } |
There was a problem hiding this comment.
You can replace all of these lines with a single distutils_enable_tests pytest
| IUSE="test" | ||
| RESTRICT="!test? ( test )" |
There was a problem hiding this comment.
These will be handled by distutils_enable_tests pytest as well, but put it under RDEPEND.
|
|
||
| DESCRIPTION="Pagination support for flask" | ||
| HOMEPAGE="https://flask-paginate.readthedocs.io" | ||
| SRC_URI="https://github.com/lixxu/flask-paginate/archive/${PV}.tar.gz -> ${P}-${PV}.tar.gz" |
There was a problem hiding this comment.
Tarball name has nothing to do with S structure. You can inspect the tarball by simply opening/extracting it, and/or browse to PORTAGE_TMPDIR as suggested when emerge fails.
|
|
||
| EAPI=7 | ||
|
|
||
| PYTHON_COMPAT=( pypy3 python3_{6,7} ) |
There was a problem hiding this comment.
Can you add 3.8 and 3.9 support here? Seems like they should work.
Signed-off-by: Florian Förster foerster.florianjr@gmail.com
Closes: https://bugs.gentoo.org/717526
Package-Manager: Portage-3.0.1, Repoman-2.3.23
I copied the existing ebuild and changed the $MY_COMMIT variable. @stkw0 i removed you from the maintainers list and added myself, as we said earlier in the previous PR.