Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

media-video/aegisub-9999: Updated ebuild #16973

Closed
wants to merge 2 commits into from

Conversation

jeeger
Copy link
Contributor

@jeeger jeeger commented Aug 3, 2020

Updated the git ebuild. Fixed a removed wxImage constructor, mostly removed builtin lua, corrected failing autoconf check. Also fixed the 'clean' target, but this is unlikely to make any difference for packaging.

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. no signoff One or more commits do not indicate GCO sign-off. labels Aug 3, 2020
# Distributed under the terms of the GNU General Public License v2

EAPI=6

WX_GTK_VER=3.0
PLOCALES="ar bg ca cs da de el es eu fa fi fr_FR gl hu id it ja ko nl pl pt_BR pt_PT ru sr_RS sr_RS@latin uk_UA vi zh_CN zh_TW"
PLOCALES="ar be bg ca cs da de el es eu fa fi fr_FR gl hu id it ja ko nl pl pt_BR pt_PT ru sr_RS sr_RS@latin uk_UA vi zh_CN zh_TW"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added updated locales.

@@ -94,12 +92,14 @@ src_configure() {
$(use_with pulseaudio libpulse)
$(use_with spell hunspell)
$(use_with uchardet)
--disable-compiler-flags
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without this configure option, aegisub uses some outdated compiler option and overwrites CFLAGS, CXXFLAGS and such.

Comment on lines +101 to +102
# Concurrent builds seem to break the build process.
emake -j1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've constrained the build to one job, because I've had some hard to pin down build failures, and I suspect it's due to parallel building. I'd be grateful if someone with better autotools knowledge could debug this further.

@jeeger jeeger changed the title Updated media-video/aegisub-9999 ebuild. media-video/aegisub-9999: Updated ebuild [please reassign] Aug 3, 2020
@gentoo-bot gentoo-bot changed the title media-video/aegisub-9999: Updated ebuild [please reassign] media-video/aegisub-9999: Updated ebuild Aug 3, 2020
@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. and removed assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. no signoff One or more commits do not indicate GCO sign-off. labels Aug 3, 2020
@jeeger jeeger changed the title media-video/aegisub-9999: Updated ebuild media-video/aegisub-9999: Updated ebuild [please reassign] Aug 3, 2020
@gentoo-bot gentoo-bot changed the title media-video/aegisub-9999: Updated ebuild [please reassign] media-video/aegisub-9999: Updated ebuild Aug 3, 2020
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @jeeger
Areas affected: ebuilds
Packages affected: media-video/aegisub

media-video/aegisub: @sarnex

Linked bugs

Bugs linked: 734916


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. and removed assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Aug 3, 2020
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-08-03 13:24 UTC
Newest commit scanned: 1e9a103
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/934f01453e/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-08-03 13:39 UTC
Newest commit scanned: 2c021ee
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/f64fa87b28/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-08-03 15:44 UTC
Newest commit scanned: eaa34d9
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/87b0b293e3/output.html

@sarnex sarnex self-assigned this Aug 4, 2020
Copy link
Member

@sarnex sarnex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the both commit messages to meet Gentoo guidelines

https://www.gentoo.org/glep/glep-0066.html#commit-messages

Closes: https://bugs.gentoo.org/734916
Signed-off-by: Jan Seeger <jan.seeger@thenybble.de>
Signed-off-by: Jan Seeger <jan.seeger@thenybble.de>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-08-05 08:59 UTC
Newest commit scanned: 0672e7a
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/d510df1552/output.html

@jeeger
Copy link
Contributor Author

jeeger commented Aug 5, 2020

Are these commit messages correct?

@sarnex
Copy link
Member

sarnex commented Aug 5, 2020

Yeah looks good now, but the build is failing for me with the below linker errors. Any ideas?

https://gist.github.com/sarnex/55f452d600c2565bb4e55859f873dda9

@jeeger
Copy link
Contributor Author

jeeger commented Aug 5, 2020

It's probably the LTO flags.

@sarnex
Copy link
Member

sarnex commented Aug 5, 2020

They are disabled, notice -fno-lto -fno-use-linker-plugin

@jeeger
Copy link
Contributor Author

jeeger commented Aug 5, 2020

Right, spoke to soon.

Wow, that's a large number of linker errors. I successfully compiled using your CFLAGS, so that shouldn't be the problem. The icon names that appear in the linker output are generated by the respack.lua script and linked via libresrc.a.
The rest seem to be functions in libaegisub.a. I think I had the same problem when using a parallel build, but I've disabled it in the git ebuild.

@gentoo-bot gentoo-bot closed this in 0da84a7 Aug 5, 2020
@sarnex
Copy link
Member

sarnex commented Aug 5, 2020

Thanks, if it compiles for you, that's a lot better than it is right now, so I pulled this

@jeeger jeeger deleted the media-video/aegisub-9999 branch August 5, 2020 16:56
@jeeger jeeger restored the media-video/aegisub-9999 branch August 5, 2020 16:56
@jeeger jeeger deleted the media-video/aegisub-9999 branch August 7, 2020 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
4 participants