New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
media-video/aegisub-9999: Updated ebuild #16973
Conversation
# Distributed under the terms of the GNU General Public License v2 | ||
|
||
EAPI=6 | ||
|
||
WX_GTK_VER=3.0 | ||
PLOCALES="ar bg ca cs da de el es eu fa fi fr_FR gl hu id it ja ko nl pl pt_BR pt_PT ru sr_RS sr_RS@latin uk_UA vi zh_CN zh_TW" | ||
PLOCALES="ar be bg ca cs da de el es eu fa fi fr_FR gl hu id it ja ko nl pl pt_BR pt_PT ru sr_RS sr_RS@latin uk_UA vi zh_CN zh_TW" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added updated locales.
@@ -94,12 +92,14 @@ src_configure() { | |||
$(use_with pulseaudio libpulse) | |||
$(use_with spell hunspell) | |||
$(use_with uchardet) | |||
--disable-compiler-flags |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without this configure option, aegisub uses some outdated compiler option and overwrites CFLAGS, CXXFLAGS and such.
# Concurrent builds seem to break the build process. | ||
emake -j1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've constrained the build to one job, because I've had some hard to pin down build failures, and I suspect it's due to parallel building. I'd be grateful if someone with better autotools knowledge could debug this further.
1e9a103
to
9c0d2fb
Compare
9c0d2fb
to
2c021ee
Compare
Pull Request assignmentSubmitter: @jeeger media-video/aegisub: @sarnex Linked bugsBugs linked: 734916 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
Pull request CI reportReport generated at: 2020-08-03 13:24 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Pull request CI reportReport generated at: 2020-08-03 13:39 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Pull request CI reportReport generated at: 2020-08-03 15:44 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the both commit messages to meet Gentoo guidelines
Closes: https://bugs.gentoo.org/734916 Signed-off-by: Jan Seeger <jan.seeger@thenybble.de>
Signed-off-by: Jan Seeger <jan.seeger@thenybble.de>
eaa34d9
to
0672e7a
Compare
Pull request CI reportReport generated at: 2020-08-05 08:59 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Are these commit messages correct? |
Yeah looks good now, but the build is failing for me with the below linker errors. Any ideas? https://gist.github.com/sarnex/55f452d600c2565bb4e55859f873dda9 |
It's probably the LTO flags. |
They are disabled, notice -fno-lto -fno-use-linker-plugin |
Right, spoke to soon. Wow, that's a large number of linker errors. I successfully compiled using your |
Thanks, if it compiles for you, that's a lot better than it is right now, so I pulled this |
Updated the git ebuild. Fixed a removed wxImage constructor, mostly removed builtin lua, corrected failing autoconf check. Also fixed the 'clean' target, but this is unlikely to make any difference for packaging.