Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lxde-base/lxappearance: Add ~ppc64 keyword #17186

Closed
wants to merge 1 commit into from
Closed

lxde-base/lxappearance: Add ~ppc64 keyword #17186

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Aug 20, 2020

No description provided.

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @Djames1
Areas affected: ebuilds
Packages affected: lxde-base/lxappearance

lxde-base/lxappearance: @gentoo/proxy-maint (maintainer needed)

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

Missing GCO sign-off

Please read the terms of Gentoo Certificate of Origin and acknowledge them by adding a sign-off to all your commits.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added maintainer-needed There is at least one affected package with no maintainer. Review it if you can. assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. no signoff One or more commits do not indicate GCO sign-off. labels Aug 20, 2020
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-08-20 16:16 UTC
Newest commit scanned: 13c8d7b
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/9fc4e88875/output.html

@juippis
Copy link
Member

juippis commented Aug 21, 2020

Hey, we can't do that here. KEYWORDS are requested through bugzilla, check examples here:
https://bugs.gentoo.org/buglist.cgi?component=Keywording&list_id=4762706&product=Gentoo%20Linux&resolution=---

Also whenever contributing something to our portage tree, we need a proper sign-off line to the commit. Check the linked note about it above.

If you need help getting started with keywording in bugzilla, don't hesitate to ask.

@ghost
Copy link
Author

ghost commented Aug 25, 2020

@gyakovlev on #gentoo-powerpc IRC you told me you can merge pull requests to add KEYWORDS. Is this not correct?

@juippis
Copy link
Member

juippis commented Aug 25, 2020

@gyakovlev is indeed part of the ppc arch team. If you have come to a mutual agreement, please state it in the PR's opening message, since this is an unconvential way of adding KEYWORDS. You probably weren't aware, just like I wasn't aware of your deal with @gyakovlev ;)

Please highlight me and @gyakovlev in the 2nd PR you had so it can reopened it again.

@juippis juippis reopened this Aug 25, 2020
@juippis
Copy link
Member

juippis commented Aug 25, 2020

Note that you still need to amend your commit and add a proper sign-off, but it can be done now that this PR is reopened.

@gyakovlev
Copy link
Member

Yes, I offered to merge keywording PRs (with ppc64 hat on), so I'll handle it later today in bulk.

@gyakovlev
Copy link
Member

this PR was not signed-off, so I just keyworded it myself, as I actually use this app.

NeddySeagoon pushed a commit to NeddySeagoon/gentoo-arm64 that referenced this pull request Aug 30, 2020
Closes: gentoo#17186
Package-Manager: Portage-3.0.4, Repoman-3.0.1
Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). maintainer-needed There is at least one affected package with no maintainer. Review it if you can. no bug found No Bug/Closes found in the commits. no signoff One or more commits do not indicate GCO sign-off.
Projects
None yet
4 participants