Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net-vpn/i2pd-2.33.0: version bump #17314

Closed
wants to merge 3 commits into from
Closed

Conversation

khumarahn
Copy link
Contributor

... with no changes to i2pd-2.32.1

@juippis hi again! you have been good in merging my previous PRs.

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @khumarahn
Areas affected: ebuilds
Packages affected: net-vpn/i2pd

net-vpn/i2pd: @khumarahn, @gentoo/proxy-maint, @klondi

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). labels Aug 29, 2020
Signed-off-by: Alexey Korepanov <kaikaikai@yandex.ru>
Signed-off-by: Alexey Korepanov <kaikaikai@yandex.ru>
@khumarahn
Copy link
Contributor Author

removed websockets use flag from metadata, force pushed

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-08-29 13:55 UTC
Newest commit scanned: f1e5cf8
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/f97572d842/output.html

dev-libs/libressl:0=
>=dev-libs/boost-1.65:=
)
libressl? ( dev-libs/libressl:0= )
upnp? ( net-libs/miniupnpc )
)"
DEPEND="${RDEPEND}
static? (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does anyone actually want static for this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's hard to tell. My feeling is that most people who use i2p don't want to be using it publicly. Maybe it can be useful for embedded devices?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was kind of my thinking too. Although they could build it themselves. We'll keep it in for now.

dev-libs/libressl:0=
>=dev-libs/boost-1.65:=
)
libressl? ( dev-libs/libressl:0= )
upnp? ( net-libs/miniupnpc )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:= for libraries we link against which have a subslot

upnp? ( net-libs/miniupnpc )
)"
DEPEND="${RDEPEND}
static? (
dev-libs/boost:=[static-libs,threads]
sys-libs/zlib[static-libs]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:= for libraries we link against which have a subslot

>=dev-libs/boost-1.65:=
)
sys-libs/zlib:=[static-libs]
libressl? ( dev-libs/libressl:0=[static-libs] )
upnp? ( net-libs/miniupnpc[static-libs] )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:= for libraries we link against which have a subslot

Signed-off-by: Alexey Korepanov <kaikaikai@yandex.ru>
@khumarahn
Copy link
Contributor Author

@thesamesam thanks! I added := for miniupnpc. For zlib, := was removed recently at the request of @juippis #15995 (comment)

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-08-31 06:15 UTC
Newest commit scanned: 1c63ddd
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/2acb41dd44/output.html

@thesamesam
Copy link
Member

Zlib is an annoying case because of that -- no problem, thanks!

@gentoo-bot gentoo-bot closed this in 83505e9 Sep 4, 2020
@khumarahn
Copy link
Contributor Author

Very nice, thanks!

@thesamesam
Copy link
Member

Thank you for the contribution(s)!

@khumarahn khumarahn deleted the i2pd-2.33.0 branch December 28, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
4 participants