-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Coffee Script 2.5.1 #17346
Add Coffee Script 2.5.1 #17346
Conversation
Signed-off-by: Bobbbay Bobbayan (abatterysingle@gmail.com)
Pull Request assignmentSubmitter: @bobbbay dev-lang/coffee-script: @gentoo/proxy-maint (maintainer needed) Linked bugsNo bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment. Missing GCO sign-offPlease read the terms of Gentoo Certificate of Origin and acknowledge them by adding a sign-off to all your commits. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
After tons of debugging, I've found out that all four rebuild files have syntax errors. I'd be thrilled to fix all of these, but can't seem to find the reason. Went over to ebuild.sh and where the error was thrown from, seems like it has something to do with If anyone has thoughts, I'd love to hear them :)) |
Give me a shout if you have any more questions! |
As well as some other touchups Signed-off-by: Bobbbay Bobbayan <abatterysingle@gmail.com> Package-Manager: Portage-3.0.4, Repoman-2.3.23
Hey Sam,
How's this now? |
Pull request CI reportReport generated at: 2020-09-16 00:47 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Oh wow awesome! In that case I'm going to test the install on a custom overlay of some sort and see if we're 100% clean! |
Oh wow, it worked like a freaking charm! Never thought ebuilds would be this fun 🤪 (especially once you're done)
Returns CoffeeScript version 2.5.1 Woohoo! @thesamesam I'm clearing this for review! |
As well as some other touchups Signed-off-by: Bobbbay Bobbayan <abatterysingle@gmail.com> Package-Manager: Portage-3.0.4, Repoman-2.3.23 Closes: gentoo#17346 Signed-off-by: Joonas Niilola <juippis@gentoo.org>
Hello all,
This is my first time contributing to Gentoo, so please don't roar at me if I say something wrong 😄.
So I saw that there was no Coffee Script 2.5.1 in the repo, so I decided to add it. I decided to simply
cp
the old one (2.3.2
) and, if errors should arise, adjust as needed. The problem is the following: I'm not sure how I can "test" this out. I'm completely willing to run this on my personal Gentoo installation, I'm just not sure how I set the system to point tobobbbay/gentoo
instead ofgentoo/gentoo
. Thank you!Also, I'm aware I need to update the manifest, or do I wait until this is approved? Cheers!
EDIT: Also added long description, straight from coffeescript.org.