Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Coffee Script 2.5.1 #17346

Closed
wants to merge 4 commits into from
Closed

Add Coffee Script 2.5.1 #17346

wants to merge 4 commits into from

Conversation

bobbbay
Copy link
Contributor

@bobbbay bobbbay commented Aug 31, 2020

Hello all,

This is my first time contributing to Gentoo, so please don't roar at me if I say something wrong 😄.

So I saw that there was no Coffee Script 2.5.1 in the repo, so I decided to add it. I decided to simply cp the old one (2.3.2) and, if errors should arise, adjust as needed. The problem is the following: I'm not sure how I can "test" this out. I'm completely willing to run this on my personal Gentoo installation, I'm just not sure how I set the system to point to bobbbay/gentoo instead of gentoo/gentoo. Thank you!

Also, I'm aware I need to update the manifest, or do I wait until this is approved? Cheers!

EDIT: Also added long description, straight from coffeescript.org.

@gentoo-bot gentoo-bot added maintainer-needed There is at least one affected package with no maintainer. Review it if you can. assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. no signoff One or more commits do not indicate GCO sign-off. labels Aug 31, 2020
@bobbbay bobbbay changed the title Add Coffee Script 2.5.1 Add Coffee Script 2.5.1 [please reassign] Aug 31, 2020
@gentoo-bot gentoo-bot changed the title Add Coffee Script 2.5.1 [please reassign] Add Coffee Script 2.5.1 Aug 31, 2020
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @bobbbay
Areas affected: ebuilds
Packages affected: dev-lang/coffee-script

dev-lang/coffee-script: @gentoo/proxy-maint (maintainer needed)

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

Missing GCO sign-off

Please read the terms of Gentoo Certificate of Origin and acknowledge them by adding a sign-off to all your commits.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added maintainer-needed There is at least one affected package with no maintainer. Review it if you can. assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. no signoff One or more commits do not indicate GCO sign-off. and removed assigned PR successfully assigned to the package maintainer(s). maintainer-needed There is at least one affected package with no maintainer. Review it if you can. no bug found No Bug/Closes found in the commits. no signoff One or more commits do not indicate GCO sign-off. labels Aug 31, 2020
@bobbbay
Copy link
Contributor Author

bobbbay commented Aug 31, 2020

After tons of debugging, I've found out that all four rebuild files have syntax errors. I'd be thrilled to fix all of these, but can't seem to find the reason. Went over to ebuild.sh and where the error was thrown from, seems like it has something to do with *DEPEND or IUSE.

If anyone has thoughts, I'd love to hear them :))

@thesamesam
Copy link
Member

thesamesam commented Sep 15, 2020

  1. For testing, have a look at this guide (then click through to here).

  2. We should rebase the commits you made then force push to squash the commits together into just 1 for these changes. Let me know if you want some guidance on doing that.

  3. Commit messages need to adhere to GLEP 66, which includes the sign off which is missing too (see what the bot said ;)).

  4. Just skimming this - not tested yet - I can't see anything glaringly wrong here. What error are you getting?

  5. You can run your own version of the CI check with 'repoman full -dx' and 'pkgcheck scan'. This can be quite helpful for speeding up development!

Give me a shout if you have any more questions!

@thesamesam thesamesam self-assigned this Sep 15, 2020
As well as some other touchups

Signed-off-by: Bobbbay Bobbayan <abatterysingle@gmail.com>
Package-Manager: Portage-3.0.4, Repoman-2.3.23
@bobbbay
Copy link
Contributor Author

bobbbay commented Sep 15, 2020

Hey Sam,

  1. Will definitely take the read!
  2. I know what these are, but have no clue what commands I need to run for them, help needed for sure!
  3. I tried doing this in my last commit, is it wrong?
  4. In the end I found out it was because I was running repoman as root, silly me ;)
  5. That's a very handy dandy command, thanks!

How's this now?

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-09-16 00:47 UTC
Newest commit scanned: 89cf1cd
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/915ac9e030/output.html

@bobbbay
Copy link
Contributor Author

bobbbay commented Sep 16, 2020

Oh wow awesome! In that case I'm going to test the install on a custom overlay of some sort and see if we're 100% clean!

@bobbbay
Copy link
Contributor Author

bobbbay commented Sep 16, 2020

Oh wow, it worked like a freaking charm! Never thought ebuilds would be this fun 🤪 (especially once you're done)

coffee -v

Returns CoffeeScript version 2.5.1

Woohoo! @thesamesam

I'm clearing this for review!

@bobbbay bobbbay marked this pull request as ready for review September 16, 2020 16:28
@gentoo-bot gentoo-bot closed this in 11667a0 Oct 2, 2020
NeddySeagoon pushed a commit to NeddySeagoon/gentoo-arm64 that referenced this pull request Oct 6, 2020
As well as some other touchups

Signed-off-by: Bobbbay Bobbayan <abatterysingle@gmail.com>
Package-Manager: Portage-3.0.4, Repoman-2.3.23
Closes: gentoo#17346
Signed-off-by: Joonas Niilola <juippis@gentoo.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). maintainer-needed There is at least one affected package with no maintainer. Review it if you can. no bug found No Bug/Closes found in the commits. no signoff One or more commits do not indicate GCO sign-off.
Projects
None yet
5 participants