lxde-base/lxterminal: port to EAPI 7 #17359
Conversation
Pull Request assignmentSubmitter: @jsmolic lxde-base/lxterminal: @gentoo/proxy-maint (maintainer needed) Linked bugsBugs linked: 739838 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
maintainer-needed
Pull request CI reportReport generated at: 2020-09-01 11:46 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
| # Distributed under the terms of the GNU General Public License v2 | ||
|
|
||
| EAPI=6 | ||
| EAPI=7 |
There was a problem hiding this comment.
EAPI bump requires a revbump. And I'm looking at the ebuild and it's awful, so you'd need to fix a few things before it's accepted.
So just inherit xdg and nothing else, or fix the ebuild with a revbump.
There was a problem hiding this comment.
Ok, I would like to fix it properly then.
Can you tell me what else needs to be changed?
There was a problem hiding this comment.
There's no implication that it's installing translation files, I'd put building them behind nls USE flag and well build everything instead of having the PLOCALES array with it. Those files take a second to build and we're already recommending to use INSTALL_MASK for unwanted localization files. This'd allow removing l10n.eclass altogether.
Then it has a case for a -9999 ebuild but no such ebuild exists.
It also has double KEYWORDS line, which breaks some tools.
Also do multi-line the gtk3 USE conditionals for clarity.
There was a problem hiding this comment.
Thanks, I cleaned it up. I didn't find the option to disable building locales with configure options, but I think it's okay to install them unconditionally.
- Adjust DEPEND -> BDEPEND
- Update icon cache
- Remove ${PV} == *9999* logic
- Install locales unconditionally
Closes: https://bugs.gentoo.org/739838
Package-Manager: Portage-3.0.4, Repoman-3.0.1
Signed-off-by: Jakov Smolic <jakov.smolic@sartura.hr>
Pull request CI reportReport generated at: 2020-09-17 07:12 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Closes: https://bugs.gentoo.org/739838
Package-Manager: Portage-3.0.4, Repoman-3.0.1
Signed-off-by: Jakov Smolic jakov.smolic@sartura.hr