Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app-i18n/transifex-client: add version 0.13.12 #17410

Closed
wants to merge 1 commit into from

Conversation

robert7k
Copy link
Contributor

@robert7k robert7k commented Sep 4, 2020

$ diff -u transifex-client-0.13.9.ebuild transifex-client-0.13.12.ebuild 
--- transifex-client-0.13.9.ebuild      2020-05-13 22:42:46.529883365 +0200
+++ transifex-client-0.13.12.ebuild     2020-10-01 19:32:46.961720869 +0200
@@ -14,14 +14,21 @@
 
 LICENSE="GPL-2"
 SLOT="0"
-KEYWORDS="amd64 x86"
+KEYWORDS="~amd64 ~x86"
 IUSE="test"
 RESTRICT="!test? ( test )"
 
 BDEPEND="test? ( dev-python/mock[${PYTHON_USEDEP}] )"
-RDEPEND="<dev-python/python-slugify-2.0.0[${PYTHON_USEDEP}]
-       >=dev-python/requests-2.19.1[${PYTHON_USEDEP}]
+RDEPEND="dev-python/GitPython[${PYTHON_USEDEP}]
+       <dev-python/python-slugify-5.0.0[${PYTHON_USEDEP}]
+       dev-python/requests[${PYTHON_USEDEP}]
        <dev-python/six-2.0.0[${PYTHON_USEDEP}]
-       >=dev-python/urllib3-1.24.2[${PYTHON_USEDEP}]"
+       dev-python/urllib3[${PYTHON_USEDEP}]"
 
 distutils_enable_tests setup.py
+
+src_prepare() {
+       eapply_user
+       sed -i -e 's:test_fetch_timestamp_from_git_tree:_&:' \
+               tests/test_utils.py || die
+}

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @robert7k
Areas affected: ebuilds
Packages affected: app-i18n/transifex-client

app-i18n/transifex-client: @robert7k, @gentoo/proxy-maint

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). labels Sep 4, 2020
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-09-04 12:06 UTC
Newest commit scanned: 639a926
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/623232fdd2/output.html


BDEPEND="test? ( dev-python/mock[${PYTHON_USEDEP}] )"
RDEPEND="dev-python/GitPython[${PYTHON_USEDEP}]
<dev-python/python-slugify-5.0.0[${PYTHON_USEDEP}]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you absolutely sure about these < deps? They make cleaning older versions pain.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<dev-python/six-2.0.0[${PYTHON_USEDEP}]
dev-python/urllib3[${PYTHON_USEDEP}]"

distutils_enable_tests setup.py
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran 103 tests in 0.215s

FAILED (failures=1)
Test failed: <unittest.runner.TextTestResult run=103 errors=0 failures=1>
error: Test failed: <unittest.runner.TextTestResult run=103 errors=0 failures=1>
 * ERROR: app-i18n/transifex-client-0.13.11::testworld failed (test phase):
 *   Tests fail with python3.6

Looks good but could you check whether this works for you? You can disable it this way:
https://dev.gentoo.org/~mgorny/python-guide/test.html#skipping-problematic-tests

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the hint. I excluded the failing test.

@robert7k
Copy link
Contributor Author

robert7k commented Oct 1, 2020

Updated this PR to add version 0.13.12 instead of 0.13.11.

@robert7k robert7k changed the title app-i18n/transifex-client: add version 0.13.11 app-i18n/transifex-client: add version 0.13.12 Oct 1, 2020
Signed-off-by: Robert Siebeck <gentoo.2019@r123.de>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-10-01 18:42 UTC
Newest commit scanned: 9a59e66
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/e2c7650250/output.html

@gentoo-bot gentoo-bot closed this in e9836f3 Oct 2, 2020
NeddySeagoon pushed a commit to NeddySeagoon/gentoo-arm64 that referenced this pull request Oct 6, 2020
Signed-off-by: Robert Siebeck <gentoo.2019@r123.de>
Closes: gentoo#17410
Signed-off-by: Joonas Niilola <juippis@gentoo.org>
@robert7k robert7k deleted the transifex branch October 11, 2020 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
4 participants