-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
app-i18n/transifex-client: add version 0.13.12 #17410
Conversation
robert7k
commented
Sep 4, 2020
•
edited
edited
Pull Request assignmentSubmitter: @robert7k app-i18n/transifex-client: @robert7k, @gentoo/proxy-maint Linked bugsNo bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
Pull request CI reportReport generated at: 2020-09-04 12:06 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
|
||
BDEPEND="test? ( dev-python/mock[${PYTHON_USEDEP}] )" | ||
RDEPEND="dev-python/GitPython[${PYTHON_USEDEP}] | ||
<dev-python/python-slugify-5.0.0[${PYTHON_USEDEP}] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you absolutely sure about these <
deps? They make cleaning older versions pain.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are explicitly mentioned by upstream, see https://github.com/transifex/transifex-client/blob/master/requirements.txt
<dev-python/six-2.0.0[${PYTHON_USEDEP}] | ||
dev-python/urllib3[${PYTHON_USEDEP}]" | ||
|
||
distutils_enable_tests setup.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran 103 tests in 0.215s
FAILED (failures=1)
Test failed: <unittest.runner.TextTestResult run=103 errors=0 failures=1>
error: Test failed: <unittest.runner.TextTestResult run=103 errors=0 failures=1>
* ERROR: app-i18n/transifex-client-0.13.11::testworld failed (test phase):
* Tests fail with python3.6
Looks good but could you check whether this works for you? You can disable it this way:
https://dev.gentoo.org/~mgorny/python-guide/test.html#skipping-problematic-tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the hint. I excluded the failing test.
Updated this PR to add version 0.13.12 instead of 0.13.11. |
Signed-off-by: Robert Siebeck <gentoo.2019@r123.de>
Pull request CI reportReport generated at: 2020-10-01 18:42 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Signed-off-by: Robert Siebeck <gentoo.2019@r123.de> Closes: gentoo#17410 Signed-off-by: Joonas Niilola <juippis@gentoo.org>