-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gnome-extra/nemo: requires xapp 1.8 #17597
Conversation
Requires xapp 1.8 version. This commit fixes bug 743427. Bug: https://bugs.gentoo.org/743427 Package-Manager: Portage-3.0.4, Repoman-3.0.1 Signed-off-by: Samuel Bernardo <samuelbernardo.mail@gmail.com>
Pull Request assignmentSubmitter: @samuelbernardo gnome-extra/nemo: @SparkyBluefang, @gentoo/proxy-maint Linked bugsBugs linked: 743427 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
Pull request CI reportReport generated at: 2020-09-19 09:17 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
LGTM. I've been bumping xapp along with the other cinnamon packages, which is why I didn't notice this dependency mismatch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the xapp dependency only change you're making in this ebuild? Since it fixes a compile-problem therefore revbumping is not needed. You can edit the old ebuild in place.
Didn't test with the old ebuild, only with the new version. |
I'm talking about this:
Because it's a build failure for some, we shouldn't revbump and force everyone to update. Just edit nemo-4.6.5.ebuild changing the dependency requirement. |
… everyone to update. Just edit nemo-4.6.5.ebuild changing the dependency requirement. Signed-off-by: Samuel Bernardo <samuelbernardo.mail@gmail.com>
Done. Removed patch version updating current version dependency. |
Pull request CI reportReport generated at: 2020-10-11 22:17 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
I think this PR can be closed, seems like the fix has been applied with: 842b34e |
Yes it seems is already applied as juippis instructed and the related bug is already marked as fixed in bugzilla. |
Requires xapp 1.8 version.
This commit fixes bug 743427.
Bug: https://bugs.gentoo.org/743427
Package-Manager: Portage-3.0.4, Repoman-3.0.1
Signed-off-by: Samuel Bernardo samuelbernardo.mail@gmail.com