Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnome-extra/nemo: requires xapp 1.8 #17597

Closed
wants to merge 2 commits into from

Conversation

samuelbernardo
Copy link
Contributor

Requires xapp 1.8 version.
This commit fixes bug 743427.

Bug: https://bugs.gentoo.org/743427
Package-Manager: Portage-3.0.4, Repoman-3.0.1
Signed-off-by: Samuel Bernardo samuelbernardo.mail@gmail.com

Requires xapp 1.8 version.
This commit fixes bug 743427.

Bug: https://bugs.gentoo.org/743427
Package-Manager: Portage-3.0.4, Repoman-3.0.1
Signed-off-by: Samuel Bernardo <samuelbernardo.mail@gmail.com>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @samuelbernardo
Areas affected: ebuilds
Packages affected: gnome-extra/nemo

gnome-extra/nemo: @SparkyBluefang, @gentoo/proxy-maint

Linked bugs

Bugs linked: 743427


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Sep 19, 2020
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-09-19 09:17 UTC
Newest commit scanned: d7367c6
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/5e92e87ebe/output.html

@SparkyBluefang
Copy link
Contributor

LGTM. I've been bumping xapp along with the other cinnamon packages, which is why I didn't notice this dependency mismatch.

Copy link
Member

@juippis juippis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the xapp dependency only change you're making in this ebuild? Since it fixes a compile-problem therefore revbumping is not needed. You can edit the old ebuild in place.

@samuelbernardo
Copy link
Contributor Author

Is the xapp dependency only change you're making in this ebuild? Since it fixes a compile-problem therefore revbumping is not needed. You can edit the old ebuild in place.

Didn't test with the old ebuild, only with the new version.

@juippis
Copy link
Member

juippis commented Oct 7, 2020

I'm talking about this:

>: diff nemo-4.6.5.ebuild nemo-4.6.5-r1.ebuild 
32c32
< 	>=x11-libs/xapps-1.4.0
---
> 	>=x11-libs/xapps-1.8.0

Because it's a build failure for some, we shouldn't revbump and force everyone to update. Just edit nemo-4.6.5.ebuild changing the dependency requirement.

… everyone to update. Just edit nemo-4.6.5.ebuild changing the dependency requirement.

Signed-off-by: Samuel Bernardo <samuelbernardo.mail@gmail.com>
@samuelbernardo
Copy link
Contributor Author

samuelbernardo commented Oct 11, 2020

Because it's a build failure for some, we shouldn't revbump and force everyone to update. Just edit nemo-4.6.5.ebuild changing the dependency requirement

Done. Removed patch version updating current version dependency.
Sorry for the delay, but only now I could look into this.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-10-11 22:17 UTC
Newest commit scanned: 22520c4
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/71fc476cc5/output.html

@wimmuskee
Copy link
Contributor

I think this PR can be closed, seems like the fix has been applied with: 842b34e

@samuelbernardo
Copy link
Contributor Author

I think this PR can be closed, seems like the fix has been applied with: 842b34e

Yes it seems is already applied as juippis instructed and the related bug is already marked as fixed in bugzilla.
So I will close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
6 participants