dev-python/plotly: version bump to 4.10.0 #17643

epsilon-0 · 2020-09-23T01:33:24Z

Closes: https://bugs.gentoo.org/641650

Also adds new package maintainer

Package-Manager: Portage-3.0.7, Repoman-3.0.1
Signed-off-by: Aisha Tammy gentoo@aisha.cc

gentoo-bot · 2020-09-23T01:36:10Z

Pull Request assignment

Submitter: @epsilon-0
Areas affected: ebuilds
Packages affected: dev-python/plotly

dev-python/plotly: @gentoo/sci

Linked bugs

Bugs linked: 641650

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

gentoo-repo-qa-bot · 2020-09-23T01:46:43Z

Pull request CI report

Report generated at: 2020-09-23 01:46 UTC
Newest commit scanned: b73aad0
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/7d80a40bd3/output.html

thesamesam · 2020-09-23T03:03:31Z

dev-python/plotly/plotly-4.10.0.ebuild

+
+EAPI=7
+
+# blocker dev-python/retrying


Got a bug for it? ;)

retrying is python3_{6,7} only hence I can't add 8,9 as of now.

thesamesam · 2020-09-23T03:03:58Z

dev-python/plotly/plotly-4.10.0.ebuild

+	dev-python/retrying[${PYTHON_USEDEP}]
+	dev-python/six[${PYTHON_USEDEP}]
+"
+DEPEND="${RDEPEND}"


What for? Usually we don't need to bother with this, just at runtime, but maybe they are needed?

Unsure how to do this without a lot of pain.
Don't see a harm in letting it stay.

thesamesam · 2020-09-23T03:04:26Z

dev-python/plotly/plotly-4.10.0.ebuild

+# blocker dev-python/retrying
+PYTHON_COMPAT=( python3_{6..7} )
+
+inherit distutils-r1 virtualx


What's virtual here for - tests? Do we need distutils_enable_tests or similar?

Ah, a remnant from previous, will remove.

gentoo-repo-qa-bot · 2020-09-23T03:41:52Z

Pull request CI report

Report generated at: 2020-09-23 03:41 UTC
Newest commit scanned: 1cf3895
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/d0dfe1ff09/output.html

gentoo-repo-qa-bot · 2020-09-24T13:31:58Z

Pull request CI report

Report generated at: 2020-09-24 13:31 UTC
Newest commit scanned: 7c7f1d5
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/f0882efe6d/output.html

epsilon-0 · 2020-09-24T14:00:11Z

There are no tests distributed with the package.

gentoo-repo-qa-bot · 2020-09-24T14:41:51Z

Pull request CI report

Report generated at: 2020-09-24 14:41 UTC
Newest commit scanned: 709bc53
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/bfb150a030/output.html

epsilon-0 · 2020-09-24T16:16:33Z

CI is running on an older version of the tree, which hasn't yet update the retrying to 3_{8,9}.
It should be safe to ignore.

gentoo-repo-qa-bot · 2020-09-29T21:46:42Z

Pull request CI report

Report generated at: 2020-09-29 21:46 UTC
Newest commit scanned: 788fbbe
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/5591fd4382/output.html

SoapGentoo · 2020-10-31T17:44:22Z

dev-python/chart-studio/chart-studio-1.1.0.ebuild

+LICENSE="MIT"
+SLOT="0"
+
+RDEPEND="${PYTHON_DEPS}


${PYTHON_DEPS} redundant, distutils-r1 injects it implicitly

SoapGentoo · 2020-10-31T17:45:09Z

dev-python/chart-studio/chart-studio-1.1.0.ebuild

+KEYWORDS="~amd64 ~x86"
+
+LICENSE="MIT"
+SLOT="0"


always use the following block format:

DESCRIPTION="Browser-based graphing library for Python" HOMEPAGE="https://plot.ly/python/" SRC_URI="mirror://pypi/${PN:0:1}/${PN}/${P}.tar.gz" LICENSE="MIT" SLOT="0" KEYWORDS="~amd64 ~x86"

i.e. there's a free line between SRC_URI and LICENSE

SoapGentoo · 2020-10-31T17:45:26Z

dev-python/plotly-geo/plotly-geo-1.0.0.ebuild

+DESCRIPTION="Browser-based graphing library for Python"
+HOMEPAGE="https://plot.ly/python/"
+SRC_URI="mirror://pypi/${PN:0:1}/${PN}/${P}.tar.gz"
+KEYWORDS="~amd64 ~x86"


SoapGentoo · 2020-10-31T17:45:56Z

dev-python/plotly/plotly-4.10.0.ebuild

+	dev-python/six[${PYTHON_USEDEP}]
+"
+
+python_install_all() {


any tests here? all things equal, tests are more important in python packages than C/C++ packages

for sake of others who might read.
these packages don't contain tests, they are made from a single source tarball which contains 6 different packages (broken up later for pypi releases), so we can't use github releases as well.

SoapGentoo · 2020-10-31T17:46:06Z

dev-python/plotly/plotly-4.10.0.ebuild

+python_install_all() {
+	distutils-r1_python_install_all
+
+	mkdir -p "${ED}"/etc/


missing || die

Closes: https://bugs.gentoo.org/641650 Package-Manager: Portage-3.0.7, Repoman-3.0.1 Signed-off-by: Aisha Tammy <gentoo@aisha.cc>

made into a separate package for >=4.x.x Package-Manager: Portage-3.0.8, Repoman-3.0.1 Signed-off-by: Aisha Tammy <gentoo@aisha.cc>

Package-Manager: Portage-3.0.8, Repoman-3.0.1 Signed-off-by: Aisha Tammy <gentoo@aisha.cc>

gentoo-repo-qa-bot · 2020-10-31T18:27:09Z

Pull request CI report

Report generated at: 2020-10-31 18:27 UTC
Newest commit scanned: a5dc877
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/2840bf70cd/output.html

gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Sep 23, 2020

thesamesam reviewed Sep 23, 2020

View reviewed changes

epsilon-0 force-pushed the plotly branch from b73aad0 to 1cf3895 Compare September 23, 2020 03:26

epsilon-0 force-pushed the plotly branch from 7c7f1d5 to c942997 Compare September 24, 2020 13:56

epsilon-0 force-pushed the plotly branch from c942997 to 709bc53 Compare September 24, 2020 14:15

epsilon-0 force-pushed the plotly branch from 709bc53 to 8ae3b3c Compare September 24, 2020 15:47

epsilon-0 force-pushed the plotly branch from 8ae3b3c to 788fbbe Compare September 29, 2020 21:33

SoapGentoo suggested changes Oct 31, 2020

View reviewed changes

epsilon-0 added 3 commits October 31, 2020 17:55

dev-python/plotly: version bump to 4.10.0

953ad9d

Closes: https://bugs.gentoo.org/641650 Package-Manager: Portage-3.0.7, Repoman-3.0.1 Signed-off-by: Aisha Tammy <gentoo@aisha.cc>

dev-python/chart-studio: chart utilities for plotly

805aee3

made into a separate package for >=4.x.x Package-Manager: Portage-3.0.8, Repoman-3.0.1 Signed-off-by: Aisha Tammy <gentoo@aisha.cc>

dev-python/plotly-geo: geo files for plotly

a5dc877

Package-Manager: Portage-3.0.8, Repoman-3.0.1 Signed-off-by: Aisha Tammy <gentoo@aisha.cc>

epsilon-0 force-pushed the plotly branch from 788fbbe to a5dc877 Compare October 31, 2020 17:56

gentoo-bot closed this in e6c6f26 Nov 9, 2020

epsilon-0 deleted the plotly branch November 13, 2020 21:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

dev-python/plotly: version bump to 4.10.0 #17643

dev-python/plotly: version bump to 4.10.0 #17643

epsilon-0 commented Sep 23, 2020

gentoo-bot commented Sep 23, 2020

gentoo-repo-qa-bot commented Sep 23, 2020

thesamesam Sep 23, 2020

epsilon-0 Sep 23, 2020

thesamesam Sep 23, 2020

epsilon-0 Sep 23, 2020

epsilon-0 Sep 24, 2020

thesamesam Sep 23, 2020

epsilon-0 Sep 23, 2020

gentoo-repo-qa-bot commented Sep 23, 2020

gentoo-repo-qa-bot commented Sep 24, 2020

epsilon-0 commented Sep 24, 2020

gentoo-repo-qa-bot commented Sep 24, 2020

epsilon-0 commented Sep 24, 2020

gentoo-repo-qa-bot commented Sep 29, 2020

SoapGentoo Oct 31, 2020

epsilon-0 Oct 31, 2020

SoapGentoo Oct 31, 2020

epsilon-0 Oct 31, 2020

SoapGentoo Oct 31, 2020

epsilon-0 Oct 31, 2020

SoapGentoo Oct 31, 2020

epsilon-0 Oct 31, 2020

SoapGentoo Oct 31, 2020

epsilon-0 Oct 31, 2020

gentoo-repo-qa-bot commented Oct 31, 2020

dev-python/plotly: version bump to 4.10.0 #17643

dev-python/plotly: version bump to 4.10.0 #17643

Conversation

epsilon-0 commented Sep 23, 2020

gentoo-bot commented Sep 23, 2020

Pull Request assignment

Linked bugs

gentoo-repo-qa-bot commented Sep 23, 2020

Pull request CI report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gentoo-repo-qa-bot commented Sep 23, 2020

Pull request CI report

gentoo-repo-qa-bot commented Sep 24, 2020

Pull request CI report

epsilon-0 commented Sep 24, 2020

gentoo-repo-qa-bot commented Sep 24, 2020

Pull request CI report

epsilon-0 commented Sep 24, 2020

gentoo-repo-qa-bot commented Sep 29, 2020

Pull request CI report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gentoo-repo-qa-bot commented Oct 31, 2020

Pull request CI report