Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sys-cluster/hpx: Bump version #17688

Closed
wants to merge 8 commits into from
Closed

Conversation

shifty91
Copy link
Contributor

This PR includes:

  • bump hpx to v1.5
  • bump breathe to v4.21 for building the documentation
  • bump libgeodecomp for hpx v1.5

Package-Manager: Portage-3.0.4, Repoman-3.0.1
Signed-off-by: Kurt Kanzenbach kurt@kmk-computers.de

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @shifty91
Areas affected: ebuilds
Packages affected: dev-python/breathe, sci-libs/libgeodecomp, sys-cluster/hpx

dev-python/breathe: @gentoo/python
sci-libs/libgeodecomp: @shifty91, @gentoo/proxy-maint
sys-cluster/hpx: @shifty91, @gentoo/proxy-maint

Linked bugs

Bugs linked: 741960


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Sep 27, 2020
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-09-27 05:21 UTC
Newest commit scanned: cbde7b3
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/5b1cc7565b/output.html

@@ -0,0 +1,75 @@
From f447f51e6a9e256df6439640290ed67132b2956b Mon Sep 17 00:00:00 2001
Copy link
Member

@thesamesam thesamesam Oct 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the patch upstreamed? (and others)? Any bug references?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually I upstream patches from to time. But, seems like upstream worked on this also and hpx 1.5.1. has been released in the mean time...

I'll update the PR. Thanks!

| 492 - tests.regressions.modules.performance_counters.dynamic_counters_loaded_1508 (Failed)
| 919 - tests.unit.parcelset.distributed.mpi.put_parcels_with_coalescing (Failed)
| 920 - tests.unit.parcelset.distributed.tcp.put_parcels_with_coalescing (Failed)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you verified these don't matter?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests usually fail within portage.

@shifty91
Copy link
Contributor Author

shifty91 commented Oct 14, 2020

Updated to current versions and the hpx patch is dropped. Thanks.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-10-14 18:06 UTC
Newest commit scanned: 4c75aac
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/8b53889227/output.html

src_configure() {
local mycmakeargs=(
-DHPX_WITH_EXAMPLES=OFF
-DHPX_WITH_DOCUMENTATION=$(usex doc)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/var/tmp/portage/gpm/portage/sys-cluster/hpx-1.5.1/work/hpx-1.5.1_build/docs/sphinx/libs/futures/docs/index.rst:14: WARNING: Unparseable C++ cross-reference: 'hpx:lcos::shared_future'
Error in cross-reference.
If shorthand ref:
  Invalid C++ declaration: Expected end of definition. [error at 3]
    hpx:lcos::shared_future
    ---^
If full function ref:
  Error when parsing function declaration.
  If the function has no return type:
    Error in declarator or parameters-and-qualifiers
    Invalid C++ declaration: Expecting "(" in parameters-and-qualifiers. [error at 3]
      hpx:lcos::shared_future
      ---^
  If the function has a return type:
    Error in declarator or parameters-and-qualifiers
    If pointer to member declarator:
      Invalid C++ declaration: Expected identifier in nested name. [error at 3]
        hpx:lcos::shared_future
        ---^
    If declarator-id:
      Invalid C++ declaration: Expected identifier in nested name. [error at 3]
        hpx:lcos::shared_future
        ---^

Exception occurred:
  File "/usr/lib/python3.8/site-packages/sphinx/domains/cpp.py", line 7375, in _resolve_xref_inner
    assert parentSymbol  # should be there
AssertionError
The full traceback has been saved in /var/tmp/portage/gpm/portage/sys-cluster/hpx-1.5.1/temp/sphinx-err-sqyorrt_.log, if you want to report the issue to the developers.
Please also report this if it was a user error, so that a better error message can be provided next time.
A bug report can be filed in the tracker at <https://github.com/sphinx-doc/sphinx/issues>. Thanks!

ninja: build stopped: subcommand failed.
 * ERROR: sys-cluster/hpx-1.5.1::testworld failed (compile phase):
 >: cat /var/tmp/portage/gpm/portage/sys-cluster/hpx-1.5.1/temp/sphinx-err-sqyorrt_.log
# Sphinx version: 3.2.1
# Python version: 3.8.6 (CPython)
# Docutils version: 0.16 release
# Jinja2 version: 2.11.2
# Last messages:
#   writing output... [ 64%] libs/runtime_configuration/docs/index
#   writing output... [ 64%] libs/runtime_local/api
#   writing output... [ 65%] libs/runtime_local/docs/index
#   writing output... [ 65%] libs/schedulers/api
#   writing output... [ 66%] libs/schedulers/docs/index
#   writing output... [ 66%] libs/segmented_algorithms/api
#   writing output... [ 67%] libs/segmented_algorithms/docs/index
#   writing output... [ 67%] libs/serialization/api
#   writing output... [ 67%] libs/serialization/docs/index
#   writing output... [ 68%] libs/static_reinit/api
# Loaded extensions:
#   sphinx.ext.mathjax (3.2.1) from /usr/lib/python3.8/site-packages/sphinx/ext/mathjax.py
#   sphinxcontrib.applehelp (1.0.2) from /usr/lib/python3.8/site-packages/sphinxcontrib/applehelp/__init__.py
#   sphinxcontrib.devhelp (1.0.2) from /usr/lib/python3.8/site-packages/sphinxcontrib/devhelp/__init__.py
#   sphinxcontrib.htmlhelp (1.0.3) from /usr/lib/python3.8/site-packages/sphinxcontrib/htmlhelp/__init__.py
#   sphinxcontrib.serializinghtml (1.1.4) from /usr/lib/python3.8/site-packages/sphinxcontrib/serializinghtml/__init__.py
#   sphinxcontrib.qthelp (1.0.3) from /usr/lib/python3.8/site-packages/sphinxcontrib/qthelp/__init__.py
#   alabaster (0.7.12) from /usr/lib/python3.8/site-packages/alabaster/__init__.py
#   sphinx.ext.autodoc.type_comment (3.2.1) from /usr/lib/python3.8/site-packages/sphinx/ext/autodoc/type_comment.py
#   sphinx.ext.autodoc (3.2.1) from /usr/lib/python3.8/site-packages/sphinx/ext/autodoc/__init__.py
#   sphinx.ext.doctest (3.2.1) from /usr/lib/python3.8/site-packages/sphinx/ext/doctest.py
#   sphinx.ext.intersphinx (3.2.1) from /usr/lib/python3.8/site-packages/sphinx/ext/intersphinx.py
#   sphinx.ext.todo (3.2.1) from /usr/lib/python3.8/site-packages/sphinx/ext/todo.py
#   sphinx.ext.coverage (3.2.1) from /usr/lib/python3.8/site-packages/sphinx/ext/coverage.py
#   sphinx.ext.ifconfig (3.2.1) from /usr/lib/python3.8/site-packages/sphinx/ext/ifconfig.py
#   sphinx.ext.viewcode (3.2.1) from /usr/lib/python3.8/site-packages/sphinx/ext/viewcode.py
#   breathe (4.22.1) from /usr/lib/python3.8/site-packages/breathe/__init__.py
#   sphinx-hpx (unknown version) from /var/tmp/portage/gpm/portage/sys-cluster/hpx-1.5.1/work/hpx-1.5.1_build/docs/sphinx/extensions/sphinx-hpx.py
Traceback (most recent call last):
  File "/usr/lib/python3.8/site-packages/sphinx/cmd/build.py", line 280, in build_main
    app.build(args.force_all, filenames)
  File "/usr/lib/python3.8/site-packages/sphinx/application.py", line 348, in build
    self.builder.build_update()
  File "/usr/lib/python3.8/site-packages/sphinx/builders/__init__.py", line 297, in build_update
    self.build(to_build,
  File "/usr/lib/python3.8/site-packages/sphinx/builders/__init__.py", line 361, in build
    self.write(docnames, list(updated_docnames), method)
  File "/usr/lib/python3.8/site-packages/sphinx/builders/__init__.py", line 535, in write
    self._write_serial(sorted(docnames))
  File "/usr/lib/python3.8/site-packages/sphinx/builders/__init__.py", line 542, in _write_serial
    doctree = self.env.get_and_resolve_doctree(docname, self)
  File "/usr/lib/python3.8/site-packages/sphinx/environment/__init__.py", line 539, in get_and_resolve_doctree
    self.apply_post_transforms(doctree, docname)
  File "/usr/lib/python3.8/site-packages/sphinx/environment/__init__.py", line 585, in apply_post_transforms
    transformer.apply_transforms()
  File "/usr/lib/python3.8/site-packages/sphinx/transforms/__init__.py", line 87, in apply_transforms
    super().apply_transforms()
  File "/usr/lib/python3.8/site-packages/docutils/transforms/__init__.py", line 171, in apply_transforms
    transform.apply(**kwargs)
  File "/usr/lib/python3.8/site-packages/sphinx/transforms/post_transforms/__init__.py", line 44, in apply
    self.run(**kwargs)
  File "/usr/lib/python3.8/site-packages/sphinx/transforms/post_transforms/__init__.py", line 87, in run
    newnode = domain.resolve_xref(self.env, refdoc, self.app.builder,
  File "/usr/lib/python3.8/site-packages/sphinx/domains/cpp.py", line 7501, in resolve_xref
    return self._resolve_xref_inner(env, fromdocname, builder, typ,
  File "/usr/lib/python3.8/site-packages/sphinx/domains/cpp.py", line 7375, in _resolve_xref_inner
    assert parentSymbol  # should be there
AssertionError

Seems to be doc-related. Rest looks good.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review. Yes, this is doc related. I'll debug it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed a fix for it. Thanks.

This is needed for generating the sys-cluster/hpx documentation.

Package-Manager: Portage-3.0.4, Repoman-3.0.1
Signed-off-by: Kurt Kanzenbach <kurt@kmk-computers.de>
Package-Manager: Portage-3.0.4, Repoman-3.0.1
Signed-off-by: Kurt Kanzenbach <kurt@kmk-computers.de>
Package-Manager: Portage-3.0.4, Repoman-3.0.1
Signed-off-by: Kurt Kanzenbach <kurt@kmk-computers.de>
The new version v1.5 builds with clang and boost-1.74. So, the build failure
bugs related to v1.4 can be closed.

Closes: https://bugs.gentoo.org/741960
Package-Manager: Portage-3.0.4, Repoman-3.0.1
Signed-off-by: Kurt Kanzenbach <kurt@kmk-computers.de>
Package-Manager: Portage-3.0.4, Repoman-3.0.1
Signed-off-by: Kurt Kanzenbach <kurt@kmk-computers.de>
Package-Manager: Portage-3.0.4, Repoman-3.0.1
Signed-off-by: Kurt Kanzenbach <kurt@kmk-computers.de>
Package-Manager: Portage-3.0.4, Repoman-3.0.1
Signed-off-by: Kurt Kanzenbach <kurt@kmk-computers.de>
Package-Manager: Portage-3.0.4, Repoman-3.0.1
Signed-off-by: Kurt Kanzenbach <kurt@kmk-computers.de>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-10-29 19:16 UTC
Newest commit scanned: 2a35b48
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/d2c69c95a4/output.html


| * One or more CMake variables were not used by the project:
| * BOOST_ROOT
| * SETUP_TYPE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This remains unfixed, but I'm not going to hold it back due to it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, true. Some tests use SETUP_TYPE and some don't. IMO it's a false positiv.

Comment on lines 80 to 82
src_test() {
virtx cmake_build check
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This failed for me with no verbose logs to show.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh, this shouldn't fail. I'll have a look. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
5 participants