Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net-p2p/go-ipfs-bin: Bump to 0.7.0 #17703

Closed
wants to merge 2 commits into from

Conversation

kakra
Copy link
Contributor

@kakra kakra commented Sep 28, 2020

No description provided.

Package-Manager: Portage-3.0.4, Repoman-3.0.1
Signed-off-by: Kai Krakow <kai@kaishome.de>
Package-Manager: Portage-3.0.4, Repoman-3.0.1
Signed-off-by: Kai Krakow <kai@kaishome.de>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @kakra
Areas affected: ebuilds
Packages affected: net-p2p/go-ipfs-bin

net-p2p/go-ipfs-bin: @stkw0, @kakra, @gentoo/proxy-maint

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). labels Sep 28, 2020
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-09-28 23:06 UTC
Newest commit scanned: 6dec31f
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/e8a68723c0/output.html

@stkw0
Copy link
Contributor

stkw0 commented Sep 29, 2020

I don't know if you were aware of it, but there is a non bin version of this package. I think that we should remove this package as the non binary one is preferred.

@kakra
Copy link
Contributor Author

kakra commented Sep 29, 2020

@stkw0 I noticed that but I figured it was easier to just bump the bin version instead of fiddling around with the huge module list of the source build, at least for now - it also spares me installing and building a lot of tooling and libs just to get this package. The version bump is needed now to still be able being an efficient node in IPFS as 0.7 changes some protocol stuff.

From that perspective, I'd say that this version bump should be merged, then focus on the build from source version and deprecating this package later (not bumping it to 0.8).

What do you think?

@stkw0
Copy link
Contributor

stkw0 commented Oct 3, 2020

Last week I was working on go-ipfs-0.7.0 but I had a checksum mismatch on go-msgio which I didn't know how to solve (I opened an issue upstream). It will be easier and faster to merge this binary ebuild than to fix the source-based version, so I agree with you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
5 participants