Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-vcs/tig: restore tab completion #17715

Closed
wants to merge 1 commit into from
Closed

Conversation

jsbronder
Copy link
Contributor

@jsbronder jsbronder commented Sep 29, 2020

The patch applied in the last bump is incorrect and effectively disables
bash completion no matter what order the completions were loaded in as
type -f will not find __git_complete.

$ type -f __git_complete
bash: type: __git_complete: not found
$ type __git_complete | grep 'is a'
__git_complete is a function

There is a pull-request upstream that properly addresses the issue of
__git_complete not being found but it's not accepted yet,
jonas/tig#1016

Package-Manager: Portage-3.0.4, Repoman-3.0.1
Signed-off-by: Justin Bronder jsbronder@cold-front.org

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @jsbronder
Areas affected: ebuilds
Packages affected: dev-vcs/tig

dev-vcs/tig: @gyakovlev, @chutz

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Sep 29, 2020
The patch applied in the last bump is incorrect and effectively disables
bash completion no matter what order the completions were loaded in as
`type -f` will not find `__git_complete`.

```
$ type -f __git_complete
bash: type: __git_complete: not found
$ type __git_complete | grep 'is a'
__git_complete is a function
```

There is a pull-request upstream that properly addresses the issue of
`__git_complete` not being found but it's not accepted yet,
jonas/tig#1016

Package-Manager: Portage-3.0.4, Repoman-3.0.1
Signed-off-by: Justin Bronder <jsbronder@cold-front.org>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-09-29 20:46 UTC
Newest commit scanned: 15e3e8d
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/57b18d9f71/output.html

@gentoo-bot gentoo-bot closed this in c48cfb2 Oct 3, 2020
@gyakovlev
Copy link
Member

agreed. let's better have small warning, but working completion.
we require git anyway as RDEPEND.

@gyakovlev
Copy link
Member

thanks!

NeddySeagoon pushed a commit to NeddySeagoon/gentoo-arm64 that referenced this pull request Oct 6, 2020
The patch applied in the last bump is incorrect and effectively disables
bash completion no matter what order the completions were loaded in as
`type -f` will not find `__git_complete`.

```
$ type -f __git_complete
bash: type: __git_complete: not found
$ type __git_complete | grep 'is a'
__git_complete is a function
```

There is a pull-request upstream that properly addresses the issue of
`__git_complete` not being found but it's not accepted yet,
jonas/tig#1016

Package-Manager: Portage-3.0.4, Repoman-3.0.1
Signed-off-by: Justin Bronder <jsbronder@cold-front.org>
Closes: gentoo#17715
Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits.
Projects
None yet
4 participants