Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net-mail/swaks: New upstream version 20201010.0 #17878

Closed
wants to merge 1 commit into from

Conversation

alarig
Copy link
Contributor

@alarig alarig commented Oct 10, 2020

Package-Manager: Portage-3.0.4, Repoman-3.0.1
Signed-off-by: Alarig Le Lay alarig@swordarmor.fr

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @alarig
Areas affected: ebuilds
Packages affected: net-mail/swaks

net-mail/swaks: @alarig, @gentoo/proxy-maint

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). labels Oct 10, 2020
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-10-10 19:41 UTC
Newest commit scanned: 4e473f0
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/00d07c103f/output.html

SLOT="0"
KEYWORDS="~amd64 ~ppc ~x86"

IUSE="ssl"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to have any function in this ebuild, move it to optfeature instead.
https://projects.gentoo.org/qa/policy-guide/dependencies.html#pg0001

inherit perl-functions

DESCRIPTION="Swiss Army Knife SMTP; Command line SMTP testing, including TLS and AUTH"
HOMEPAGE="http://www.jetmore.org/john/code/swaks"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add the Github page here as 2ndary HOMEPAGE.

DESCRIPTION="Swiss Army Knife SMTP; Command line SMTP testing, including TLS and AUTH"
HOMEPAGE="http://www.jetmore.org/john/code/swaks"
SRC_URI="http://www.jetmore.org/john/code/swaks/${P}.tar.gz"
LICENSE="GPL-2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They seem to be using GPL-2+ precisely.

Comment on lines 18 to 34
>=dev-perl/Authen-DigestMD5-0.04
>=dev-perl/Authen-NTLM-1.02
>=dev-perl/Net-DNS-0.65
>=virtual/perl-Digest-MD5-2.39
>=virtual/perl-MIME-Base64-3.07
>=virtual/perl-Time-HiRes-1.97
>=virtual/perl-Time-Local-1.19
dev-perl/CGI
dev-perl/DBI
dev-perl/Email-Send
dev-perl/Email-Valid
dev-perl/Params-Validate
dev-perl/URI
ssl? ( dev-perl/IO-Socket-SSL )
virtual/perl-Data-Dumper
virtual/perl-Digest-SHA
virtual/perl-Getopt-Long
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sort this list alphabetically, and remove the forbidden ssl? line moving it to optfeature.

Package-Manager: Portage-3.0.4, Repoman-3.0.1
Signed-off-by: Alarig Le Lay <alarig@swordarmor.fr>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-10-16 19:06 UTC
Newest commit scanned: f44a715
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/84e15256c5/output.html

@alarig
Copy link
Contributor Author

alarig commented Oct 17, 2020

Hi,

I pushed fixes for your comments, and renamed the file to swaks-20201014.0.ebuild as this new version is a bugfix for 20201010.0.

Please let me know if you have other remarks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
5 participants