New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net-mail/swaks: New upstream version 20201010.0 #17878
Conversation
Pull Request assignmentSubmitter: @alarig net-mail/swaks: @alarig, @gentoo/proxy-maint Linked bugsNo bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
Pull request CI reportReport generated at: 2020-10-10 19:41 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
SLOT="0" | ||
KEYWORDS="~amd64 ~ppc ~x86" | ||
|
||
IUSE="ssl" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't seem to have any function in this ebuild, move it to optfeature
instead.
https://projects.gentoo.org/qa/policy-guide/dependencies.html#pg0001
inherit perl-functions | ||
|
||
DESCRIPTION="Swiss Army Knife SMTP; Command line SMTP testing, including TLS and AUTH" | ||
HOMEPAGE="http://www.jetmore.org/john/code/swaks" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add the Github page here as 2ndary HOMEPAGE.
DESCRIPTION="Swiss Army Knife SMTP; Command line SMTP testing, including TLS and AUTH" | ||
HOMEPAGE="http://www.jetmore.org/john/code/swaks" | ||
SRC_URI="http://www.jetmore.org/john/code/swaks/${P}.tar.gz" | ||
LICENSE="GPL-2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They seem to be using GPL-2+
precisely.
>=dev-perl/Authen-DigestMD5-0.04 | ||
>=dev-perl/Authen-NTLM-1.02 | ||
>=dev-perl/Net-DNS-0.65 | ||
>=virtual/perl-Digest-MD5-2.39 | ||
>=virtual/perl-MIME-Base64-3.07 | ||
>=virtual/perl-Time-HiRes-1.97 | ||
>=virtual/perl-Time-Local-1.19 | ||
dev-perl/CGI | ||
dev-perl/DBI | ||
dev-perl/Email-Send | ||
dev-perl/Email-Valid | ||
dev-perl/Params-Validate | ||
dev-perl/URI | ||
ssl? ( dev-perl/IO-Socket-SSL ) | ||
virtual/perl-Data-Dumper | ||
virtual/perl-Digest-SHA | ||
virtual/perl-Getopt-Long |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please sort this list alphabetically, and remove the forbidden ssl?
line moving it to optfeature
.
Package-Manager: Portage-3.0.4, Repoman-3.0.1 Signed-off-by: Alarig Le Lay <alarig@swordarmor.fr>
4e473f0
to
f44a715
Compare
Pull request CI reportReport generated at: 2020-10-16 19:06 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Hi, I pushed fixes for your comments, and renamed the file to Please let me know if you have other remarks. |
Package-Manager: Portage-3.0.4, Repoman-3.0.1
Signed-off-by: Alarig Le Lay alarig@swordarmor.fr