Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

media-libs/opencv: version bump to 4.5.0 #17899

Closed
wants to merge 1 commit into from

Conversation

rossbridger
Copy link
Contributor

Starting this arduous work again only days after we put 4.4.0 into the tree...

Package-Manager: Portage-3.0.8, Repoman-3.0.1
Signed-off-by: Ross Charles Campbell rossbridger.cc@gmail.com

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @rossbridger
Areas affected: ebuilds
Packages affected: media-libs/opencv

media-libs/opencv: @Amynka

Linked bugs

Bugs linked: 747163, 666716, 747949, 704518


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Oct 12, 2020
@thesamesam
Copy link
Member

I strongly suspect we need a < dep on eigen for now.

@rossbridger
Copy link
Contributor Author

Wait till I have checked compiling with different USE flags. It's possible we might end up with another month to get this version mainlined.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-10-12 12:31 UTC
Newest commit scanned: 93eb54d
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/addb0e14d3/output.html

@rossbridger
Copy link
Contributor Author

Confirmed v4.5.0 is still affected by bug 747949

@thesamesam
Copy link
Member

thesamesam commented Oct 12, 2020

There's no reason to wait if trying an earlier Eigen value fixes it though. Could you try with Eigen 3.3.7-r1 vs 3.3.8?

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-10-12 13:06 UTC
Newest commit scanned: e22807f
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/155a5237c9/output.html

@thesamesam
Copy link
Member

thesamesam commented Oct 12, 2020

Let me know when ready for testing on my end. Have you figured out a workaround for that AVX multilib bug?

media-libs/opencv/opencv-4.5.0.ebuild Outdated Show resolved Hide resolved
media-libs/opencv/opencv-4.5.0.ebuild Outdated Show resolved Hide resolved
@rossbridger
Copy link
Contributor Author

Let me know when ready for testing on my end. Have you figured out a workaround for that AVX multilib bug?

Unless someone familiar with these SIMD intrinsics comes up with a patch, we might still need upstream to fix it. The only thing we can do is to prevent opencv from building the avx2-related code for x86 by either adding an explicit USE constraint or silently removing the avx2 flag from cmake arguments.

@thesamesam
Copy link
Member

We'll just drop the avx2 flag when doing x86.

@rossbridger rossbridger force-pushed the media-libs/opencv branch 3 times, most recently from 9c7133a to a8c2ad0 Compare October 14, 2020 01:35
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-10-14 01:41 UTC
Newest commit scanned: 3d416f5
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/f3e1b8ca22/output.html

@rossbridger rossbridger force-pushed the media-libs/opencv branch 2 times, most recently from 187d8a7 to 237edec Compare October 14, 2020 01:46
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-10-14 01:56 UTC
Newest commit scanned: 187d8a7
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/0b2bbb948a/output.html

@thesamesam
Copy link
Member

Ready for testing now? I'll remove the Eigen dep on merge as this has been fixed in the Eigen package now: 2a69391.

@rossbridger
Copy link
Contributor Author

It should be fine by now.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-10-14 02:11 UTC
Newest commit scanned: 237edec
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/485f3714f1/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-10-14 02:31 UTC
Newest commit scanned: 0d483e6
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/86c884344f/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-10-14 16:26 UTC
Newest commit scanned: 82b8b1a
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/6731a8a24c/output.html

 - Shall resolve the following bugs:
Closes: https://bugs.gentoo.org/666716
Closes: https://bugs.gentoo.org/747163
Closes: https://bugs.gentoo.org/729190
Closes: https://bugs.gentoo.org/699730
Closes: https://bugs.gentoo.org/672840

 - Might have also resolved the following bugs:
Bug: https://bugs.gentoo.org/701790
Bug: https://bugs.gentoo.org/700176
Bug: https://bugs.gentoo.org/717812
Bug: https://bugs.gentoo.org/703658
Bug: https://bugs.gentoo.org/689838
Package-Manager: Portage-3.0.8, Repoman-3.0.1

Signed-off-by: Ross Charles Campbell <rossbridger.cc@gmail.com>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-10-16 02:06 UTC
Newest commit scanned: abec05d
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/072dce3757/output.html

@rossbridger rossbridger deleted the media-libs/opencv branch October 17, 2020 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
7 participants