Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev-libs/hiredis: fix build with USE="-ssl" #18014

Closed
wants to merge 1 commit into from
Closed

dev-libs/hiredis: fix build with USE="-ssl" #18014

wants to merge 1 commit into from

Conversation

arkamar
Copy link
Member

@arkamar arkamar commented Oct 24, 2020

I changed rm to rm -f in order to ignore missing ${ED}/usr/$(get_libdir)/libhiredis.a when USE=-ssl is set.

@gentoo-bot gentoo-bot added maintainer-needed There is at least one affected package with no maintainer. Review it if you can. assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. no signoff One or more commits do not indicate GCO sign-off. labels Oct 24, 2020
@arkamar
dev-libs/hiredis: fix build with USE="-ssl"
8d51600 
Closes: https://bugs.gentoo.org/749396
Package-Manager: Portage-3.0.8, Repoman-3.0.2
Signed-off-by: Petr Vaněk <arkamar@atlas.cz>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-10-24 07:46 UTC
Newest commit scanned: 4b79c00
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/5e6096cfc9/output.html

@arkamar arkamar changed the title dev-libs/hiredis: fix build with USE="-ssl" dev-libs/hiredis: fix build with USE="-ssl" [please reassign] Oct 24, 2020
@gentoo-bot gentoo-bot changed the title dev-libs/hiredis: fix build with USE="-ssl" [please reassign] dev-libs/hiredis: fix build with USE="-ssl" Oct 24, 2020
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @arkamar
Areas affected: ebuilds
Packages affected: dev-libs/hiredis

dev-libs/hiredis: @gentoo/proxy-maint (maintainer needed)

Linked bugs

Bugs linked: 749396

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added maintainer-needed There is at least one affected package with no maintainer. Review it if you can. assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. and removed assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. maintainer-needed There is at least one affected package with no maintainer. Review it if you can. no signoff One or more commits do not indicate GCO sign-off. labels Oct 24, 2020
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-10-24 08:01 UTC
Newest commit scanned: 8d51600
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/cb6f89cd78/output.html

@Whissi
Copy link
Contributor

Whissi commented Oct 26, 2020

Thank you but the normal fix for problems like that is find "${ED}" -name '*.a' -delete || die which I am going to merge.

@arkamar
Copy link
Member Author

arkamar commented Oct 26, 2020

Thanks, I'll remeber it for next time.

@arkamar arkamar deleted the hiredis branch October 26, 2020 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. maintainer-needed There is at least one affected package with no maintainer. Review it if you can.
Projects
None yet
Milestone
No milestone
5 participants
@arkamar @gentoo-repo-qa-bot @gentoo-bot @Whissi @robbat2