Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

games-emulation/vbam: don't override CMAKE_AR #18064

Closed
wants to merge 1 commit into from
Closed

games-emulation/vbam: don't override CMAKE_AR #18064

wants to merge 1 commit into from

Conversation

DarthGandalf
Copy link
Contributor

Closes: https://bugs.gentoo.org/733938
Package-Manager: Portage-3.0.8, Repoman-3.0.1
Signed-off-by: Alexey Sokolov alexey+gentoo@asokolov.org

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @DarthGandalf
Areas affected: ebuilds
Packages affected: games-emulation/vbam

games-emulation/vbam: @gentoo/games

Linked bugs

Bugs linked: 733938

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Oct 29, 2020
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-10-29 01:56 UTC
Newest commit scanned: 7ad4cbc
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/f91dc5ccbe/output.html

chewi
chewi suggested changes Nov 1, 2020
View reviewed changes
Copy link
Member

@chewi chewi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry but a patch isn't needed here because you can just pass -DENABLE_LTO=OFF instead. The extra logic the project has around LTO doesn't seem necessary so there's no harm in doing this.

@DarthGandalf
Copy link
Contributor Author

Doesn't set() make it to ignore -D? set(ENABLE_LTO ON CACHE ...) would work like you describe.

@chewi
Copy link
Member

chewi commented Nov 7, 2020

You did have me thinking I'd got confused but actually I was right. 😛 LTO_DEFAULT is defined with set but ENABLE_LTO is already an option.

option(ENABLE_LTO "Compile with Link Time Optimization (gcc and clang only)" ${LTO_DEFAULT})

@DarthGandalf
games-emulation/vbam: don't override CMAKE_AR
88c8b46 
Closes: https://bugs.gentoo.org/733938
Package-Manager: Portage-3.0.8, Repoman-3.0.1
Signed-off-by: Alexey Sokolov <alexey+gentoo@asokolov.org>
@DarthGandalf
Copy link
Contributor Author

Indeed. I haven't noticed that there are 2 variables, not one.
Fixed.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-11-07 22:47 UTC
Newest commit scanned: 88c8b46
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/7e72de3295/output.html

@gentoo-bot gentoo-bot closed this in 4170d8b Nov 7, 2020
@DarthGandalf DarthGandalf deleted the vbam branch December 5, 2020 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chewi chewi chewi requested changes

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
Milestone
No milestone
5 participants
@DarthGandalf @gentoo-bot @gentoo-repo-qa-bot @chewi @robbat2