New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
media-video/shotcut: version bump to 20.10.31 #18117
Conversation
Pull Request assignmentSubmitter: @xdch47 media-video/shotcut: @reagentoo, @gentoo/proxy-maint Linked bugsIn order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
Pull request CI reportReport generated at: 2020-11-03 09:06 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
04049dd
to
324bd79
Compare
Pull request CI reportReport generated at: 2020-11-03 10:11 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but please split adding and removing ebuilds into separate commits. So this PR should have 2 commits instead of one.
sed -i -e '/QT.*private/d' \ | ||
src/src.pro || die |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is no longer necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It builds fine without in my case - The line which got removed is:
QT += qml-private core-private quick-private gui-private
(Using /usr/lib64/qt5/mkspecs/modules/qt_lib_{qml,core,quick,gui}_private.pri
)
Don't know what has been the problem - maybe thoses mkspecs or headers were missing in earlier QT version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Traced it back to this PR comment: #14393 (comment)
Basically silencing a bogus warning.
This is not your first contribution. Would you like to become new maintainer of this package? |
Package-Manager: Portage-3.0.9, Repoman-3.0.2 Signed-off-by: Felix Neumärker <xdch47@posteo.de>
Package-Manager: Portage-3.0.9, Repoman-3.0.2 Signed-off-by: Felix Neumärker <xdch47@posteo.de>
Package-Manager: Portage-3.0.9, Repoman-3.0.2 Signed-off-by: Felix Neumärker <xdch47@posteo.de>
324bd79
to
1a4832a
Compare
Pull request CI reportReport generated at: 2020-11-07 09:16 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Yes, I would like to - changed |
See also: #18117 Package-Manager: Portage-3.0.9, Repoman-3.0.2 Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
Closes: https://bugs.gentoo.org/688850
Bug: https://bugs.gentoo.org/744199
Package-Manager: Portage-3.0.9, Repoman-3.0.2
Signed-off-by: Felix Neumärker xdch47@posteo.de