Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

media-video/shotcut: version bump to 20.10.31 #18117

Closed
wants to merge 3 commits into from

Conversation

xdch47
Copy link
Contributor

@xdch47 xdch47 commented Nov 3, 2020

Closes: https://bugs.gentoo.org/688850
Bug: https://bugs.gentoo.org/744199
Package-Manager: Portage-3.0.9, Repoman-3.0.2
Signed-off-by: Felix Neumärker xdch47@posteo.de

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @xdch47
Areas affected: ebuilds
Packages affected: media-video/shotcut

media-video/shotcut: @reagentoo, @gentoo/proxy-maint

Linked bugs

Bugs linked: 688850, 744199


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Nov 3, 2020
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-11-03 09:06 UTC
Newest commit scanned: 04049dd
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/71412c67e9/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-11-03 10:11 UTC
Newest commit scanned: 324bd79
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/0f40519465/output.html

Copy link
Member

@juippis juippis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please split adding and removing ebuilds into separate commits. So this PR should have 2 commits instead of one.

media-video/shotcut/shotcut-20.10.31.ebuild Outdated Show resolved Hide resolved
media-video/shotcut/shotcut-20.10.31.ebuild Outdated Show resolved Hide resolved
media-video/shotcut/shotcut-20.10.31.ebuild Outdated Show resolved Hide resolved
Comment on lines -49 to -50
sed -i -e '/QT.*private/d' \
src/src.pro || die
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is no longer necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It builds fine without in my case - The line which got removed is:
QT += qml-private core-private quick-private gui-private (Using /usr/lib64/qt5/mkspecs/modules/qt_lib_{qml,core,quick,gui}_private.pri)
Don't know what has been the problem - maybe thoses mkspecs or headers were missing in earlier QT version?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Traced it back to this PR comment: #14393 (comment)

Basically silencing a bogus warning.

media-video/shotcut/shotcut-20.10.31.ebuild Outdated Show resolved Hide resolved
@a17r
Copy link
Member

a17r commented Nov 5, 2020

This is not your first contribution. Would you like to become new maintainer of this package?

Package-Manager: Portage-3.0.9, Repoman-3.0.2
Signed-off-by: Felix Neumärker <xdch47@posteo.de>
Package-Manager: Portage-3.0.9, Repoman-3.0.2
Signed-off-by: Felix Neumärker <xdch47@posteo.de>
Package-Manager: Portage-3.0.9, Repoman-3.0.2
Signed-off-by: Felix Neumärker <xdch47@posteo.de>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-11-07 09:16 UTC
Newest commit scanned: 1a4832a
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/47cd3ebf81/output.html

@xdch47
Copy link
Contributor Author

xdch47 commented Nov 7, 2020

This is not your first contribution. Would you like to become new maintainer of this package?

Yes, I would like to - changed metadata.xml as well.
--> https://bugs.gentoo.org/687148 has to be reopened then, right?

gentoo-bot pushed a commit that referenced this pull request Nov 21, 2020
See also: #18117

Package-Manager: Portage-3.0.9, Repoman-3.0.2
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
5 participants