New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sci-libs/med: bump to 4.1.0 #18408
sci-libs/med: bump to 4.1.0 #18408
Conversation
Pull Request assignmentSubmitter: @waebbl sci-libs/med: @tamiko, @waebbl, @gentoo/sci, @gentoo/proxy-maint Linked bugsBugs linked: 756208 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
Pull request CI reportReport generated at: 2020-11-26 00:19 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fortran support is no longer a cmake option by upstream, but an automagic dependency, so I removed the USE flag.
Could you try to patch this, and possible any other automagic deps, to be conditional again? We really hate these automagic deps in Gentoo as they're unpredictable.
See,
https://wiki.gentoo.org/wiki/Project:Quality_Assurance/Automagic_dependencies#CMake
https://gitweb.gentoo.org/repo/gentoo.git/tree/dev-libs/check/files/check-0.14.0-r2-disable-automagic-dep.patch
for examples.
Rest looks good.
I see what I can do |
Closes: https://bugs.gentoo.org/756208 Package-Manager: Portage-3.0.10, Repoman-3.0.2 Signed-off-by: Bernd Waibel <waebbl@gmail.com>
Package-Manager: Portage-3.0.10, Repoman-3.0.2 Signed-off-by: Bernd Waibel <waebbl@gmail.com>
@juippis I was able to re-add an option into the CMakeLists.txt file which works as intended. |
Pull request CI reportReport generated at: 2020-11-28 21:34 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, seems to work as intended!
Closes: https://bugs.gentoo.org/756208
Package-Manager: Portage-3.0.10, Repoman-3.0.2
Signed-off-by: Bernd Waibel waebbl@gmail.com
Fortran support is no longer a cmake option by upstream, but an automagic dependency, so I removed the USE flag.
Second commit drops old 4.0.0-r1