Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sci-libs/med: bump to 4.1.0 #18408

Closed
wants to merge 2 commits into from
Closed

sci-libs/med: bump to 4.1.0 #18408

wants to merge 2 commits into from

Conversation

waebbl
Copy link
Contributor

@waebbl waebbl commented Nov 26, 2020

Closes: https://bugs.gentoo.org/756208
Package-Manager: Portage-3.0.10, Repoman-3.0.2
Signed-off-by: Bernd Waibel waebbl@gmail.com

Fortran support is no longer a cmake option by upstream, but an automagic dependency, so I removed the USE flag.

Second commit drops old 4.0.0-r1

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @waebbl
Areas affected: ebuilds
Packages affected: sci-libs/med

sci-libs/med: @tamiko, @waebbl, @gentoo/sci, @gentoo/proxy-maint

Linked bugs

Bugs linked: 756208


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Nov 26, 2020
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-11-26 00:19 UTC
Newest commit scanned: 90416b8
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/d773a556eb/output.html

Copy link
Member

@juippis juippis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fortran support is no longer a cmake option by upstream, but an automagic dependency, so I removed the USE flag.

Could you try to patch this, and possible any other automagic deps, to be conditional again? We really hate these automagic deps in Gentoo as they're unpredictable.
See,
https://wiki.gentoo.org/wiki/Project:Quality_Assurance/Automagic_dependencies#CMake
https://gitweb.gentoo.org/repo/gentoo.git/tree/dev-libs/check/files/check-0.14.0-r2-disable-automagic-dep.patch
for examples.

Rest looks good.

@waebbl
Copy link
Contributor Author

waebbl commented Nov 26, 2020

I see what I can do

Closes: https://bugs.gentoo.org/756208
Package-Manager: Portage-3.0.10, Repoman-3.0.2
Signed-off-by: Bernd Waibel <waebbl@gmail.com>
Package-Manager: Portage-3.0.10, Repoman-3.0.2
Signed-off-by: Bernd Waibel <waebbl@gmail.com>
@waebbl
Copy link
Contributor Author

waebbl commented Nov 28, 2020

@juippis I was able to re-add an option into the CMakeLists.txt file which works as intended.
Other than that, I haven't noticed any other automagic dependencies.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-11-28 21:34 UTC
Newest commit scanned: a542d4a
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/34cae9e18b/output.html

Copy link
Member

@juippis juippis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, seems to work as intended!

@gentoo-bot gentoo-bot closed this in d380dea Dec 1, 2020
@waebbl waebbl deleted the med-4.1.0 branch July 30, 2021 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
4 participants