Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

media-sound/alsamixer: strsignal patch for bug #738176 #18786

Closed
wants to merge 1 commit into from
Closed

media-sound/alsamixer: strsignal patch for bug #738176 #18786

wants to merge 1 commit into from

Conversation

pyeatt
Copy link
Contributor

@pyeatt pyeatt commented Dec 23, 2020

Closes: https://bugs.gentoo.org/738176
Suggested-by: Larry Pyeatt larry.pyeatt@sdsmt.edu
Signed-off-by: Larry Pyeatt larry.pyeatt@sdsmt.edu

@pyeatt
media-sound/alsamixer: strsignal patch for bug #738176
68467d3 
Closes: https://bugs.gentoo.org/738176
Suggested-by: Larry Pyeatt <larry.pyeatt@sdsmt.edu>
Signed-off-by:  Larry Pyeatt <larry.pyeatt@sdsmt.edu>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @pyeatt
Areas affected: ebuilds
Packages affected: media-sound/alsamixergui

media-sound/alsamixergui: @gentoo/sound

Linked bugs

Bugs linked: 738176

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Dec 23, 2020
@thesamesam thesamesam self-requested a review December 23, 2020 17:34
@thesamesam
Copy link
Member

thesamesam commented Dec 23, 2020 •
edited

Nice! We don't need to revbump because this is a build-time fix but I can sort that on merge.

Thank you for this (and well done on getting the sign-off right first time)

@pyeatt
Copy link
Contributor Author

pyeatt commented Dec 23, 2020

Nice! We don't need to revbump because this is a build-time fix but I can sort that on merge.

Thank you for this (and well done on getting the sign-off right first time)

Thanks. I actually cancelled my first pull request and got it right the second time. Did not know about GLEP66 until the bot started complaining.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-12-23 17:59 UTC
Newest commit scanned: 68467d3
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/03be99cb3c/output.html

a17r
a17r approved these changes Dec 26, 2020
View reviewed changes
Copy link
Member

@a17r a17r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your fix. Had to tweak the commit message a bit: media-sound/alsamixer -> media-sound/alsamixergui

@pyeatt
Copy link
Contributor Author

pyeatt commented Dec 26, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a17r a17r a17r approved these changes

@thesamesam thesamesam Awaiting requested review from thesamesam

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
Milestone
No milestone
5 participants
@pyeatt @gentoo-bot @thesamesam @gentoo-repo-qa-bot @a17r