Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

app-portage/emlop: New ebuild #18819

Closed
wants to merge 3 commits into from
Closed

app-portage/emlop: New ebuild #18819

wants to merge 3 commits into from

Conversation

vincentdephily
Copy link
Contributor

Upstream author here, happy to proxy-maintain.
Prior ebuild development happens at https://github.com/vincentdephily/moltonel-ebuilds

Closes: https://bugs.gentoo.org/649904
Package-Manager: Portage-3.0.9, Repoman-3.0.2

@gentoo-bot gentoo-bot added new package The PR is adding a new package. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. no signoff One or more commits do not indicate GCO sign-off. labels Dec 26, 2020
@vincentdephily
Copy link
Contributor Author

Force-pushed commit that includes the signoff.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-12-26 20:19 UTC
Newest commit scanned: fed5cb7
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/cc424a4637/output.html

@telans
Copy link
Contributor

telans commented Dec 27, 2020

Append [please reassign] to the title. Do you mind if I add this to GURU while waiting for merge?

@vincentdephily vincentdephily changed the title app-portage/emlop: New ebuild app-portage/emlop: New ebuild [please reassign] Dec 27, 2020
@gentoo-bot gentoo-bot changed the title app-portage/emlop: New ebuild [please reassign] app-portage/emlop: New ebuild Dec 27, 2020
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @vincentdephily
Areas affected: ebuilds
Packages affected: app-portage/emlop

app-portage/emlop: @gentoo/proxy-maint (new package)

Linked bugs

Bugs linked: 649904

New packages

This Pull Request appears to be introducing new packages only. Due to limited manpower, adding new packages is considered low priority. This does not mean that your Pull Request will not receive any attention, however, it might take quite some time for it to be reviewed. In the meantime, your new ebuild might find a home in the GURU project repository: the ebuild repository maintained collaboratively by Gentoo users. GURU offers your ebuild a place to be reviewed and improved by other Gentoo users, while making it easy for Gentoo users to install it and enjoy the software it adds.

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added new package The PR is adding a new package. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. and removed assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. new package The PR is adding a new package. no signoff One or more commits do not indicate GCO sign-off. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) labels Dec 27, 2020
@vincentdephily
Copy link
Contributor Author

Changed the title 👍

I don't know what GURU is, but whatever helps with merging/testing/distributing I'm happy with. Note that the moltonel overlay (available from eselect repository) has this ebuild.

@vincentdephily
Copy link
Contributor Author

Found the GURU info, by all means add this ebuild there, though it's already available in my overlay and from crates.io (run cargo install emlop). So in my mind getting this into the official gentoo repo is the main todo.

Flowdalic
Flowdalic suggested changes Mar 17, 2023
View reviewed changes
Copy link
Member

@Flowdalic Flowdalic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. Sorry that it took so long.

I would be willing to maintain emlop in ::gentoo and add you as proxied maintainer. If you still want to work on this, together with me, then please update this PR to add the latest version of emlop. Which appears to be 0.5.0 at the time of writing this.

app-portage/emlop/emlop-0.4.1.ebuild Outdated Show resolved Hide resolved
app-portage/emlop/emlop-0.4.1.ebuild Outdated Show resolved Hide resolved
app-portage/emlop/emlop-0.4.1.ebuild Outdated Show resolved Hide resolved
app-portage/emlop/emlop-0.4.1.ebuild Outdated Show resolved Hide resolved
app-portage/emlop/emlop-0.4.1.ebuild Outdated Show resolved Hide resolved
app-portage/emlop/emlop-0.4.1.ebuild Outdated Show resolved Hide resolved
app-portage/emlop/emlop-0.4.1.ebuild Outdated Show resolved Hide resolved
@vincentdephily
Copy link
Contributor Author

Thanks for this, I'll update the PR during the week. The 0.6.0 release has been pending for months, I'll try to do that too.

@vincentdephily
app-portage/emlop: New ebuild
53d858d 
Closes: https://bugs.gentoo.org/649904
Package-Manager: Portage-3.0.9, Repoman-3.0.2
Signed-off-by: Vincent de Phily <moltonel@gmail.com>
@vincentdephily
app-portage/emlop: Drop redundant longdescription metadata
83436d2 
Signed-off-by: Vincent de Phily <moltonel@gmail.com>
Package-Manager: Portage-3.0.9, Repoman-3.0.2
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-03-29 13:50 UTC
Newest commit scanned: 83436d2
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/c2241f7f68/output.html

@vincentdephily
Copy link
Contributor Author

Made the requested changes AFAICT. I'm currently having trouble signing the commit, I might need to register a new key. I still need to release/package version 0.6.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-03-29 15:30 UTC
Newest commit scanned: e5d420c
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/1b76e00d2b/output.html

juippis
juippis reviewed Apr 10, 2023
View reviewed changes
Copy link
Member

@juippis juippis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Flowdalic ping :)

app-portage/emlop/emlop-0.5.0.ebuild
DESCRIPTION="A fast, accurate, ergonomic emerge.log parser"
HOMEPAGE="https://github.com/vincentdephily/emlop"
SRC_URI="$(cargo_crate_uris)"
RESTRICT="mirror"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably not needed?

app-portage/emlop/emlop-0.5.0.ebuild
"

SLOT="0"
KEYWORDS="~amd64 ~arm64 ~x86"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please only add ~amd64 and let the arch teams test it for the rest.

app-portage/emlop/emlop-0.5.0.ebuild
SLOT="0"
KEYWORDS="~amd64 ~arm64 ~x86"

DEPEND=">=virtual/rust-1.58.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd personally drop this version requirement as it's always going to be satisfied in ::gentoo repo. Cargo eclass will depend on rust so you could remove this line.

Suggested change
DEPEND=">=virtual/rust-1.58.1"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not just about depending on rust, but which version of rust is required. Rust crates have their own MSRV (minimum supported rust version), which could be higher than what the eclass requires. See gentoo/cargo-ebuild#34 for some discussion.

To be fair, in the case of emlop it's probably always going to support the oldest virtual/rust available in ::gentoo, but I feel that being explicit is better. No strong opinion though, if other people want to remove that DEPEND I'm fine with it.

@thesamesam
Copy link
Member

Done & big thanks for the patience!

@gentoo-bot gentoo-bot closed this in 8dfaee5 Jun 7, 2023
@thesamesam
Copy link
Member

@vincentdephily Are you planning on doing a PR for the new version? I promise it won't take anywhere near as long :)

@vincentdephily
Copy link
Contributor Author

Yes, sorry, busy times, and I got lost last time I tried to recreate GPG keys to comply with QA. That's still a requirement even for proxy-maintenance I think, pkgdev won't let me commit without one. I'll get to it soon(TM).

@thesamesam
Copy link
Member

@vincentdephily No worries! FWIW, as a proxied maintainer, you don't actually need a gpg key or to sign your commits. The issue is that pkgdev didn't really understand this until recently. See pkgcore/pkgdev#146 and pkgcore/pkgdev#146.

(Until that ends up in a release, you may want to just edit metadata/layout.conf to disable signing.)

(You do need to include Signed-off-by in commit messages but that's totally different.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flowdalic Flowdalic Flowdalic requested changes

@juippis juippis juippis left review comments

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. new package The PR is adding a new package. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
Milestone
No milestone
7 participants
@vincentdephily @gentoo-repo-qa-bot @telans @gentoo-bot @thesamesam @Flowdalic @juippis