Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app-backup/amanda: Clean up ebuild #18872

Closed
wants to merge 1 commit into from

Conversation

SoapGentoo
Copy link
Member

Closes: https://bugs.gentoo.org/762448
Package-Manager: Portage-3.0.12, Repoman-3.0.2
Signed-off-by: David Seifert soap@gentoo.org

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @SoapGentoo
Areas affected: ebuilds
Packages affected: app-backup/amanda

app-backup/amanda: @robbat2, @stefangweichinger, @gentoo/proxy-maint, dustin[at]v.igoro.us

Linked bugs

Bugs linked: 762448


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Dec 29, 2020
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-12-29 19:29 UTC
Newest commit scanned: dede555
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/47edbe7d01/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-12-29 19:49 UTC
Newest commit scanned: 8e2ed62
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/eaac27d7ae/output.html

Copy link
Member

@thesamesam thesamesam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny comments - none of which are actually problems with what we've changed here.


# What tar to use
[[ -z "${AMANDA_TAR}" ]] && AMANDA_TAR=/bin/tar
: ${AMANDA_TAR:=/bin/tar}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

${EPREFIX} here?


# Samba support
myconf="${myconf} $(use_with samba smbclient /usr/bin/smbclient)"
myconf+=( $(use_with samba smbclient /usr/bin/smbclient) )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we care enough to figure out if the build system prefixes these as needed tbh.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed

app-backup/amanda/amanda-3.5.1-r3.ebuild Show resolved Hide resolved
app-backup/amanda/amanda-3.5.1-r3.ebuild Show resolved Hide resolved
app-backup/amanda/amanda-3.5.1-r3.ebuild Show resolved Hide resolved
einfo "If you have migrated safely, please delete /etc/amandates"
fi

einfo "Checking setuid permissions"
amanda_permissions_fix "${ROOT}"
amanda_permissions_fix "${EROOT}"/

elog "You should configure Amanda in /etc/amanda now."
elog
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefix paths with ${EROOT}? ;)

Closes: https://bugs.gentoo.org/762448
Package-Manager: Portage-3.0.12, Repoman-3.0.2
Signed-off-by: David Seifert <soap@gentoo.org>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-12-30 10:35 UTC
Newest commit scanned: 951644e
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/601bab3331/output.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
5 participants