-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
app-backup/amanda: Clean up ebuild #18872
Conversation
Pull Request assignmentSubmitter: @SoapGentoo app-backup/amanda: @robbat2, @stefangweichinger, @gentoo/proxy-maint, Linked bugsBugs linked: 762448 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
8d973ea
to
dede555
Compare
Pull request CI reportReport generated at: 2020-12-29 19:29 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
dede555
to
8e2ed62
Compare
Pull request CI reportReport generated at: 2020-12-29 19:49 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiny comments - none of which are actually problems with what we've changed here.
|
||
# What tar to use | ||
[[ -z "${AMANDA_TAR}" ]] && AMANDA_TAR=/bin/tar | ||
: ${AMANDA_TAR:=/bin/tar} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
${EPREFIX} here?
|
||
# Samba support | ||
myconf="${myconf} $(use_with samba smbclient /usr/bin/smbclient)" | ||
myconf+=( $(use_with samba smbclient /usr/bin/smbclient) ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure we care enough to figure out if the build system prefixes these as needed tbh.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed
einfo "If you have migrated safely, please delete /etc/amandates" | ||
fi | ||
|
||
einfo "Checking setuid permissions" | ||
amanda_permissions_fix "${ROOT}" | ||
amanda_permissions_fix "${EROOT}"/ | ||
|
||
elog "You should configure Amanda in /etc/amanda now." | ||
elog |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefix paths with ${EROOT}? ;)
Closes: https://bugs.gentoo.org/762448 Package-Manager: Portage-3.0.12, Repoman-3.0.2 Signed-off-by: David Seifert <soap@gentoo.org>
8e2ed62
to
951644e
Compare
Pull request CI reportReport generated at: 2020-12-30 10:35 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Closes: https://bugs.gentoo.org/762448
Package-Manager: Portage-3.0.12, Repoman-3.0.2
Signed-off-by: David Seifert soap@gentoo.org