New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sci-geosciences/josm-bin: -bin version of the application #19018
Conversation
Pull Request assignmentSubmitter: @henning-schild sci-geosciences/josm-bin: @gentoo/proxy-maint (new package) Linked bugsBugs linked: 628944 New packagesThis Pull Request appears to be introducing new packages only. Due to limited manpower, adding new packages is considered low priority. This does not mean that your Pull Request will not receive any attention, however, it might take quite some time for it to be reviewed. In the meantime, your new ebuild might find a home in the GURU project repository: the ebuild repository maintained collaboratively by Gentoo users. GURU offers your ebuild a place to be reviewed and improved by other Gentoo users, while making it easy for Gentoo users to install it and enjoy the software it adds. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
Pull request CI reportReport generated at: 2021-01-10 16:55 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
1a882a2
to
ca7aef0
Compare
Pull request CI reportReport generated at: 2021-01-12 14:05 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
ca7aef0
to
d613af0
Compare
@mgorny i would like to get an answer on the general -bin approach Seems people are interested since we have reviews coming in |
Pull request CI reportReport generated at: 2021-01-20 21:40 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
+1 for the -bin approach. Upstream is using Ivy in the build.xml file which in theory can be patched/sed'ed out. However, in practice doing so will just cause a lot of pain, suffering and frustration (flashbacks to If @gentoo/proxy-maint agrees and @henning-schild is still interested in proxying this I would like to merge this after I've done a proper review and test. @henning-schild you can also add @gentoo/sci-geosciences as co-maintainer if you want, since that is the maintainer for the non-bin version. And if you feel like taking on a challenge you can try getting a non-bin version to work, here's an example of how Ivy can be patched out, though it will likely require adjusting and a lot of attempts: https://github.com/gentoo/sci/blob/master/dev-java/lucene/lucene-8.4.0.ebuild (and if not, then we'll just use the -bin version, which is probably the saner long-term option anyway) |
a2053c1
to
5077cb1
Compare
@AndrewAmmerlaan i decided to stick with -bin for now and addressed your comments, plus rebased and updated to the most recent version. |
Pull request CI reportReport generated at: 2021-08-01 14:24 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a quick look.
Building from source is very complicated, we are stuck with that for way too long. Go -bin and be done with it. Closes: https://bugs.gentoo.org/628944 Signed-off-by: Henning Schild <henning@hennsch.de>
5077cb1
to
8a7c0f8
Compare
Pull request CI reportReport generated at: 2021-08-03 07:39 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
@ionenwks thanks for all those findings, updated the PR accordingly |
Agreed, but lets wait a couple of weeks before we last-rite the non-bin version to see if any issues with the -bin version surface. |
I was thinking about a slow and non-invasive transition anyways. First step could be to notifiy "josm" users that "josm-bin" is around, kindly asking them to give it a try. Implementation could be a -rX bump on "josm" to do nothing but add some "einfo", or an "eselect news" posting. I think the latter would be better, but not sure this can be done to address only "josm"-users. Anyhow, i will go and point out "josm-bin exists" in all open bugs on https://bugs.gentoo.org |
Building from source is very complicated, we are stuck with that for way
too long. Go -bin and be done with it.
Closes: https://bugs.gentoo.org/628944
Signed-off-by: Henning Schild henning@hennsch.de