Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sci-geosciences/josm-bin: -bin version of the application #19018

Closed

Conversation

henning-schild
Copy link
Contributor

Building from source is very complicated, we are stuck with that for way
too long. Go -bin and be done with it.

Closes: https://bugs.gentoo.org/628944
Signed-off-by: Henning Schild henning@hennsch.de

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @henning-schild
Areas affected: ebuilds
Packages affected: sci-geosciences/josm-bin

sci-geosciences/josm-bin: @gentoo/proxy-maint (new package)

Linked bugs

Bugs linked: 628944

New packages

This Pull Request appears to be introducing new packages only. Due to limited manpower, adding new packages is considered low priority. This does not mean that your Pull Request will not receive any attention, however, it might take quite some time for it to be reviewed. In the meantime, your new ebuild might find a home in the GURU project repository: the ebuild repository maintained collaboratively by Gentoo users. GURU offers your ebuild a place to be reviewed and improved by other Gentoo users, while making it easy for Gentoo users to install it and enjoy the software it adds.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added new package The PR is adding a new package. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Jan 10, 2021
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-01-10 16:55 UTC
Newest commit scanned: 1a882a2
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/cece76750c/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-01-12 14:05 UTC
Newest commit scanned: ca7aef0
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/81496fe7a8/output.html

@henning-schild
Copy link
Contributor Author

@mgorny i would like to get an answer on the general -bin approach

#10475 (comment)

Seems people are interested since we have reviews coming in

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-01-20 21:40 UTC
Newest commit scanned: d613af0
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/1f72c37434/output.html

@AndrewAmmerlaan
Copy link
Member

@mgorny i would like to get an answer on the general -bin approach

#10475 (comment)

Seems people are interested since we have reviews coming in

+1 for the -bin approach. Upstream is using Ivy in the build.xml file which in theory can be patched/sed'ed out. However, in practice doing so will just cause a lot of pain, suffering and frustration (flashbacks to dev-java/lucene are still haunting me).

If @gentoo/proxy-maint agrees and @henning-schild is still interested in proxying this I would like to merge this after I've done a proper review and test.

@henning-schild you can also add @gentoo/sci-geosciences as co-maintainer if you want, since that is the maintainer for the non-bin version. And if you feel like taking on a challenge you can try getting a non-bin version to work, here's an example of how Ivy can be patched out, though it will likely require adjusting and a lot of attempts: https://github.com/gentoo/sci/blob/master/dev-java/lucene/lucene-8.4.0.ebuild (and if not, then we'll just use the -bin version, which is probably the saner long-term option anyway)

sci-geosciences/josm-bin/josm-bin-17428.ebuild Outdated Show resolved Hide resolved
sci-geosciences/josm-bin/josm-bin-17428.ebuild Outdated Show resolved Hide resolved
sci-geosciences/josm-bin/josm-bin-17428.ebuild Outdated Show resolved Hide resolved
sci-geosciences/josm-bin/josm-bin-17428.ebuild Outdated Show resolved Hide resolved
sci-geosciences/josm-bin/josm-bin-17428.ebuild Outdated Show resolved Hide resolved
sci-geosciences/josm-bin/josm-bin-17428.ebuild Outdated Show resolved Hide resolved
@henning-schild henning-schild force-pushed the henning/staging5 branch 2 times, most recently from a2053c1 to 5077cb1 Compare August 1, 2021 14:14
@henning-schild
Copy link
Contributor Author

@AndrewAmmerlaan i decided to stick with -bin for now and addressed your comments, plus rebased and updated to the most recent version.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-08-01 14:24 UTC
Newest commit scanned: 5077cb1
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/1ed9593240/output.html

Copy link
Contributor

@ionenwks ionenwks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick look.

sci-geosciences/josm-bin/josm-bin-18004.ebuild Outdated Show resolved Hide resolved
sci-geosciences/josm-bin/josm-bin-18004.ebuild Outdated Show resolved Hide resolved
sci-geosciences/josm-bin/josm-bin-18004.ebuild Outdated Show resolved Hide resolved
sci-geosciences/josm-bin/josm-bin-18004.ebuild Outdated Show resolved Hide resolved
sci-geosciences/josm-bin/josm-bin-18004.ebuild Outdated Show resolved Hide resolved
sci-geosciences/josm-bin/metadata.xml Outdated Show resolved Hide resolved
Building from source is very complicated, we are stuck with that for way
too long. Go -bin and be done with it.

Closes: https://bugs.gentoo.org/628944
Signed-off-by: Henning Schild <henning@hennsch.de>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-08-03 07:39 UTC
Newest commit scanned: 8a7c0f8
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/9d295c7087/output.html

@henning-schild
Copy link
Contributor Author

@ionenwks thanks for all those findings, updated the PR accordingly

@gentoo-bot gentoo-bot closed this in 78af071 Aug 3, 2021
@AndrewAmmerlaan
Copy link
Member

Very nice, Thank You for working on this!

Can we close #10475 and #9771 since those seem obsolete now?

@henning-schild
Copy link
Contributor Author

Can we close #10475 and #9771 since those seem obsolete now?

Well the question is now if we remove the non-bin and the problems it might have. I guess the logical consequence would be to to retire "josm" and transistion the users to "josm-bin"

@henning-schild henning-schild deleted the henning/staging5 branch August 3, 2021 12:52
@AndrewAmmerlaan
Copy link
Member

I guess the logical consequence would be to to retire "josm" and transistion the users to "josm-bin"

Agreed, but lets wait a couple of weeks before we last-rite the non-bin version to see if any issues with the -bin version surface.

@henning-schild
Copy link
Contributor Author

I guess the logical consequence would be to to retire "josm" and transistion the users to "josm-bin"

Agreed, but lets wait a couple of weeks before we last-rite the non-bin version to see if any issues with the -bin version surface.

I was thinking about a slow and non-invasive transition anyways. First step could be to notifiy "josm" users that "josm-bin" is around, kindly asking them to give it a try.

Implementation could be a -rX bump on "josm" to do nothing but add some "einfo", or an "eselect news" posting. I think the latter would be better, but not sure this can be done to address only "josm"-users.

Anyhow, i will go and point out "josm-bin exists" in all open bugs on https://bugs.gentoo.org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. new package The PR is adding a new package. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
7 participants