app-i18n/transifex-client: drop dependency to dev-python/mock #19057

robert7k · 2021-01-13T22:50:25Z

Bug: https://bugs.gentoo.org/765349

gentoo-bot · 2021-01-13T22:52:05Z

Pull Request assignment

Submitter: @robert7k
Areas affected: ebuilds
Packages affected: app-i18n/transifex-client

app-i18n/transifex-client: @robert7k, @gentoo/proxy-maint

Linked bugs

Bugs linked: 765349

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

gentoo-repo-qa-bot · 2021-01-13T23:05:10Z

Pull request CI report

Report generated at: 2021-01-13 23:05 UTC
Newest commit scanned: 2bb3866
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/0b1c13a38e/output.html

juippis

error: Could not find suitable distribution for Requirement.parse('smmap<4,>=3.0.1')
 * ERROR: app-i18n/transifex-client-0.14.2-r1::testworld failed (test phase):
 *   Tests fail with python3.7

It also has a strict version requirement...

robert7k · 2021-01-31T01:08:54Z

error: Could not find suitable distribution for Requirement.parse('smmap<4,>=3.0.1')
 * ERROR: app-i18n/transifex-client-0.14.2-r1::testworld failed (test phase):
 *   Tests fail with python3.7

It also has a strict version requirement...

That's strange – smmap isn't even a direct dependency of transifex-client. I also couldn't reproduce this after installing smmap-4.0.0 (both with Python 3.7 and 3.9). Do you have more information on where exactly this error message comes from?

Rebased the PR on the most recent master.

gentoo-repo-qa-bot · 2021-01-31T01:21:30Z

Pull request CI report

Report generated at: 2021-01-31 01:21 UTC
Newest commit scanned: 67b139e
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/9d1aca42e9/output.html

ionenwks · 2021-01-31T01:24:32Z

error: Could not find suitable distribution for Requirement.parse('smmap<4,>=3.0.1')
It also has a strict version requirement...
That's strange – smmap isn't even a direct dependency of transifex-client. I also couldn't reproduce this after installing smmap-4.0.0 (both with Python 3.7 and 3.9). Do you have more information on where exactly this error message comes from?

Was looking at this earlier because of https://bugs.gentoo.org/767970, this strict dependency was set nearly a year ago and 4.0.0 was released only 7 days ago. I haven't tested but like @thesamesam I question its validity.

Edit: Also it's likely coming from GitPython (which I see transifex depends on) which itself depends on gitdb, not that I looked further.

gentoo-repo-qa-bot · 2021-01-31T01:36:32Z

Pull request CI report

Report generated at: 2021-01-31 01:36 UTC
Newest commit scanned: a6c1157
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/c59618e5bf/output.html

ionenwks · 2021-01-31T15:15:40Z

https://bugs.gentoo.org/767970

Been resolved, I don't think this package need to worry about this smmap issue.

juippis · 2021-02-02T13:20:43Z

app-i18n/transifex-client/transifex-client-0.14.2-r1.ebuild

@@ -31,4 +30,5 @@ src_prepare() {
 	eapply_user
 	sed -i -e 's:test_fetch_timestamp_from_git_tree:_&:' \
 		tests/test_utils.py || die
+	sed -i ':tests_require=["mock>=3.0.5,<4.0"]:d' setup.py || die


>>> Source compiled. >>> Test phase: app-i18n/transifex-client-0.14.2-r1 * python3_7: running distutils-r1_run_phase python_test python3.7 setup.py test --verbose Warning: 'keywords' should be a list, got type 'tuple' running test WARNING: Testing via this command is deprecated and will be removed in a future version. Users looking for a generic test entry point independent of test runner are encouraged to use tox. WARNING: The wheel package is not available. /usr/bin/python3.7: No module named pip error: Command '['/usr/bin/python3.7', '-m', 'pip', '--disable-pip-version-check', 'wheel', '--no-deps', '-w', '/var/tmp/portage/app-i18n/transifex-client-0.14.2-r1/temp/tmpfl1rd2d3', '--quiet', 'mock<4.0,>=3.0.5']' returned non-zero exit status 1. * ERROR: app-i18n/transifex-client-0.14.2-r1::testworld failed (test phase): * Tests fail with python3.7

>: grep -i mock /var/tmp/portage/app-i18n/transifex-client-0.14.2-r1/work/transifex-client-0.14.2/setup.py tests_require=["mock>=3.0.5,<4.0"],

I don't know why, but the : don't seem to work very well as delimiters. Switch to / and it works.

Strange, worked fine for me. Replaced anyway.

gentoo-repo-qa-bot · 2021-02-02T18:50:22Z

Pull request CI report

Report generated at: 2021-02-02 18:50 UTC
Newest commit scanned: 5276763
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/094c0271f2/output.html

juippis · 2021-02-03T06:57:32Z

app-i18n/transifex-client/transifex-client-0.14.2-r1.ebuild

+	eapply_user
+	sed -i -e 's:test_fetch_timestamp_from_git_tree:_&:' \
+		tests/test_utils.py || die
+	sed -i '/tests_require=["mock>=3.0.5,<4.0"]/d' setup.py || die


>: cd /var/tmp/portage/app-i18n/transifex-client-0.14.2-r1/work/transifex-client-0.14.2/ >: grep -i mock setup.py tests_require=["mock>=3.0.5,<4.0"], >: sed -i '/tests_require=["mock>=3.0.5,<4.0"]/d' setup.py >: grep -i mock setup.py tests_require=["mock>=3.0.5,<4.0"], >: sed -i '/tests_require=/d' setup.py >: grep -i mock setup.py >:

Seriously what is going on? Can someone explain? Is it just me?

That sed doesn't work for me either, fine if brackets are escaped.
sed -i '/tests_require=\["mock>=3.0.5,<4.0"\]/d' setup.py

Makes sense to escape the brackets, so I added that. Still wondering why it worked for me anyway...

Bug: https://bugs.gentoo.org/765349 Signed-off-by: Robert Siebeck <gentoo.2019@r123.de>

Signed-off-by: Robert Siebeck <gentoo.2019@r123.de>

gentoo-repo-qa-bot · 2021-02-03T18:50:24Z

Pull request CI report

Report generated at: 2021-02-03 18:50 UTC
Newest commit scanned: b6874a6
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/daafb3b7a0/output.html

juippis

So now the sed works, but the test cases are actually using mock.

======================================================================
ERROR: test_api (unittest.loader._FailedTest)
----------------------------------------------------------------------
ImportError: Failed to import test module: test_api
Traceback (most recent call last):
  File "/usr/lib/python3.7/unittest/loader.py", line 154, in loadTestsFromName
    module = __import__(module_name)
  File "/var/tmp/portage/app-i18n/transifex-client-0.14.2-r1/work/transifex-client-0.14.2/tests/test_api.py", line 4, in <module>
    from mock import MagicMock, patch
ModuleNotFoundError: No module named 'mock'


----------------------------------------------------------------------
Ran 10 tests in 0.001s

FAILED (errors=6)
Test failed: <unittest.runner.TextTestResult run=10 errors=6 failures=0>
error: Test failed: <unittest.runner.TextTestResult run=10 errors=6 failures=0>
 * ERROR: app-i18n/transifex-client-0.14.2-r1::testworld failed (test phase):
 *   Tests fail with python3.7

https://github.com/transifex/transifex-client/blob/master/tests/test_project.py#L16
https://github.com/transifex/transifex-client/blob/master/tests/test_api.py#L4

What are we doing in here? It does look like removing mock needs a bit more, ie a full patch.

EDIT: Or if possible https://dev.gentoo.org/~mgorny/python-guide/test.html#skipping-problematic-tests

juippis

Only now I get the point of this PR, the tests work with later version of mock, so the restriction is redundant in setup.py. We still need to BDEPEND on mock though.

Thanks for sticking it through!

robert7k mentioned this pull request Jan 13, 2021

app-i18n/transifex-client: fix dependencies, add support for Python 3.9 #18603

Closed

gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Jan 13, 2021

juippis reviewed Jan 28, 2021

View reviewed changes

robert7k force-pushed the transifex branch from 2bb3866 to 67b139e Compare January 31, 2021 01:06

robert7k force-pushed the transifex branch from 67b139e to a6c1157 Compare January 31, 2021 01:10

robert7k requested a review from juippis January 31, 2021 12:46

juippis reviewed Feb 2, 2021

View reviewed changes

robert7k force-pushed the transifex branch from a6c1157 to 5276763 Compare February 2, 2021 18:36

robert7k requested a review from juippis February 2, 2021 18:37

juippis reviewed Feb 3, 2021

View reviewed changes

robert7k added 2 commits February 3, 2021 19:12

app-i18n/transifex-client: drop dependency to dev-python/mock

39a7b43

Bug: https://bugs.gentoo.org/765349 Signed-off-by: Robert Siebeck <gentoo.2019@r123.de>

app-i18n/transifex-client: remove old version

b6874a6

Signed-off-by: Robert Siebeck <gentoo.2019@r123.de>

robert7k force-pushed the transifex branch from 5276763 to b6874a6 Compare February 3, 2021 18:13

juippis reviewed Feb 4, 2021

View reviewed changes

juippis approved these changes Feb 4, 2021

View reviewed changes

gentoo-bot closed this in 378f706 Feb 4, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

app-i18n/transifex-client: drop dependency to dev-python/mock #19057

app-i18n/transifex-client: drop dependency to dev-python/mock #19057

robert7k commented Jan 13, 2021

gentoo-bot commented Jan 13, 2021

gentoo-repo-qa-bot commented Jan 13, 2021

juippis left a comment

robert7k commented Jan 31, 2021

gentoo-repo-qa-bot commented Jan 31, 2021

ionenwks commented Jan 31, 2021 •

edited

gentoo-repo-qa-bot commented Jan 31, 2021

ionenwks commented Jan 31, 2021

juippis Feb 2, 2021

robert7k Feb 2, 2021

gentoo-repo-qa-bot commented Feb 2, 2021

juippis Feb 3, 2021 •

edited

ionenwks Feb 3, 2021

robert7k Feb 3, 2021

gentoo-repo-qa-bot commented Feb 3, 2021

juippis left a comment •

edited

juippis left a comment

app-i18n/transifex-client: drop dependency to dev-python/mock #19057

app-i18n/transifex-client: drop dependency to dev-python/mock #19057

Conversation

robert7k commented Jan 13, 2021

gentoo-bot commented Jan 13, 2021

Pull Request assignment

Linked bugs

gentoo-repo-qa-bot commented Jan 13, 2021

Pull request CI report

juippis left a comment

Choose a reason for hiding this comment

robert7k commented Jan 31, 2021

gentoo-repo-qa-bot commented Jan 31, 2021

Pull request CI report

ionenwks commented Jan 31, 2021 • edited

gentoo-repo-qa-bot commented Jan 31, 2021

Pull request CI report

ionenwks commented Jan 31, 2021

juippis Feb 2, 2021

Choose a reason for hiding this comment

robert7k Feb 2, 2021

Choose a reason for hiding this comment

gentoo-repo-qa-bot commented Feb 2, 2021

Pull request CI report

juippis Feb 3, 2021 • edited

Choose a reason for hiding this comment

ionenwks Feb 3, 2021

Choose a reason for hiding this comment

robert7k Feb 3, 2021

Choose a reason for hiding this comment

gentoo-repo-qa-bot commented Feb 3, 2021

Pull request CI report

juippis left a comment • edited

Choose a reason for hiding this comment

juippis left a comment

Choose a reason for hiding this comment

ionenwks commented Jan 31, 2021 •

edited

juippis Feb 3, 2021 •

edited

juippis left a comment •

edited