Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev-lang/rust: Add rust-1.49.0.ebuild #19060

Closed
wants to merge 1 commit into from
Closed

dev-lang/rust: Add rust-1.49.0.ebuild #19060

wants to merge 1 commit into from

Conversation

margamanterola
Copy link
Contributor

This required a refactor of the gentoo-musl-target-specs.patch, to adopt
the new format of the target() method.

Signed-off-by: Margarita Manterola marga@kinvolk.io

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @marga-kinvolk
Areas affected: ebuilds
Packages affected: dev-lang/rust

dev-lang/rust: @gyakovlev, @gentoo/rust

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Jan 14, 2021
dev-lang/rust: Add rust-1.49.0.ebuild
40c7659 
This required a refactor of the gentoo-musl-target-specs.patch, to adopt
the new format of the target() method.

Signed-off-by: Margarita Manterola <marga@kinvolk.io>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-01-14 12:30 UTC
Newest commit scanned: 40c7659
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/cb072493f0/output.html

@loannaflip
Copy link

Looks Good!

@loannaflip
Copy link

loannaflip commented Jan 18, 2021 •
edited

The patch 1.49.0-gentoo-musl-target-specs.patch is missing from dev-lang/rust-1.49.0/files/1.49.0-gentoo-musl-target-specs.patch mistake >~<

@loannaflip
Copy link

loannaflip commented Jan 18, 2021 •
edited

@marga-kinvolk ping! Add the patch already there, im dumb

@margamanterola
Copy link
Contributor Author

I'm sorry, I don't understand the comment. The patch is in this PR, where is it missing from?

@loannaflip
Copy link

My bad. It's alright!

@loannaflip
Copy link

I was trying it on my system and it fails to merge. The build log: https://dpaste.com/3K4U6LYQF.txt

@dongsupark
Copy link
Contributor

It looks good.
I have tested this PR on a clean Gentoo system.
It worked well. I have not seen build failures mentioned above.

@gentoo-bot gentoo-bot closed this in e45ec73 Feb 2, 2021
@gyakovlev
Copy link
Member

thanks! merged.

sorry for delay, was really busy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gyakovlev gyakovlev Awaiting requested review from gyakovlev

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits.
Projects
None yet
Milestone
No milestone
6 participants
@margamanterola @gentoo-bot @gentoo-repo-qa-bot @loannaflip @dongsupark @gyakovlev