Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sys-boot/grub: fix build with clang #19099

Closed
wants to merge 1 commit into from
Closed

sys-boot/grub: fix build with clang #19099

wants to merge 1 commit into from

Conversation

telans
Copy link
Contributor

@telans telans commented Jan 18, 2021

Closes: https://bugs.gentoo.org/741924
Package-Manager: Portage-3.0.13, Repoman-3.0.2
Signed-off-by: Theo Anderson telans@posteo.de

@telans
sys-boot/grub: fix build with clang
1258eba 
Closes: https://bugs.gentoo.org/741924
Package-Manager: Portage-3.0.13, Repoman-3.0.2
Signed-off-by: Theo Anderson <telans@posteo.de>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @telans
Areas affected: ebuilds
Packages affected: sys-boot/grub

sys-boot/grub: @floppym, @gentoo/base-system

Linked bugs

Bugs linked: 741924

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Jan 18, 2021
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-01-18 04:55 UTC
Newest commit scanned: 1258eba
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/75c1d4a0a3/output.html

@floppym
Copy link
Contributor

floppym commented Jan 18, 2021

Thank you for the patch, but I will probably add a new snapshot instead.

@telans
Copy link
Contributor Author

telans commented Mar 2, 2021

@floppym do you mind merging this in the meantime?

@telans
Copy link
Contributor Author

telans commented Apr 12, 2021

@floppym ping

@floppym
Copy link
Contributor

floppym commented Apr 12, 2021

This patch is included upstream in grub-2.06~rc1. That makes this PR obsolete.

@floppym floppym closed this Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
Milestone
No milestone
4 participants
@telans @gentoo-bot @gentoo-repo-qa-bot @floppym