Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-libs/granite: become proxied maintainer; bump to version 5.5.0 #19104

Closed
wants to merge 1 commit into from
Closed

dev-libs/granite: become proxied maintainer; bump to version 5.5.0 #19104

wants to merge 1 commit into from

Conversation

xgqt
Copy link
Member

@xgqt xgqt commented Jan 18, 2021

Package-Manager: Portage-3.0.12, Repoman-3.0.2
Signed-off-by: Maciej Barć xgqt@protonmail.com

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @xgqt
Areas affected: ebuilds
Packages affected: dev-libs/granite

dev-libs/granite: @gentoo/proxy-maint (maintainer needed)

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added maintainer-needed There is at least one affected package with no maintainer. Review it if you can. assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Jan 18, 2021
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-01-18 15:40 UTC
Newest commit scanned: a3ae37b
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/1384890373/output.html

Comment on lines 42 to 60
local doc_sed_list=(
"lib/Widgets/AboutDialog.vala"
"lib/Widgets/AlertView.vala"
"lib/Widgets/AsyncImage.vala"
"lib/Widgets/Avatar.vala"
"lib/Widgets/CellRendererBadge.vala"
"lib/Widgets/DynamicNotebook.vala"
"lib/Widgets/MessageDialog.vala"
"lib/Widgets/ModeButton.vala"
"lib/Widgets/OverlayBar.vala"
"lib/Widgets/SeekBar.vala"
"lib/Widgets/StorageBar.vala"
"lib/Widgets/Toast.vala"
"lib/Widgets/Welcome.vala"
)
for src_file in "${doc_sed_list[@]}"; do
sed -ie "s@{{../doc@{{${BUILD_DIR}/doc@g" \
"./${src_file}" || die "Failed to fix docs for ./${src_file}"
done
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be replaced with a simple find -exec sed line?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be replaced with a simple find -exec sed line?

will do

LICENSE="LGPL-3+"
SLOT="0"
KEYWORDS="~amd64 ~x86"
IUSE="doc +introspection"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand what this USE flag does. How does granite change depending on the deps[introspection] state?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juippis well... option('introspection', type: 'boolean', value: true, description: 'Whether to build introspection files')

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But you don't have it defined in src_configure :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juippis Blame the last maintainer. >:-)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juippis Oh! Optional introspection support is only on master!

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-01-29 18:52 UTC
Newest commit scanned: a6e14ec
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/3335dac0c4/output.html

…doc fixes; bump to 5.5.0

Package-Manager: Portage-3.0.12, Repoman-3.0.2
Signed-off-by: Maciej Barć <xgqt@protonmail.com>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-01-30 14:31 UTC
Newest commit scanned: 078b8a3
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/e836e8e616/output.html

@gentoo-bot gentoo-bot closed this in a96f316 Feb 1, 2021
@xgqt
Copy link
Member Author

xgqt commented Feb 1, 2021

Thanks for cooperation.

@xgqt xgqt deleted the proxy-granite branch April 7, 2021 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). maintainer-needed There is at least one affected package with no maintainer. Review it if you can. no bug found No Bug/Closes found in the commits.
Projects
None yet
4 participants