-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev-libs/granite: become proxied maintainer; bump to version 5.5.0 #19104
Conversation
Pull Request assignmentSubmitter: @xgqt dev-libs/granite: @gentoo/proxy-maint (maintainer needed) Linked bugsNo bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
Pull request CI reportReport generated at: 2021-01-18 15:40 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
local doc_sed_list=( | ||
"lib/Widgets/AboutDialog.vala" | ||
"lib/Widgets/AlertView.vala" | ||
"lib/Widgets/AsyncImage.vala" | ||
"lib/Widgets/Avatar.vala" | ||
"lib/Widgets/CellRendererBadge.vala" | ||
"lib/Widgets/DynamicNotebook.vala" | ||
"lib/Widgets/MessageDialog.vala" | ||
"lib/Widgets/ModeButton.vala" | ||
"lib/Widgets/OverlayBar.vala" | ||
"lib/Widgets/SeekBar.vala" | ||
"lib/Widgets/StorageBar.vala" | ||
"lib/Widgets/Toast.vala" | ||
"lib/Widgets/Welcome.vala" | ||
) | ||
for src_file in "${doc_sed_list[@]}"; do | ||
sed -ie "s@{{../doc@{{${BUILD_DIR}/doc@g" \ | ||
"./${src_file}" || die "Failed to fix docs for ./${src_file}" | ||
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this be replaced with a simple find -exec sed
line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this be replaced with a simple
find -exec sed
line?
will do
LICENSE="LGPL-3+" | ||
SLOT="0" | ||
KEYWORDS="~amd64 ~x86" | ||
IUSE="doc +introspection" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand what this USE flag does. How does granite change depending on the deps[introspection]
state?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@juippis well... option('introspection', type: 'boolean', value: true, description: 'Whether to build introspection files')
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But you don't have it defined in src_configure
:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@juippis Blame the last maintainer. >:-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@juippis Oh! Optional introspection support is only on master!
Pull request CI reportReport generated at: 2021-01-29 18:52 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
…doc fixes; bump to 5.5.0 Package-Manager: Portage-3.0.12, Repoman-3.0.2 Signed-off-by: Maciej Barć <xgqt@protonmail.com>
Pull request CI reportReport generated at: 2021-01-30 14:31 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Thanks for cooperation. |
Package-Manager: Portage-3.0.12, Repoman-3.0.2
Signed-off-by: Maciej Barć xgqt@protonmail.com