eclass/toolchain-funcs: new function tc-ld-force-bfd() #19116
Conversation
Pull Request assignmentSubmitter: @telans @gentoo/github Linked bugsNo bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment. New packagesThis Pull Request appears to be introducing new packages only. Due to limited manpower, adding new packages is considered low priority. This does not mean that your Pull Request will not receive any attention, however, it might take quite some time for it to be reviewed. In the meantime, your new ebuild might find a home in the GURU project repository: the ebuild repository maintained collaboratively by Gentoo users. GURU offers your ebuild a place to be reviewed and improved by other Gentoo users, while making it easy for Gentoo users to install it and enjoy the software it adds. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
the
need assignment
telans
force-pushed
the
toolchain-funcs-tc-ld-disable-lld
branch
from
9bc7a56
to
5746338
Compare
Pull request CI reportReport generated at: 2021-01-19 06:44 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Yes, this seems like a much nicer solution. I would probably call it We could also retain |
telans
changed the title
telans
force-pushed
the
toolchain-funcs-tc-ld-disable-lld
branch
from
5746338
to
70aecf2
Compare
Done, this is definitely better. |
Pull request CI reportReport generated at: 2021-01-20 10:54 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
There was a problem hiding this comment.
I think you should replace the body of tc-ld-disable-gold with a call to tc-ld-force-bfd. It should also be marked as deprecated.
Please remove "eclass/" from the summary line in the commit message.
This patch should then be sent to the gentoo-dev mailing list for official review.
telans
force-pushed
the
toolchain-funcs-tc-ld-disable-lld
branch
3 times, most recently
from
6760549
to
c0894e3
Compare
Pull request CI reportReport generated at: 2021-01-20 20:59 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Pull request CI reportReport generated at: 2021-01-20 21:29 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
No functions currently force ld.bfd usage when ld.lld is active. This function forces ld.bfd when either ld.gold or ld.lld is active. tc-ld-disable-gold() now calls this new function only if ld.gold is active. Package-Manager: Portage-3.0.14, Repoman-3.0.2 Signed-off-by: Theo Anderson <telans@posteo.de>
telans
force-pushed
the
toolchain-funcs-tc-ld-disable-lld
branch
from
c0894e3
to
7610786
Compare
Pull request CI reportReport generated at: 2021-01-21 11:34 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
|
Pulled as is. Thank you! |
Package-Manager: Portage-3.0.13, Repoman-3.0.2
Signed-off-by: Theo Anderson telans@posteo.de