Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sys-devel/autoconf-2.69-r3: add support for runstatedir #1924

Closed
wants to merge 2 commits into from

Conversation

candrews
Copy link
Member

Backported from autoconf 2.70

https://bugs.gentoo.org/show_bug.cgi?id=589248

@mgorny
Copy link
Member

mgorny commented Jul 20, 2016

This sounds like a very bad idea. You're intentionally diverging from upstream for no real benefit.

If a configure script relies on this, it will need to require at least autoconf 2.70. Therefore, it will reject Gentoo 2.69 anyway.

If a configure script originates from Gentoo, people will mistakenly put 2.69 and have it break everywhere else.

@candrews
Copy link
Member Author

Configure scripts can be written defensively to use runstatedir only if it's available. For example:

and more

Also, if hyper conservative Debian can include this patch and thinks it's a good idea, that seems to indicate that it probably is okay.

@mgorny
Copy link
Member

mgorny commented Jul 20, 2016

Gentoo is more conservative than Debian these days. Though both often get harm enough due to thoughtlessness of developers who care for nothing but testing their whims.

@mgorny
Copy link
Member

mgorny commented Aug 5, 2016

@gentoo/base-system

@mgorny mgorny added enhancement assigned PR successfully assigned to the package maintainer(s). labels Aug 5, 2016
@robbat2
Copy link
Contributor

robbat2 commented Aug 5, 2016

@mgorny The other day for work stuff, I came across a configure.ac that didn't realize this macro was so new, and was mysteriously failing, so I'm in favor of including it, just marking that it's backported 2.70 (it would help if upstream autoconf actually made a release as it's been many years).

@candrews
Copy link
Member Author

candrews commented Aug 5, 2016

I tried to get autoconf to make a release, but it doesn't look good. @robbat2 perhaps you could offer to assist them in doing so?

Here's the thread where I requested the release: https://lists.gnu.org/archive/html/autoconf/2016-07/msg00011.html

@robbat2
Copy link
Contributor

robbat2 commented Aug 5, 2016

@candrews Ha, free time to do so, not like that exists. I would echo Julien's request on the list to release 2.70 as-is and get the remaining patches ready for the next release (more frequent releases also help testing).

@candrews
Copy link
Member Author

candrews commented Aug 5, 2016

@robbat2 I suggest you reply to the list and say that. :-)

Copy link
Contributor

@hwoarang hwoarang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SoapGentoo
Copy link
Member

@candrews I'm generally opposed to backporting this. This shifts the blame from upstream GNU to us, and I'd much rather pressure them into releasing 2.70.

@SoapGentoo
Copy link
Member

@candrews I'm closing this, as we're not going to merge this. Let's try and get upstream to finally release a new Autoconf version.

@SoapGentoo SoapGentoo closed this Nov 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s).
Projects
None yet
5 participants