media-libs/lib3mf 2.1.0: version bump #19412

waebbl · 2021-02-11T08:06:14Z

Closes: https://bugs.gentoo.org/769275
Package-Manager: Portage-3.0.14, Repoman-3.0.2
Signed-off-by: Bernd Waibel waebbl-gentoo@posteo.net

Current versions of media-gfx/openscad don't work with this API version and need to be restricted to <lib3mf-2. The upcoming openscad version bump does work with it. See
Bug: https://bugs.gentoo.org/769278

gentoo-bot · 2021-02-11T08:08:05Z

Pull Request assignment

Submitter: @waebbl
Areas affected: ebuilds
Packages affected: media-gfx/openscad, media-libs/lib3mf

media-gfx/openscad: ~~waebbl-gentoo[at]posteo.net~~, @gentoo/proxy-maint
media-libs/lib3mf: ~~waebbl-gentoo[at]posteo.net~~, @gentoo/proxy-maint

Linked bugs

Bugs linked: 769275

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

gentoo-repo-qa-bot · 2021-02-11T08:20:23Z

Pull request CI report

Report generated at: 2021-02-11 08:20 UTC
Newest commit scanned: f64a67d
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/3717101b3e/output.html

waebbl · 2021-02-13T09:51:24Z

Switching openscad live ebuild to use cmake instead of qmake. Works with both, lib3mf-1.8.1 and lib3mf-2.1.0. Latter needs a patch due to a case change from lib3MF.pc to lib3mf.pc.

waebbl · 2021-02-13T10:18:34Z

For the act dependency needed to re-add keywords for x86 and arm see #19411

gentoo-repo-qa-bot · 2021-02-13T10:25:25Z

Pull request CI report

Report generated at: 2021-02-13 10:25 UTC
Newest commit scanned: 8aade9e
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/a023dd9f6e/output.html

gentoo-repo-qa-bot · 2021-03-01T23:30:18Z

Pull request CI report

Report generated at: 2021-03-01 23:30 UTC
Newest commit scanned: 928430f
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/62a2119fd8/output.html

juippis · 2021-03-06T14:58:58Z

Is the act dependency still needed? Can we somehow combine this PR with #19714?

juippis · 2021-03-06T14:59:54Z

Actually could you combine all the related work to a single PR. I'm at loss, and am fearing there'll be tree breakage or unnecessary rebuilds for users. Openscad is not a little package.

waebbl · 2021-03-06T15:05:07Z

@juippis Sure, I can combine them in a single PR.

The act package is 'only' needed to get x86 and arm keywords back to lib3mf. For amd64 the included binary does the job. Should I add it to the PR too?

juippis · 2021-03-06T15:14:09Z

Up to you, I quickly glanced at the ebuild and it might need .. a lot of fixes before it can be pushed. So maybe best to leave it out for now.

waebbl · 2021-03-06T15:35:45Z

Yes it might need some rework. The point with the package is, that upstream doesn't follow the usual way Go packages are developed, so the Go eclasses don't seem to be useful. On the other hand the build is rather trivial, so I decided for the way it's done.
I agree, it's better to leave it out for now and wait for a dedicated review of the package.

juippis · 2021-03-06T15:40:28Z

I've nearly caught up with our PR work queue, please ping me in ~a week from now for the act package and I'll take a look.

Closes: https://bugs.gentoo.org/769275 Package-Manager: Portage-3.0.14, Repoman-3.0.2 Signed-off-by: Bernd Waibel <waebbl-gentoo@posteo.net>

This package version does not build against lib3mf-2 API. Package-Manager: Portage-3.0.14, Repoman-3.0.2 Signed-off-by: Bernd Waibel <waebbl-gentoo@posteo.net>

Now uses cmake instead of qmake. Package-Manager: Portage-3.0.14, Repoman-3.0.2 Signed-off-by: Bernd Waibel <waebbl-gentoo@posteo.net>

Bug: https://bugs.gentoo.org/773217 Closes: https://bugs.gentoo.org/769278 Package-Manager: Portage-3.0.16, Repoman-3.0.2 Signed-off-by: Bernd Waibel <waebbl-gentoo@posteo.net>

gentoo-repo-qa-bot · 2021-03-06T23:50:19Z

Pull request CI report

Report generated at: 2021-03-06 23:50 UTC
Newest commit scanned: 5ed5294
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/ff764ade8e/output.html

juippis

Let me know the answers to my questions, there's no need for you to do anything, I can fix those minor issues while merging.

juippis · 2021-03-07T07:18:23Z

media-gfx/openscad/openscad-2019.05-r4.ebuild

@@ -46,7 +46,7 @@ RDEPEND="
 	media-libs/freetype
 	>=media-libs/glew-2.0.0:0=
 	media-libs/harfbuzz:=
-	media-libs/lib3mf
+	<media-libs/lib3mf-2


Will the update cause runtime issues? Ie should this be revbumped for this...

2019.05 will not build with lib3mf-2. Lib3mf-2 has been released after 2019.05 and support for it has not been backported

The idea is, people who have 2019.05-r4 installed now will update to lib3mf-2, because the restriction won't hit their package database before a rebuild. So, if lib3mf-2 will cause runtime issues to openscad-2019.05, this ebuilds needs t obe revbumped so that won't happen.

As the package won't build with lib3mf-2 I suspect it will cause runtime issues, whenever someone tries to im-/export a 3mf format file.
I'm gonna revbump the package then.

juippis · 2021-03-07T07:43:56Z

media-gfx/openscad/openscad-2021.01.ebuild

+	media-libs/freetype
+	>=media-libs/glew-2.0.0:0=
+	media-libs/harfbuzz:=
+	media-libs/lib3mf


Does this work with both 1 and 2? Is some restriction needed? That's also why I asked to combine the PRs so that no modification is needed for this version after merging.

The new version works with both lib3mf versions.

waebbl marked this pull request as draft February 11, 2021 08:06

gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Feb 11, 2021

waebbl force-pushed the lib3mf-2.1.0 branch from f64a67d to 8aade9e Compare February 13, 2021 09:48

waebbl marked this pull request as ready for review February 13, 2021 09:49

waebbl force-pushed the lib3mf-2.1.0 branch from 8aade9e to 928430f Compare March 1, 2021 23:09

waebbl added 4 commits March 6, 2021 16:53

media-libs/lib3mf: bump to 2.1.0

771f1e9

Closes: https://bugs.gentoo.org/769275 Package-Manager: Portage-3.0.14, Repoman-3.0.2 Signed-off-by: Bernd Waibel <waebbl-gentoo@posteo.net>

media-gfx/openscad: restrict dependency

3b6b2c7

This package version does not build against lib3mf-2 API. Package-Manager: Portage-3.0.14, Repoman-3.0.2 Signed-off-by: Bernd Waibel <waebbl-gentoo@posteo.net>

media-gfx/openscad: adapt to work with lib3mf-2

8fc53a5

Now uses cmake instead of qmake. Package-Manager: Portage-3.0.14, Repoman-3.0.2 Signed-off-by: Bernd Waibel <waebbl-gentoo@posteo.net>

media-gfx/openscad: bump to 2021.01

5ed5294

Bug: https://bugs.gentoo.org/773217 Closes: https://bugs.gentoo.org/769278 Package-Manager: Portage-3.0.16, Repoman-3.0.2 Signed-off-by: Bernd Waibel <waebbl-gentoo@posteo.net>

waebbl force-pushed the lib3mf-2.1.0 branch from 928430f to 5ed5294 Compare March 6, 2021 23:00

waebbl mentioned this pull request Mar 6, 2021

media-gfx/openscad: bump to 2021.01 #19714

Closed

juippis reviewed Mar 7, 2021

View reviewed changes

juippis approved these changes Mar 7, 2021

View reviewed changes

gentoo-bot closed this in 764dd0f Mar 7, 2021

waebbl deleted the lib3mf-2.1.0 branch March 7, 2021 14:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

media-libs/lib3mf 2.1.0: version bump #19412

media-libs/lib3mf 2.1.0: version bump #19412

waebbl commented Feb 11, 2021 •

edited

gentoo-bot commented Feb 11, 2021

gentoo-repo-qa-bot commented Feb 11, 2021

waebbl commented Feb 13, 2021

waebbl commented Feb 13, 2021

gentoo-repo-qa-bot commented Feb 13, 2021

gentoo-repo-qa-bot commented Mar 1, 2021

juippis commented Mar 6, 2021

juippis commented Mar 6, 2021

waebbl commented Mar 6, 2021

juippis commented Mar 6, 2021

waebbl commented Mar 6, 2021 •

edited

juippis commented Mar 6, 2021

gentoo-repo-qa-bot commented Mar 6, 2021

juippis left a comment

juippis Mar 7, 2021

waebbl Mar 7, 2021

juippis Mar 7, 2021

waebbl Mar 7, 2021

juippis Mar 7, 2021

waebbl Mar 7, 2021

media-libs/lib3mf 2.1.0: version bump #19412

media-libs/lib3mf 2.1.0: version bump #19412

Conversation

waebbl commented Feb 11, 2021 • edited

gentoo-bot commented Feb 11, 2021

Pull Request assignment

Linked bugs

gentoo-repo-qa-bot commented Feb 11, 2021

Pull request CI report

waebbl commented Feb 13, 2021

waebbl commented Feb 13, 2021

gentoo-repo-qa-bot commented Feb 13, 2021

Pull request CI report

gentoo-repo-qa-bot commented Mar 1, 2021

Pull request CI report

juippis commented Mar 6, 2021

juippis commented Mar 6, 2021

waebbl commented Mar 6, 2021

juippis commented Mar 6, 2021

waebbl commented Mar 6, 2021 • edited

juippis commented Mar 6, 2021

gentoo-repo-qa-bot commented Mar 6, 2021

Pull request CI report

juippis left a comment

Choose a reason for hiding this comment

juippis Mar 7, 2021

Choose a reason for hiding this comment

waebbl Mar 7, 2021

Choose a reason for hiding this comment

juippis Mar 7, 2021

Choose a reason for hiding this comment

waebbl Mar 7, 2021

Choose a reason for hiding this comment

juippis Mar 7, 2021

Choose a reason for hiding this comment

waebbl Mar 7, 2021

Choose a reason for hiding this comment

waebbl commented Feb 11, 2021 •

edited

waebbl commented Mar 6, 2021 •

edited