dev-python/elasticsearch-curator: Add missing dependencies #19538

vibpe · 2021-02-19T09:28:43Z

Add missing importlib_metadata and cx_Freeze dependencies
Closes: https://bugs.gentoo.org/761325
Signed-off-by: Peter Vielberth code@peter-vielberth.de
Package-Manager: Portage-3.0.14, Repoman-3.0.2

Add missing importlib_metadata and cx_Freeze dependencies Closes: https://bugs.gentoo.org/761325 Signed-off-by: Peter Vielberth <code@peter-vielberth.de> Package-Manager: Portage-3.0.14, Repoman-3.0.2

gentoo-bot · 2021-02-19T09:32:05Z

Pull Request assignment

Submitter: @vibpe
Areas affected: ebuilds
Packages affected: dev-python/elasticsearch-curator

dev-python/elasticsearch-curator: @gentoo/proxy-maint (maintainer needed)

Linked bugs

Bugs linked: 761325

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

gentoo-repo-qa-bot · 2021-02-19T09:45:40Z

Pull request CI report

Report generated at: 2021-02-19 09:45 UTC
Newest commit scanned: 45eed85
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/d680f7f26d/output.html

vaukai · 2021-02-19T10:33:07Z

dev-python/elasticsearch-curator/elasticsearch-curator-5.8.1-r3.ebuild

+
+EAPI=7
+
+PYTHON_COMPAT=( python3_7 )


Does it not support python3_8 and python3_9?
https://archives.gentoo.org/gentoo-dev/message/ba2fc4854ed6bb49813819ae6f5e9552

It probably also compiles with python3_8 and python3_9. I just copied the existing -r2 ebuild and added the missing dependencies.

Now I tried to change this line in a local overlay to PYTHON_COMPAT=( python3_{7..9} )
But then emerge demands a use flag change:

# required by dev-python/elasticsearch-curator (argument)
>=dev-python/elasticsearch-curator-5.8.1-r3 -python_targets_python3_8

I don't know why. All dependencies listed in the ebuild support at least python3_8.

Looks like curator still has some problems with python3_8 (failing tests)
elastic/curator#1512

Looks like curator still has some problems with python3_8 (failing tests)
elastic/curator#1512

Please see elastic/curator#1587 (comment)
You also want to bump to most recent version which is presently 5.8.3 instead of sticking to 5.8.1

It probably also compiles with python3_8 and python3_9. I just copied the existing -r2 ebuild and added the missing dependencies.

Now I tried to change this line in a local overlay to PYTHON_COMPAT=( python3_{7..9} )
But then emerge demands a use flag change:

# required by dev-python/elasticsearch-curator (argument)
>=dev-python/elasticsearch-curator-5.8.1-r3 -python_targets_python3_8

I don't know why. All dependencies listed in the ebuild support at least python3_8.

You want use elasticsearch-curator-5.8.3 and add python3_9 to importlib_metadata-3.4.0 and elasticsearch-py-7.7.0

I also had to add python3_9 to dev-python/click

I added a 5.8.3 ebuild for elasticsearch-curator, it compiled using python targets 3_7, 3_8 and 3_9. Tested it against my elasticsearch instance. Looks fine to me.

However when I run repoman ci on the importlib_metadata-3.4.0 change (adding python3_9), I get an error:

dependency.bad [fatal] 80 dev-python/importlib_metadata/importlib_metadata-3.4.0.ebuild: BDEPEND: ~alpha(default/linux/alpha/17.0) [ '>=dev-python/importlib_resources-1.3.0[python_targets_pypy3(-)?,python_targets_python3_7(-)?,python_targets_python3_8(-)?,python_targets_python3_9(-)?,-python_single_target_pypy3(-),-python_single_target_python3_7(-),-python_single_target_python3_8(-),-python_single_target_python3_9(-)]'] dev-python/importlib_metadata/importlib_metadata-3.4.0.ebuild: BDEPEND: ~alpha(default/linux/alpha/17.0/desktop) [ '>=dev-python/importlib_resources-1.3.0[python_targets_pypy3(-)?,python_targets_python3_7(-)?,python_targets_python3_8(-)?,python_targets_python3_9(-) ...

I thought of adding python3_9 to importlib_resources, too. But this comment in the ebuild kept me from doing so:

This is a backport of Python 3.9's importlib.

I'm not a Python developer and don't want to mess with dependencies and version conflicts which I don't understand

Anyway, I added the python3_9 dependency to importlib_resources and importlib_metadata to get past the CI analysis.

Please have a look at this change if its sensible.

vaukai · 2021-02-20T12:04:27Z

dev-python/elasticsearch-curator/elasticsearch-curator-5.8.1-r3.ebuild

+	>=dev-python/certifi-2019.9.11[${PYTHON_USEDEP}]
+	>=dev-python/requests-2.20.0[${PYTHON_USEDEP}]
+	>=dev-python/urllib3-1.24.2[${PYTHON_USEDEP}]
+	<dev-python/urllib3-1.26[${PYTHON_USEDEP}]


Try without downgrading urllib3

Would like to use a current urllib3 version. But this is a requirement of elasticsearch curator. Please see this commit: elastic/curator@99bb6d4

As compilation with dev-python/urllib3-1.26.2-r3 works here, can you find out what's upsteam's intention with pinning that dependency?

Compiling with dev-python/urllib3-1.26.2-r3 works here, too. Also got no errors while testing.

Asked upstream: elastic/curator#1589

Could you also comment this on https://bugs.gentoo.org/714860 please?

gentoo-repo-qa-bot · 2021-02-20T17:40:27Z

Pull request CI report

Report generated at: 2021-02-20 17:40 UTC
Newest commit scanned: e6e8fa2
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/23b11609d0/output.html

gentoo-repo-qa-bot · 2021-02-20T18:20:25Z

Pull request CI report

Report generated at: 2021-02-20 18:20 UTC
Newest commit scanned: bf16da8
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/8a485b8a0a/output.html

vaukai · 2021-02-20T19:32:22Z

dev-python/click/click-6.7-r2.ebuild

@@ -1,9 +1,9 @@
-# Copyright 1999-2020 Gentoo Authors


6.7-r2 is already partly stable and should not be changed without revbump
And there is also 7.1.2-r2 ...

vaukai · 2021-02-20T19:37:26Z

dev-python/elasticsearch-py/elasticsearch-py-7.7.0.ebuild

@@ -1,9 +1,9 @@
-# Copyright 1999-2020 Gentoo Authors


Don't change PYTHON_COMPAT on stable versions.

No, it's okay to do that -- please do add new PYTHON_COMPAT wherever it works (and tests pass - FEATURES=test emerge ...)

gentoo-repo-qa-bot · 2021-02-22T00:10:49Z

Pull request CI report

Report generated at: 2021-02-22 00:10 UTC
Newest commit scanned: 5d7eefb
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/b3eb11697a/output.html

vaukai · 2021-02-22T07:27:48Z

Commits 9d34f51, a6fde93 and 5d7eefb should be squashed into one.
Same for dev-python/click, commits 02fbc1e, 6f11e64 and 280e75e.

elasticsearch-curator updated to 5.8.3 Signed-off-by: Peter Vielberth <code@peter-vielberth.de> Package-Manager: Portage-3.0.14, Repoman-3.0.2

Package-Manager: Portage-3.0.14, Repoman-3.0.2 Signed-off-by: Peter Vielberth <code@peter-vielberth.de>

gentoo-repo-qa-bot · 2021-02-22T12:45:53Z

Pull request CI report

Report generated at: 2021-02-22 12:45 UTC
Newest commit scanned: 69cd79d
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/6c29458972/output.html

thesamesam · 2021-03-09T10:03:32Z

Merged, thank you! (Dropped the 3.9 commits for importlib*)

dev-python/elasticsearch-curator: Add missing dependencies

45eed85

Add missing importlib_metadata and cx_Freeze dependencies Closes: https://bugs.gentoo.org/761325 Signed-off-by: Peter Vielberth <code@peter-vielberth.de> Package-Manager: Portage-3.0.14, Repoman-3.0.2

gentoo-bot added maintainer-needed There is at least one affected package with no maintainer. Review it if you can. assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Feb 19, 2021

vaukai reviewed Feb 19, 2021

View reviewed changes

vaukai reviewed Feb 20, 2021

View reviewed changes

vibpe force-pushed the elastic-curator branch from e6e8fa2 to bf16da8 Compare February 20, 2021 18:01

vaukai reviewed Feb 20, 2021

View reviewed changes

vibpe added 5 commits February 22, 2021 13:04

dev-python/elasticsearch-curator: upgrade to 5.8.3

37b7b8c

elasticsearch-curator updated to 5.8.3 Signed-off-by: Peter Vielberth <code@peter-vielberth.de> Package-Manager: Portage-3.0.14, Repoman-3.0.2

dev-python/elasticsearch-py: added python 3.9 support

7f6beba

Package-Manager: Portage-3.0.14, Repoman-3.0.2 Signed-off-by: Peter Vielberth <code@peter-vielberth.de>

dev-python/click: added python 3.9 support

4848fa3

Package-Manager: Portage-3.0.14, Repoman-3.0.2 Signed-off-by: Peter Vielberth <code@peter-vielberth.de>

dev-python/importlib_resources: added python 3.9 support

cf1308e

Package-Manager: Portage-3.0.14, Repoman-3.0.2 Signed-off-by: Peter Vielberth <code@peter-vielberth.de>

dev-python/importlib_metadata: added python 3.9 support

69cd79d

Package-Manager: Portage-3.0.14, Repoman-3.0.2 Signed-off-by: Peter Vielberth <code@peter-vielberth.de>

vibpe force-pushed the elastic-curator branch from 5d7eefb to 69cd79d Compare February 22, 2021 12:24

thesamesam self-assigned this Mar 9, 2021

thesamesam closed this Mar 9, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

dev-python/elasticsearch-curator: Add missing dependencies #19538

dev-python/elasticsearch-curator: Add missing dependencies #19538

vibpe commented Feb 19, 2021

gentoo-bot commented Feb 19, 2021

gentoo-repo-qa-bot commented Feb 19, 2021

vaukai Feb 19, 2021

vibpe Feb 19, 2021

vibpe Feb 19, 2021

vaukai Feb 20, 2021 •

edited

vaukai Feb 20, 2021

vibpe Feb 20, 2021

vibpe Feb 20, 2021

vaukai Feb 20, 2021

vibpe Feb 20, 2021

vaukai Feb 21, 2021

vibpe Feb 22, 2021 •

edited

vaukai Feb 22, 2021

gentoo-repo-qa-bot commented Feb 20, 2021

gentoo-repo-qa-bot commented Feb 20, 2021

vaukai Feb 20, 2021

vaukai Feb 20, 2021

thesamesam Feb 22, 2021 •

edited

gentoo-repo-qa-bot commented Feb 22, 2021

vaukai commented Feb 22, 2021

gentoo-repo-qa-bot commented Feb 22, 2021

thesamesam commented Mar 9, 2021


		EAPI=7

		PYTHON_COMPAT=( python3_7 )

dev-python/elasticsearch-curator: Add missing dependencies #19538

dev-python/elasticsearch-curator: Add missing dependencies #19538

Conversation

vibpe commented Feb 19, 2021

gentoo-bot commented Feb 19, 2021

Pull Request assignment

Linked bugs

gentoo-repo-qa-bot commented Feb 19, 2021

Pull request CI report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vaukai Feb 20, 2021 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vibpe Feb 22, 2021 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gentoo-repo-qa-bot commented Feb 20, 2021

Pull request CI report

gentoo-repo-qa-bot commented Feb 20, 2021

Pull request CI report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thesamesam Feb 22, 2021 • edited

Choose a reason for hiding this comment

gentoo-repo-qa-bot commented Feb 22, 2021

Pull request CI report

vaukai commented Feb 22, 2021

gentoo-repo-qa-bot commented Feb 22, 2021

Pull request CI report

thesamesam commented Mar 9, 2021

vaukai Feb 20, 2021 •

edited

vibpe Feb 22, 2021 •

edited

thesamesam Feb 22, 2021 •

edited