Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app-text/xmlto: EAPI 7 #19593

Closed
wants to merge 1 commit into from
Closed

app-text/xmlto: EAPI 7 #19593

wants to merge 1 commit into from

Conversation

vaukai
Copy link
Contributor

@vaukai vaukai commented Feb 22, 2021

Closes: https://bugs.gentoo.org/757576

Adding www-client/links as an alternative to virtual/w3m
Closes https://bugs.gentoo.org/726156

Package-Manager: Portage-3.0.13, Repoman-3.0.2
Signed-off-by: Volkmar W. Pogatzki gentoo@pogatzki.net

@gentoo-bot gentoo-bot added maintainer-needed There is at least one affected package with no maintainer. Review it if you can. assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Feb 22, 2021
@vaukai vaukai changed the title app-text/xmlto: EAPI 7 app-text/xmlto: EAPI 7 [please reassign] Feb 22, 2021
@gentoo-bot gentoo-bot changed the title app-text/xmlto: EAPI 7 [please reassign] app-text/xmlto: EAPI 7 Feb 22, 2021
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @vaukai
Areas affected: ebuilds
Packages affected: app-text/xmlto

app-text/xmlto: @gentoo/proxy-maint (maintainer needed)

Linked bugs

Bugs linked: 757576, 726156


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added maintainer-needed There is at least one affected package with no maintainer. Review it if you can. assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. and removed assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. maintainer-needed There is at least one affected package with no maintainer. Review it if you can. labels Feb 22, 2021
app-text/xmlto/xmlto-0.0.28-r4.ebuild Outdated Show resolved Hide resolved
app-text/xmlto/xmlto-0.0.28-r4.ebuild Outdated Show resolved Hide resolved
app-text/xmlto/xmlto-0.0.28-r4.ebuild Outdated Show resolved Hide resolved
text? ( || ( virtual/w3m www-client/elinks www-client/links www-client/lynx ) )
latex? ( dev-texlive/texlive-formatsextra )"
# We only depend on flex when we patch the imput lexer.
DEPEND="${RDEPEND}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot/all of these are probably actually BDEPEND?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we changing it then? (i.e. do not define DEPEND or define it to be a small subset?)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For BDEPEND, from a quick strace and outside base set (e.g. excuding sed/which), flex, m4, util-linux, and pkgconfig were called regardless of USE.

Not that I really checked this package in-depth, but it been bothering me for a while and glad someone is looking at it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually scratch pkg-config, that one's not needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When running
ebuild xmlto-0.0.28-r4.ebuild clean configure | grep 'checking for'
would all that output be BDEPEND?

Copy link
Contributor

@ionenwks ionenwks Feb 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not all of them are actually ran, it just checks if they exist.. which I guess mean they may need to be in normal DEPEND to be detected :| But again, most of those are base set and sed/bash/which seem weird to define.
Edit: anyway I'll stop rambling, haven't checked the package closely enough to answer what it needs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we changing it then? (i.e. do not define DEPEND or define it to be a small subset?)

Sorry here. I am still lost with the {B,R,}dependencies stuff. Only removed some Implicit System Dependencies for now according to devmanual.
Need to find a reliable method to distinguish the runtime and build dependencies.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and could not find any of those dependencies being BDEPEND. None of them needed for compilation.
Removed base set packages from the list.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We actually should keep @ system stuff but no need for sed/Bash/anything specified by PMS. I'll make a note to update the devmanual to be more explicit.

Having @ system elements in there means we can parallelise emerges better.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-02-22 10:35 UTC
Newest commit scanned: e97753a
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/cc30f9d859/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-02-22 13:15 UTC
Newest commit scanned: e8e84de
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/3bbe8df591/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-02-23 11:40 UTC
Newest commit scanned: d186ce7
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/42e7494128/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-02-23 11:55 UTC
Newest commit scanned: 10b88a2
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/29600ab77f/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-02-23 12:25 UTC
Newest commit scanned: 51ee29d
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/d823bc30a8/output.html

Closes: https://bugs.gentoo.org/757576

Adding www-client/links as an alternative to virtual/w3m
Closes: https://bugs.gentoo.org/726156

Package-Manager: Portage-3.0.13, Repoman-3.0.2
Signed-off-by: Volkmar W. Pogatzki <gentoo@pogatzki.net>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-02-23 13:30 UTC
Newest commit scanned: bb86353
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/595264b716/output.html

@thesamesam thesamesam self-requested a review February 25, 2021 19:09
Copy link
Member

@thesamesam thesamesam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Minor style changes made in b3a2f4f.

@vaukai vaukai deleted the xmlto branch February 27, 2021 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. maintainer-needed There is at least one affected package with no maintainer. Review it if you can.
Projects
None yet
5 participants