Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sys-libs/compiler-rt-sanitizers: Filter -D_FORTIFY_SOURCE away #19788

Conversation

lanodan
Copy link
Contributor

@lanodan lanodan commented Mar 6, 2021

Closes: https://bugs.gentoo.org/636604
Signed-off-by: Haelwenn (lanodan) Monnier contact@hacktivis.me

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @lanodan
Areas affected: ebuilds
Packages affected: sys-libs/compiler-rt-sanitizers

sys-libs/compiler-rt-sanitizers: @gentoo/llvm

Linked bugs

Bugs linked: 636604


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Mar 6, 2021
@lanodan
Copy link
Contributor Author

lanodan commented Mar 6, 2021

I'm also modifying stabilized ebuilds there, not sure if that's allowed, could remove those out of this diff or do a revbump.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-03-06 02:40 UTC
Newest commit scanned: 834b8e8
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/3f3c0b81a4/output.html

@lanodan lanodan force-pushed the bugfix/compiler-rt-sanitizers_fortify_source branch from 834b8e8 to 286a0a5 Compare March 6, 2021 09:28
@mgorny
Copy link
Member

mgorny commented Mar 6, 2021

@gentoo/toolchain is this a good idea? Sounds a bit like un-hardening to me but it might be necessary anyway for sanitizers.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-03-06 09:55 UTC
Newest commit scanned: 286a0a5
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/4c0935ff82/output.html

@lanodan
Copy link
Contributor Author

lanodan commented Apr 10, 2021

Any updates on this topic?

@mgorny
Copy link
Member

mgorny commented Apr 21, 2021

<@dilfridge> https://github.com/google/sanitizers/issues/247
<@dilfridge> https://reviews.llvm.org/D92521
<@dilfridge> https://reviews.llvm.org/D93877
<@dilfridge> ^ the last one is what you want to backport

Could you try that patch instead?

@lanodan
Copy link
Contributor Author

lanodan commented Apr 22, 2021

Could you try that patch instead?

Tried it against 11.1.0 and it works fine. Will change & test the other ebuilds.

Update: Done

Signed-off-by: Haelwenn (lanodan) Monnier <contact@hacktivis.me>
@lanodan lanodan force-pushed the bugfix/compiler-rt-sanitizers_fortify_source branch from 286a0a5 to 304fd78 Compare April 22, 2021 06:25
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-04-22 06:40 UTC
Newest commit scanned: 304fd78
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/4f77bcdf8b/output.html

@mgorny
Copy link
Member

mgorny commented Apr 24, 2021

Thanks for the testing. I'm going to add the patch into the patchset, test and then bump them.

@mgorny mgorny closed this Apr 24, 2021
@lanodan lanodan deleted the bugfix/compiler-rt-sanitizers_fortify_source branch April 28, 2021 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
4 participants