Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-python/pygal: python 3.9 and tests fix #19969

Closed

Conversation

ZeroPointEnergy
Copy link
Contributor

There are various changes upstream to update the lib, however there is no new release yet. I extracted a minimal patch that fixes the tests and added python 3.9 support.

Closes: https://bugs.gentoo.org/738208

Closes: https://bugs.gentoo.org/738208
Package-Manager: Portage-3.0.13, Repoman-3.0.2
Signed-off-by: Andreas Zuber <a.zuber@gmx.ch>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @ZeroPointEnergy
Areas affected: ebuilds
Packages affected: dev-python/pygal

dev-python/pygal: @gentoo/python

Linked bugs

Bugs linked: 738208


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Mar 17, 2021
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-03-17 11:28 UTC
Newest commit scanned: 3c44d02
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/5a7ba6bbc6/output.html

Package-Manager: Portage-3.0.13, Repoman-3.0.2
Signed-off-by: Andreas Zuber <a.zuber@gmx.ch>
@ZeroPointEnergy
Copy link
Contributor Author

Just saw that the ebuild may have some redundant dependencies defined (setuptools and pytest), removed them. There doesn't seem to be a runtime dependency for setup, at least I can't find any import.

Would be nice if this can get merged. I can't update a package in GURU without it.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-04-08 08:31 UTC
Newest commit scanned: 054414f
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/d1255046b5/output.html

@ZeroPointEnergy
Copy link
Contributor Author

Anything I can do to help move this along?

@Whissi
Copy link
Contributor

Whissi commented May 18, 2021

Thank you, looks good. Passing all tests for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
4 participants