New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sci-geosciences/GeographicLib: improvements #20118
sci-geosciences/GeographicLib: improvements #20118
Conversation
Pull request CI reportReport generated at: 2021-03-25 19:14 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
err 'replace ebuild by the one in guru' doesn't provide much info on what the commit actually does |
Should I build the examples or I only install the source for them? |
if they don't do anything useful, IMHO it's better just to install the sources |
dc68353
to
2f83b4d
Compare
Pull request CI reportReport generated at: 2021-04-03 14:30 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Pull Request assignmentSubmitter: @Alessandro-Barbieri sci-geosciences/GeographicLib: At least one of the listed packages is maintained entirely by non-GitHub developers! Linked bugsIn order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
I've moved the data to a new package in guru |
@aballier can you re review? |
2f83b4d
to
7251daa
Compare
@aballier ready to be merged |
Pull request CI reportReport generated at: 2021-05-08 11:44 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
>=app-doc/doxygen-1.8.7 | ||
>=dev-lang/perl-5.26.1-r1 | ||
>=dev-python/sphinx-1.6.3-r2 | ||
>=sys-apps/util-linux-2.31 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are probably BDEPEND I think, at least sphinx and doxygen are things that are typically executed during build time.
Also, the docs
eclass might be able to simplify things here
|
||
# remove python things added by the cmake_src_install function | ||
# these are installed in the wrong python dir | ||
rm -rf "${D}/usr/$(get_libdir)/python" || die |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might be able to fix this path (and the doc one) in the configure phase with an appropriate -D....=...
option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
which one? DOCDIR
doesn't get picked up by cmake
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
even if I fix the python install path, python modules needs to be installed multiple times in multiple paths
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
even if I fix the python install path, python modules needs to be installed multiple times in multiple paths
Good point, never mind then
python bindings examples documentation Closes: https://bugs.gentoo.org/636338 Closes: https://bugs.gentoo.org/777810 Package-Manager: Portage-3.0.17, Repoman-3.0.2 Signed-off-by: Alessandro Barbieri <lssndrbarbieri@gmail.com>
7251daa
to
f81cd74
Compare
Pull request CI reportReport generated at: 2021-05-26 19:45 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Closes: https://bugs.gentoo.org/636338
Closes: https://bugs.gentoo.org/777810
Package-Manager: Portage-3.0.17, Repoman-3.0.2
Signed-off-by: Alessandro Barbieri lssndrbarbieri@gmail.com