Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sci-geosciences/GeographicLib: improvements #20118

Closed

Conversation

Alessandro-Barbieri
Copy link
Contributor

Closes: https://bugs.gentoo.org/636338
Closes: https://bugs.gentoo.org/777810
Package-Manager: Portage-3.0.17, Repoman-3.0.2
Signed-off-by: Alessandro Barbieri lssndrbarbieri@gmail.com

@gentoo-bot gentoo-bot added need assignment It was impossible to assign the PR correctly. Please assign it manually. bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Mar 25, 2021
@Alessandro-Barbieri
Copy link
Contributor Author

@aballier

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-03-25 19:14 UTC
Newest commit scanned: dc68353
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/d03a87ff95/output.html

@aballier
Copy link
Contributor

aballier commented Apr 2, 2021

err 'replace ebuild by the one in guru' doesn't provide much info on what the commit actually does
I would suggest splitting the changes in several relatively atomic commits so that the improvements are clear

@Alessandro-Barbieri
Copy link
Contributor Author

Should I build the examples or I only install the source for them?

@aballier
Copy link
Contributor

aballier commented Apr 3, 2021

Should I build the examples or I only install the source for them?

if they don't do anything useful, IMHO it's better just to install the sources

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-04-03 14:30 UTC
Newest commit scanned: 2f83b4d
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/69c3bd6b89/output.html

@Alessandro-Barbieri Alessandro-Barbieri changed the title sci-geosciences/GeographicLib: use ebuild from GURU sci-geosciences/GeographicLib: improvements Apr 3, 2021
@Alessandro-Barbieri Alessandro-Barbieri changed the title sci-geosciences/GeographicLib: improvements sci-geosciences/GeographicLib: use ebuild from GURU [please reassign] Apr 3, 2021
@gentoo-bot gentoo-bot changed the title sci-geosciences/GeographicLib: use ebuild from GURU [please reassign] sci-geosciences/GeographicLib: use ebuild from GURU Apr 3, 2021
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @Alessandro-Barbieri
Areas affected: ebuilds
Packages affected: sci-geosciences/GeographicLib

sci-geosciences/GeographicLib: [ros (project)]

At least one of the listed packages is maintained entirely by non-GitHub developers!

Linked bugs

Bugs linked: 636338, 777810


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added need assignment It was impossible to assign the PR correctly. Please assign it manually. bug linked Bug/Closes found in footer, and cross-linked with the PR. and removed bug linked Bug/Closes found in footer, and cross-linked with the PR. need assignment It was impossible to assign the PR correctly. Please assign it manually. labels Apr 3, 2021
@Alessandro-Barbieri Alessandro-Barbieri changed the title sci-geosciences/GeographicLib: use ebuild from GURU sci-geosciences/GeographicLib: improvements Apr 3, 2021
@Alessandro-Barbieri
Copy link
Contributor Author

I've moved the data to a new package in guru

@Alessandro-Barbieri
Copy link
Contributor Author

@aballier can you re review?

@Alessandro-Barbieri
Copy link
Contributor Author

@aballier ready to be merged

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-05-08 11:44 UTC
Newest commit scanned: 7251daa
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/bfcb28c4f9/output.html

>=app-doc/doxygen-1.8.7
>=dev-lang/perl-5.26.1-r1
>=dev-python/sphinx-1.6.3-r2
>=sys-apps/util-linux-2.31
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are probably BDEPEND I think, at least sphinx and doxygen are things that are typically executed during build time.

Also, the docs eclass might be able to simplify things here


# remove python things added by the cmake_src_install function
# these are installed in the wrong python dir
rm -rf "${D}/usr/$(get_libdir)/python" || die
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might be able to fix this path (and the doc one) in the configure phase with an appropriate -D....=... option.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which one? DOCDIR doesn't get picked up by cmake

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

even if I fix the python install path, python modules needs to be installed multiple times in multiple paths

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

even if I fix the python install path, python modules needs to be installed multiple times in multiple paths

Good point, never mind then

python bindings
examples
documentation

Closes: https://bugs.gentoo.org/636338
Closes: https://bugs.gentoo.org/777810

Package-Manager: Portage-3.0.17, Repoman-3.0.2
Signed-off-by: Alessandro Barbieri <lssndrbarbieri@gmail.com>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-05-26 19:45 UTC
Newest commit scanned: f81cd74
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/11153ca6ae/output.html

@gentoo-bot gentoo-bot closed this in 3cabbb8 Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug linked Bug/Closes found in footer, and cross-linked with the PR. need assignment It was impossible to assign the PR correctly. Please assign it manually.
Projects
None yet
5 participants